Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Use IValueTaskSource in PipeStream on Windows#52695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@manandre
Copy link
Contributor

Use IValueTaskSource in NamedPipeServerStream on Windows
Remove PipeCompletionSource

Closes#51463

/cc@stephentoub

@ghostghost added the area-System.IO labelMay 13, 2021
@ghost
Copy link

Tagging subscribers to this area:@carlossanlop
See info inarea-owners.md if you want to be subscribed.

Issue Details

Use IValueTaskSource in NamedPipeServerStream on Windows
Remove PipeCompletionSource

Closes#51463

/cc@stephentoub

Author:manandre
Assignees:-
Labels:

area-System.IO

Milestone:-

@carlossanlopcarlossanlop modified the milestones:Future,6.0.0May 14, 2021
@manandremanandreforce-pushed thepipestream-ivaluetasksource branch 3 times, most recently froma98fa7c to3ab26fbCompareJune 3, 2021 10:38
@terrajobstterrajobst added the community-contributionIndicates that the PR has been added by a community member labelJul 19, 2021
@jeffhandley
Copy link
Member

@stephentoub This PR is assigned to you for follow-up/decision before the RC1 snap.

@stephentoubstephentoubforce-pushed thepipestream-ivaluetasksource branch from3ab26fb toa218fedCompareJuly 27, 2021 20:51
@stephentoub
Copy link
Member

I pushed a commit to revise the implementation to match the latest in FileStream.

As for the perf tests, the tests themselves aren't great. I've revised them indotnet/performance#1897. The relevant ones look fine:

TypeMethodJobToolchainsizeOptionsMeanErrorStdDevMedianMinMaxRatioRatioSDGen 0Gen 1Gen 2Allocated
Perf_NamedPipeStreamReadWriteJob-JQMLDS\main\CoreRun.exe1000000Asynchronous135.7 us4.70 us5.41 us135.8 us125.9 us147.4 us1.000.00---707 B
Perf_NamedPipeStreamReadWriteJob-ZLUHJI\pr\CoreRun.exe1000000Asynchronous137.0 us1.03 us0.91 us137.0 us135.5 us138.5 us1.000.04---336 B
Perf_NamedPipeStreamReadWriteAsyncJob-JQMLDS\main\CoreRun.exe1000000Asynchronous137.3 us0.98 us0.86 us137.0 us136.3 us139.4 us1.000.00---641 B
Perf_NamedPipeStreamReadWriteAsyncJob-ZLUHJI\pr\CoreRun.exe1000000Asynchronous134.7 us1.01 us0.95 us134.7 us132.7 us136.4 us0.980.01---1 B

@stephentoub
Copy link
Member

@adamsitnik, can you review? Thanks.

@stephentoubstephentoubforce-pushed thepipestream-ivaluetasksource branch froma218fed to64664c2CompareAugust 3, 2021 14:50
@stephentoubstephentoubforce-pushed thepipestream-ivaluetasksource branch from64664c2 toe648ecfCompareAugust 10, 2021 21:33
@stephentoub
Copy link
Member

There's a real test failure happening here, and I'm trying to figure out why. So far it's only occurred on x86 on Windows 7.

@stephentoubstephentoubforce-pushed thepipestream-ivaluetasksource branch frome648ecf tob0caf4cCompareAugust 11, 2021 02:13
@stephentoubstephentoubforce-pushed thepipestream-ivaluetasksource branch fromb0caf4c tof6adcb7CompareAugust 11, 2021 19:19
@stephentoubstephentoub merged commite4b4666 intodotnet:mainAug 12, 2021
@ghostghost locked asresolvedand limited conversation to collaboratorsSep 11, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@jozkeejozkeeAwaiting requested review from jozkee

@adamsitnikadamsitnikAwaiting requested review from adamsitnik

@stephentoubstephentoubAwaiting requested review from stephentoub

1 more reviewer

@carlossanlopcarlossanlopcarlossanlop left review comments

Reviewers whose approvals may not affect merge requirements

Labels

area-System.IOcommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

Use IValueTaskSource in PipeStream on Windows

6 participants

@manandre@jeffhandley@stephentoub@carlossanlop@adamsitnik@terrajobst
[8]ページ先頭
©2009-2025 Movatter.jp