Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

JIT: Optimize *x = dblCns to *x = intCns#52298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
EgorBo merged 10 commits intodotnet:mainfromEgorBo:jit-opt-store-zero-flt
May 18, 2021

Conversation

@EgorBo
Copy link
Member

@EgorBoEgorBo commentedMay 5, 2021•
edited
Loading

Just a small optimization for#52286 (comment) comment.

voidTest(reffloatx)=>x=0;

Current codegen:

; Method Program:Test(byref)G_M20809_IG01:vzeroupper;; bbWeight=1    PerfScore 1.00G_M20809_IG02:       vxorpsxmm0,xmm0vmovss   dword ptr[rcx],xmm0;; bbWeight=1    PerfScore 0.83G_M20809_IG03:ret;; bbWeight=1    PerfScore 1.00; Total bytes of code: 12

New codegen:

; Method Program:Test(byref)G_M20809_IG02:mov      dword ptr[rcx],0;; bbWeight=1    PerfScore 1.00G_M20809_IG03:ret;; bbWeight=1    PerfScore 1.00; Total bytes of code: 7

SuperPMI results:

asm.aspnet.run.windows.x64.checked.2               -86 (-0.21% of base)asm.benchmarks.run.windows.x64.checked            -684 (-1.02% of base)asm.libraries.crossgen.windows.x64.checked.3      -641 (-0.78% of base)asm.libraries.crossgen2.windows.x64.checked.2     -600 (-0.77% of base)asm.libraries.pmi.windows.x64.checked             -967 (-0.99% of base)asm.tests_libraries.pmi.windows.x64.checked     -25294 (-0.72% of base)asm.tests.pmi.windows.x64.checked.1             -71306 (-0.35% of base)

/cc @dotnet/jit-contrib@SingleAccretion

SingleAccretion reacted with thumbs up emoji
@ghostghost added the area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labelMay 5, 2021
@tannergooding
Copy link
Member

Changes LGTM.

@EgorBoEgorBo changed the titleJIT: Optimize *x = 0.0 to *x = 0JIT: Optimize *x = dblCns to *x = intCnsMay 10, 2021
@EgorBo
Copy link
MemberAuthor

@dotnet/jit-contrib@tannergooding anyone wants to approve? 🙂

@EgorBoEgorBo merged commit79f9415 intodotnet:mainMay 18, 2021
@karelzkarelz added this to the6.0.0 milestoneMay 20, 2021
@ghostghost locked asresolvedand limited conversation to collaboratorsJun 19, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@jakobbotschjakobbotschjakobbotsch approved these changes

@tannergoodingtannergoodingtannergooding approved these changes

+3 more reviewers

@echesakovechesakovechesakov left review comments

@sandreenkosandreenkosandreenko left review comments

@SingleAccretionSingleAccretionSingleAccretion left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

@EgorBo@tannergooding@echesakov@jakobbotsch@sandreenko@SingleAccretion@karelz
[8]ページ先頭
©2009-2025 Movatter.jp