Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add CopyToAsync optimized implementations for StreamPipeReader#52159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
davidfowl merged 11 commits intodotnet:mainfrommanandre:streampipereader-copytoasync
May 5, 2021

Conversation

@manandre
Copy link
Contributor

@ghost
Copy link

Note regarding thenew-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@manandremanandreforce-pushed thestreampipereader-copytoasync branch from1cdfd66 toa9e712fCompareMay 1, 2021 16:34
@davidfowl
Copy link
Member

Thanks for the contribution@manandre. I'd prefer it if we didn't expose any code with the base implementation and instead optimized for calling as little functions inside of the CopyToAsync implementations inside of theStreamPipeReader itself.

I expected the calls to CopyToAsync to basically enumerate from readHead to readTail and copy that to the underlying destination (PipeWriter or Stream), and then in the Stream case, delegate completely to the Stream implementation. For the PipeWriter case, what you're doing is fine.

@manandremanandreforce-pushed thestreampipereader-copytoasync branch fromfac46a9 to347b061CompareMay 2, 2021 13:16
@davidfowl
Copy link
Member

This change is looking great! We need to figure out the tests.

@davidfowl
Copy link
Member

I'm very happy with this change@manandre!

manandre reacted with thumbs up emoji

@davidfowldavidfowl merged commit4bbaa68 intodotnet:mainMay 5, 2021
@davidfowl
Copy link
Member

Thanks@manandre ! I will be looking for more Pipelines work to give you 😉

@davidfowldavidfowl added this to the6.0.0 milestoneMay 5, 2021
@manandremanandre deleted the streampipereader-copytoasync branchMay 5, 2021 09:25
@ghostghost locked asresolvedand limited conversation to collaboratorsJun 4, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@davidfowldavidfowldavidfowl approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

Implement optimized CopyToAsync for StreamPipeReader

2 participants

@manandre@davidfowl

[8]ページ先頭

©2009-2025 Movatter.jp