Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Do not confuse fgDispBasicBlocks in fgMorphBlocks#50703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@SingleAccretion
Copy link
Contributor

The logic in "fgDispBasicBlocks" has a check for promoted implicit by-refs
that only allows them during global morph via an 'assert(fgGlobalMorph)'.
However, "fgMorphBlocks" was calling "fgDispBasicBlocks" after having set "fgGlobalMorph" to "false",
leading it to falsely believe it was not actually being called during global morph
and asserting with a message like "assertion failed 'fgGlobalMorph' - during 'Morph - Global'".
Fix this by setting "fgGlobalMorph" to "false" at the very end of "fgMorphBlocks".

EgorBo reacted with thumbs up emoji
@ghostghost added the area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labelApr 4, 2021
The logic in "fgDispBasicBlocks" has a check for promoted implicit by-refsthat only allows them during global morph via an 'assert(fgGlobalMorph)'.However, "fgMorphBlocks" was calling "fgDispBasicBlocks" after having set "fgGlobalMorph" to "false",leading it to falsely believe it was not actually being called during global morphand asserting with a message like "assertion failed 'fgGlobalMorph' - during 'Morph - Global'".Fix this by setting "fgGlobalMorph" to "false" at the very end of "fgMorphBlocks".
@SingleAccretionSingleAccretionforce-pushed theFix-Dumping-Of-Verbose-Trees branch frome07ee9f to32c86dcCompareApril 4, 2021 22:54
@AndyAyersMS
Copy link
Member

Asserts in dumping code are a bad idea, so can you fix that too?

@SingleAccretion
Copy link
ContributorAuthor

SingleAccretion commentedApr 5, 2021
edited
Loading

I unfortunately could not find a new home for these asserts... We have a few IR walks in thefgDebugCheck functions, but adding one more and slowing down the Checked/Debug build just for this I did not find appealing.

Copy link
Member

@AndyAyersMSAndyAyersMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks.

I would not worry about losing those two asserts.

SingleAccretion reacted with thumbs up emoji
@AndyAyersMS
Copy link
Member

Thanks again,@SingleAccretion !

SingleAccretion reacted with hooray emoji

thaystg added a commit to thaystg/runtime that referenced this pull requestApr 6, 2021
…shim_mono# By Aaron Robinson (10) and others# Via GitHub* upstream/main: (108 commits)  [mbr] Add Apple sample (dotnet#50740)  make EstablishProxyTunnelAsync throw on failure status code from proxy (dotnet#50763)  Improve RGB Min Max evaluation performance by using 2 or 3 comparison… (dotnet#50622)  [mono] More domain cleanups (dotnet#50479)  Fix Crossgen2 of PlatformDefaultMemberFunction methods and calls. (dotnet#50754)  Disable EventSource generator in design-time builds (dotnet#50741)  Fix X509 test failures on Android (dotnet#50301)  Do not confuse fgDispBasicBlocks in fgMorphBlocks (dotnet#50703)  Enforce 64KB event payload size limit on EventPipe  (dotnet#50600)  Reorganize CoreCLR native build to reduce CMake reconfigures when the build system is untouched (dotnet#49906)  [mbr] Turn on hot reload for iOS, tvOS and MacCatalyst (dotnet#50458)  improve connection scavenge logic by doing zero-byte read (dotnet#50545)  Resolve call mdtokens when making tier 1 inline observations (dotnet#50675)  Annotate APIs in System.Private.Xml (dotnet#49682)  Support compiling against OpenSSL 3 headers  Change Configuration.Json to use a regular Dictionary. (dotnet#50611)  Remove unused BigNumFromBinary P/Invoke (dotnet#50670)  Make Ninja the default CMake generator on Windows for the repo (dotnet#49715)  [AppleAppBuilder] Entitlements to run tests on catalyst using the JIT (dotnet#50637)  [mono] Fix delegate invokes to dynamic methods in mixed mode. (dotnet#50547)  ...# Conflicts:#src/mono/dlls/mscordbi/CMakeLists.txt
@SingleAccretionSingleAccretion deleted the Fix-Dumping-Of-Verbose-Trees branchApril 13, 2021 00:28
@JulieLeeMSFTJulieLeeMSFT added this to the6.0.0 milestoneApr 15, 2021
@ghostghost locked asresolvedand limited conversation to collaboratorsMay 15, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@EgorBoEgorBoEgorBo approved these changes

@AndyAyersMSAndyAyersMSAndyAyersMS approved these changes

Assignees

@SingleAccretionSingleAccretion

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@SingleAccretion@AndyAyersMS@EgorBo@JulieLeeMSFT

[8]ページ先頭

©2009-2025 Movatter.jp