- Notifications
You must be signed in to change notification settings - Fork5.2k
[mono] More domain cleanups#50479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ghost commentedMar 31, 2021
Tagging subscribers to this area:@CoffeeFlux Issue Details
|
ceab8bb to1905405Comparemarek-safar commentedApr 5, 2021
@vargaz could you resolve the confict @CoffeeFlux@lambdageek plase review |
…d-context.c.Add a mono_alc_get_all_loaded_assemblies () helper function to return aarray of all the loaded assemblies. Use this instead of accessingdomain->loaded_assemblies directly.
Move functions from appdomain.c to more assembly-load-context.c/extern-only.c.
CoffeeFlux left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, thanks!
There might end up being conflicts with#49637 but they should be easy to resolve on either end.
| mono_appdomains_lock (); | ||
| domain_id_alloc (domain); | ||
| mono_appdomains_unlock (); | ||
| // FIXME: why is this needed ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Did removing this cause problems? I don't see it referenced anywhere else now, and the GC shouldn't(?) be using it to find roots, so I think this can just go away.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Will try to remove later.
Uh oh!
There was an error while loading.Please reload this page.
| } | ||
| mono_assembly_addref (ass); | ||
| // Prepending here will break the test suite with frequent InvalidCastExceptions, so we have to append |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The fact prepending here doesn't work still annoys me. I wish I'd left more info about why, since it's not obvious months later what the actual problem was.
…shim_mono# By Aaron Robinson (10) and others# Via GitHub* upstream/main: (108 commits) [mbr] Add Apple sample (dotnet#50740) make EstablishProxyTunnelAsync throw on failure status code from proxy (dotnet#50763) Improve RGB Min Max evaluation performance by using 2 or 3 comparison… (dotnet#50622) [mono] More domain cleanups (dotnet#50479) Fix Crossgen2 of PlatformDefaultMemberFunction methods and calls. (dotnet#50754) Disable EventSource generator in design-time builds (dotnet#50741) Fix X509 test failures on Android (dotnet#50301) Do not confuse fgDispBasicBlocks in fgMorphBlocks (dotnet#50703) Enforce 64KB event payload size limit on EventPipe (dotnet#50600) Reorganize CoreCLR native build to reduce CMake reconfigures when the build system is untouched (dotnet#49906) [mbr] Turn on hot reload for iOS, tvOS and MacCatalyst (dotnet#50458) improve connection scavenge logic by doing zero-byte read (dotnet#50545) Resolve call mdtokens when making tier 1 inline observations (dotnet#50675) Annotate APIs in System.Private.Xml (dotnet#49682) Support compiling against OpenSSL 3 headers Change Configuration.Json to use a regular Dictionary. (dotnet#50611) Remove unused BigNumFromBinary P/Invoke (dotnet#50670) Make Ninja the default CMake generator on Windows for the repo (dotnet#49715) [AppleAppBuilder] Entitlements to run tests on catalyst using the JIT (dotnet#50637) [mono] Fix delegate invokes to dynamic methods in mixed mode. (dotnet#50547) ...# Conflicts:#src/mono/dlls/mscordbi/CMakeLists.txt
No description provided.