- Notifications
You must be signed in to change notification settings - Fork5.2k
Avoid forcing parsing of DefaultRequestHeaders and from message.ToString()#49673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
+79 −45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ghost commentedMar 16, 2021
Tagging subscribers to this area: @dotnet/ncl Issue DetailsFixes#49463
|
src/libraries/System.Net.Http/tests/FunctionalTests/SocketsHttpHandlerTest.cs OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/libraries/System.Net.Http/src/System/Net/Http/Headers/HttpHeaders.cs OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
geoffkizer approved these changesMar 16, 2021
In the past, this was done because every request would parse all headers as part of sending them, so it was better to parse once then on every request. But we changed the behavior for sending in SocketsHttpHandler to actually respect TryAddWithoutValidation, such that we wouldn't forcefully validate unless the developer asked us to. This makes DefaultRequestHeaders consistent with that.
This not only can change behavior in the debugger just by hovering over a message, it can change behavior at runtime due to the request/response messages getting logged.
This was referencedMar 16, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#49463
cc:@geoffkizer