Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add new Task-based socket methods for UDP and reimplement existing ones using SocketAsyncEventArgs#47229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
antonfirsov merged 48 commits intodotnet:masterfromantonfirsov:socket/udp-tasks
Jan 27, 2021

Conversation

@antonfirsov
Copy link
Contributor

Closes#41502, but does not change the existing APM methods, I plan to do it in a follow-up PR.

The PR is built on@geoffkizer's branch, almost all product code changes were written by him, I just added a bunch of tests, fixed an issue with Windows cancellation (4e4add1), and moved extension methods to theSocket class as per#43901.

As such, the product code needs a third pair of yes to review.@stephentoub maybe?

Geoffrey Kizerand others added29 commitsAugust 30, 2020 21:55
# Conflicts:#src/libraries/System.Net.Sockets/ref/System.Net.Sockets.cs#src/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketTaskExtensions.cs
@antonfirsovantonfirsov changed the titleAdd new Task-based socket methods for UDP, and reimplement existing ones using SocketAsyncEventArgsAdd new Task-based socket methods for UDP and reimplement existing ones using SocketAsyncEventArgsJan 25, 2021
@antonfirsov
Copy link
ContributorAuthor

@geoffkizer can you please take another look at the tests, and give a final approval if things look OK?

I had todelete my SendTo cancellation test, since it looks like there is no reliable way to enforcesendto to returnEWOULDBLOCK. Flooding the kernel works on some Linuxes, but not on others, and does not work on Mac.

I opened a bunch of issues for the corner cases discovered, and referenced them in my test workarounds. Most of them are minor compatibility cases, except the first one, which is actually concerning:#47342,#47335,#47469,#47425

@antonfirsov

This comment has been minimized.

@azure-pipelines

This comment has been minimized.

Copy link
Contributor

@geoffkizergeoffkizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

One small nit above, otherwise LGTM.

@antonfirsov
Copy link
ContributorAuthor

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@antonfirsov
Copy link
ContributorAuthor

OuterLoop test failures are unrelated:#46619,#43207,#40798,#47528

@antonfirsovantonfirsov merged commite9695b8 intodotnet:masterJan 27, 2021
@ghostghost locked asresolvedand limited conversation to collaboratorsFeb 26, 2021
@karelzkarelz added this to the6.0.0 milestoneMay 20, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@stephentoubstephentoubstephentoub approved these changes

+1 more reviewer

@geoffkizergeoffkizergeoffkizer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

Sockets: Reimplement remaining Task-based async methods using SocketAsyncEventArgs

4 participants

@antonfirsov@geoffkizer@stephentoub@karelz
[8]ページ先頭
©2009-2025 Movatter.jp