Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

More arities for tuple returning zip extension method#47147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
eiriktsarpalis merged 10 commits intodotnet:masterfromhuoyaoyuan:zip-tuple
Jan 19, 2021

Conversation

@huoyaoyuan
Copy link
Member

Closes#43702

It grows exponentially for test exhaustiveness. I'm just focusing on the third parameter.

@ghost
Copy link

Note regarding thenew-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

Tagging subscribers to this area:@eiriktsarpalis
See info in area-owners.md if you want to be subscribed.

Issue Details

Closes#43702

It grows exponentially for test exhaustiveness. I'm just focusing on the third parameter.

Author:huoyaoyuan
Assignees:-
Labels:

area-System.Linq,new-api-needs-documentation

Milestone:-

Copy link
Member

@eiriktsarpaliseiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks great, thank you for the contribution!

publicstaticMethodInfoZip_TFirst_TSecond_TThird_3(TypeTFirst,TypeTSecond,TypeTThird)=>
(s_Zip_TFirst_TSecond_TThird_3??
(s_Zip_TFirst_TSecond_TThird_3=newFunc<IQueryable<object>,IEnumerable<object>,IEnumerable<object>,IQueryable<(object,object,object)>>(Queryable.Zip).GetMethodInfo().GetGenericMethodDefinition()))
.MakeGenericMethod(TFirst,TSecond,TThird);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I was going to comment saying??= could be used to simplify this, but I see you're just following the pattern used in a bunch of other cases above. We can clean it up later.

eiriktsarpalis reacted with thumbs up emoji
Copy link
MemberAuthor

@huoyaoyuanhuoyaoyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

PR feedbacks

Co-authored-by: Stephen Toub <stoub@microsoft.com>Co-authored-by: Eirik Tsarpalis <eirik.tsarpalis@gmail.com>
@eiriktsarpalis
Copy link
Member

Thanks for the contribution!

Logerfo reacted with hooray emoji

@eiriktsarpaliseiriktsarpalis merged commit6fb9985 intodotnet:masterJan 19, 2021
@Logerfo
Copy link

Thank you! In which runtime version is this feature supposed to be available?

@eiriktsarpalis
Copy link
Member

That would be released with .NET 6 next November.

Logerfo reacted with thumbs up emoji

@huoyaoyuanhuoyaoyuan deleted the zip-tuple branchJanuary 19, 2021 16:07
@ghostghost locked asresolvedand limited conversation to collaboratorsFeb 18, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@stephentoubstephentoubstephentoub approved these changes

@eiriktsarpaliseiriktsarpaliseiriktsarpalis approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

More arities for tuple returning zip extension method

4 participants

@huoyaoyuan@eiriktsarpalis@Logerfo@stephentoub
[8]ページ先頭
©2009-2025 Movatter.jp