NotificationsYou must be signed in to change notification settings
Fork5.2k
Star17.2k

Use TryParseUInt32HexNumberStyle directly from Guid.TryParse#44918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

stephentoub merged 1 commit intodotnet:masterfromstephentoub:guidparse

Nov 20, 2020

Merged

Use TryParseUInt32HexNumberStyle directly from Guid.TryParse#44918

stephentoub merged 1 commit intodotnet:masterfromstephentoub:guidparse

Nov 20, 2020

Conversation

Copy link

Member

stephentoub commentedNov 19, 2020•
edited
Loading

Skips public entry points of uint.TryParse, including argument validation, branches for style, but most impactfully fetching the current number culture when it won't actually be needed.

Noticed while looking at startup costs, as it was causing current culture to be initialized unexpectedly.

usingBenchmarkDotNet.Attributes;usingBenchmarkDotNet.Diagnosers;usingBenchmarkDotNet.Running;usingSystem;[MemoryDiagnoser]publicclassProgram{staticvoidMain(string[]args)=>BenchmarkSwitcher.FromAssemblies(new[]{typeof(Program).Assembly}).Run(args);[Benchmark]publicboolTryParse()=>Guid.TryParse("dd16f057-4f29-495c-9f09-7201d8bee53d",out_);[Benchmark]publicboolTryParseD()=>Guid.TryParseExact("dd16f057-4f29-495c-9f09-7201d8bee53d","D",out_);[Benchmark]publicboolTryParseN()=>Guid.TryParseExact("6e76bbd10361464b980309a281d17180","N",out_);}

Method	Toolchain	Mean	Ratio
TryParse	\master\corerun.exe	86.38 ns	1.00
TryParse	\pr\corerun.exe	74.42 ns	0.87

TryParseD	\master\corerun.exe	82.14 ns	1.00
TryParseD	\pr\corerun.exe	71.21 ns	0.89

TryParseN	\master\corerun.exe	96.77 ns	1.00
TryParseN	\pr\corerun.exe	60.36 ns	0.62

Contributes to#44598

Use TryParseUInt32HexNumberStyle directly from Guid.TryParse

aa16bb1

Skips public entry points of uint.TryParse, including argument validation, branches for style, but most impactfully fetching the current number culture when it won't actually be needed.