Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix/remove TODO-NULLABLEs#44300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
krwq merged 4 commits intodotnet:masterfromkrwq:todo-nullables-2020-11-05
Nov 9, 2020
Merged

Conversation

@krwq
Copy link
Member

@krwqkrwq commentedNov 5, 2020
edited
Loading

This takes care of all remaining TODO-NULLABLE except 3 which all say:

Enable after System.ComponentModel.TypeDescriptionProvider is annotated

and are unactionable until that happens.

I've filed:

Product fix:

  • XDocumentType.InternalSubset property and corresponding constructor argument accept nullable, property will return non-null though (string.Empty when null is provided), the
    • internal subset accepts nullable across XML with this place being an exception
    • internal subset is optional in the XML spec
    • XmlReader.Value (which XNodeReader.Value) returns string.Empty when internal subset is not provided but document type exists
    • currently constructor and setter accept null and do not produce errors further down (they serialize just fine)
    • when you load the xml without internal subset it returns string.Empty
    • XmlDocumentType also returns string.Empty

EDIT (@krwq): I have edited the description post merge to account for the changes made after PR comments

@stephentoubstephentoub added the breaking-changeIssue or PR that represents a breaking API or functional change over a previous release. labelNov 5, 2020
@ghostghost added the needs-breaking-change-doc-createdBreaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet labelNov 5, 2020
@krwq
Copy link
MemberAuthor

krwq commentedNov 6, 2020

@jozkee PTAL at the changes:

  • I made InternalSubset non-null with[AllowNull] - constructor is still taking null to not break whatever used to work
  • scenario you wrote in the comment with InDocumentOrder will now work

Copy link
Member

@rojiroji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks@krwq, LGTM although I'm slightly worried about that native method in OleDbDataReader.GetDataForReader.

@krwqkrwq merged commitc871e23 intodotnet:masterNov 9, 2020
tqiu8 pushed a commit to tqiu8/runtime that referenced this pull requestNov 9, 2020
author Stephen Toub <stoub@microsoft.com> 1604601164 -0500committer Tammy Qiu <tammy.qiu@yahoo.com> 1604960878 -0500Add stream conformance tests for TranscodingStream (dotnet#44248)* Add stream conformance tests for TranscodingStream* Special-case 0-length input buffers to TranscodingStream.Write{Async}The base implementation of Encoder.Convert doesn't like empty inputs.  Regardless, if the input is empty, we can avoid a whole bunch of unnecessary work.JIT: minor inliner refactoring (dotnet#44215)Extract out the budget check logic so it can vary by inlining policy.Use this to exempt the FullPolicy from budget checking.Fix inline xml to dump the proper (full name) hash for inlinees.Update range dumper to dump ranges in hex.Remove unused QCall for WinRTSupported (dotnet#44278)ConcurrentQueueSegment allows spinning threads to sleep. (dotnet#44265)* Allow threads to sleep when ConcurrentQueue has many enqueuers/dequeuers.* Update src/libraries/System.Private.CoreLib/src/System/Collections/Concurrent/ConcurrentQueueSegment.csCo-authored-by: Stephen Toub <stoub@microsoft.com>* Apply suggestions from code reviewCo-authored-by: Stephen Toub <stoub@microsoft.com>Co-authored-by: AMD DAYTONA EPYC <amd@amd-DAYTONA-X0.com>Co-authored-by: Stephen Toub <stoub@microsoft.com>File.Exists() is not null when true (dotnet#44310)* File.Exists() is not null when true* Fix compile* Fix compile 2[master][watchOS] Add simwatch64 support (dotnet#44303)Xcode 12.2 removed 32 bits support for watchOS simulators, this PR helps tofixdotnet/macios#9949, we have tested the new binaries and they are working as expected![unknown](https://user-images.githubusercontent.com/204671/98253709-64413200-1f49-11eb-9774-8c5aa416fc57.png)Co-authored-by: dalexsoto <dalexsoto@users.noreply.github.com>Implementing support to Debugger::Break. (dotnet#44305)Set fgOptimizedFinally flag correctly (dotnet#44268)- Initialize to 0 at compiler startup- Set flag when finally cloning optimization kicks inFixes non-deterministic generation of nop opcodes into ARM32 codeForbid `- byref cnst` -> `+ (byref -cnst)` transformation. (dotnet#44266)* Add a repro test.* Forbid the transformation for byrefs.* Update src/coreclr/src/jit/morph.cppCo-authored-by: Andy Ayers <andya@microsoft.com>* Update src/coreclr/src/jit/morph.cpp* Fix the test return value.WriteLine is just to make sure we don't delete the value.* improve the test.avoid a possible overflow and don't waste time on printing.Co-authored-by: Andy Ayers <andya@microsoft.com>Pick libmonosgen-2.0.so from cmake install directory instead of .libs (dotnet#44291)This aligns Linux with what we already do for all the other platforms.Update SharedPerformanceCounter assert (dotnet#44333)Remove silly ToString in GetCLRInstanceString (dotnet#44335)Use targetPlatformMoniker for net5.0 and newer tfms (dotnet#43965)* Use targetPlatformMoniker for net5.0 and newer tfms* disabling analyzer, update version to 0.0, and use new format.* update the targetFramework.sdk* removing supportedOS assembly level attribute* fix linker errors and addressing feedback* making _TargetFrameworkWithoutPlatform as private[sgen] Add Ward annotations to sgen_get_total_allocated_bytes (dotnet#43833)Attempt to fixhttps://jenkins.mono-project.com/job/test-mono-mainline-staticanalysis/Co-authored-by: lambdageek <lambdageek@users.noreply.github.com>[tests] Re-enable tests fixed bydotnet#44081 (dotnet#44212)Fixesmono/mono#15030 andfixesmono/mono#15031 andfixesmono/mono#15032Add an implicit argument coercion check. (dotnet#43386)* Add `impCheckImplicitArgumentCoercion`.* Fix tests with type mismatch.* Try to fix VM signature.* Allow to pass byref as native int.* another fix.* Fix another IL test.[mono] Change CMakelists.txt "python" -> Python3_EXECUTABLE (dotnet#44340)Debian doesn't install a "python" binary for python3.Tweak StreamConformanceTests for cancellation (dotnet#44342)- Avoid unnecessary timers- Separate tests for precancellation, ReadAsync(byte[], ...) cancellation, and ReadAsync(Memory, ...) cancellationUse Dictionary for underlying cache of ResourceSet (dotnet#44104)Simplify catch-rethrow logic in NetworkStream (dotnet#44246)A follow-up ondotnet#40772 (comment), simplifies and harmonizes the way we wrap exceptions into IOException. Having one catch block working with System.Exception seems to be enough here, no need for specific handling of SocketException.Simple GT_NEG optimization fordotnet#13837 (dotnet#43921)* Simple arithmetic optimization with GT_NEG* Skip GT_NEG optimization when an operand is constant. Revert bitwise rotation pattern* Fixed Value Numbering assert* Cleaned up code and comments for simple GT_NEG optimization* FormattingCo-authored-by: Julie Lee <jeonlee@microsoft.com>[master] Update dependencies from mono/linker (dotnet#44322)* Update dependencies fromhttps://github.com/mono/linker build 20201105.1Microsoft.NET.ILLink.Tasks From Version 6.0.0-alpha.1.20527.2 -> To Version 6.0.0-alpha.1.20555.1* Update dependencies fromhttps://github.com/mono/linker build 20201105.2Microsoft.NET.ILLink.Tasks From Version 6.0.0-alpha.1.20527.2 -> To Version 6.0.0-alpha.1.20555.2* Disable new optimization for libraries mode (it cannot work in this mode)Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>Co-authored-by: Marek Safar <marek.safar@gmail.com>Tighten argument validation in StreamConformanceTests (dotnet#44326)Add threshold on number of files / partition in SPMI collection (dotnet#44180)* Add check for files count* Fix the OS check* decrese file limit to 1500:* misc fix* Do not upload to azure if mch files are zero sizeFix ELT profiler tests (dotnet#44285)[master] Update dependencies from dotnet/arcade dotnet/llvm-project dotnet/icu (dotnet#44336)[master] Update dependencies from dotnet/arcade dotnet/llvm-project dotnet/icu - Merge branch 'master' into darc-master-2211df94-2a02-4c3c-abe1-e3534e896267Fix Send_TimeoutResponseContent_Throws (dotnet#44356)If the client times out too quickly, the server may never have a connection to accept and will hang forever.Match CoreCLR behaviour on thread start failure (dotnet#44124)Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>Add slash in Windows SoD tool build (dotnet#44359)* Add slash in Windows SoD tool build* Update SoD search path to match output dir* Fixup dotnet version* Remove merge commit headers* Disable PRsCo-authored-by: Drew Scoggins <andrew.g.scoggins@gmail>Reflect test path changes in .gitattributes; remove nonexistent files (dotnet#44371)Bootstrapping a test for R2RDump (dotnet#42150)Improve performance of Enum's generic IsDefined / GetName / GetNames (dotnet#44355)Eliminates the boxing in IsDefined/GetName/GetValues, and in GetNames avoids having to go through RuntimeType's GetEnumNames override.clarify http version test (dotnet#44379)Co-authored-by: Geoffrey Kizer <geoffrek@windows.microsoft.com>Update dependencies fromhttps://github.com/mono/linker build 20201106.1 (dotnet#44367)Microsoft.NET.ILLink.Tasks From Version 6.0.0-alpha.1.20555.2 -> To Version 6.0.0-alpha.1.20556.1Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>Disable RunThreadLocalTest8_Values on Mono (dotnet#44357)* Disable RunThreadLocalTest8_Values on MonoIt's failing on SLES* fix typoLongProcessNamesAreSupported: make test work on distros where sleep is a symlink/script (dotnet#44299)* LongProcessNamesAreSupported: make test work on distros where sleep is a symlink/script* PR feedbackCo-authored-by: Stephen Toub <stoub@microsoft.com>* fix compilationCo-authored-by: Stephen Toub <stoub@microsoft.com>add missing constructor overloads (dotnet#44380)Co-authored-by: Geoffrey Kizer <geoffrek@windows.microsoft.com>change using in ConnectCallback_UseUnixDomainSocket_Success (dotnet#44366)Clean up the samples (dotnet#44293)Update dotnet/roslyn issue linkDelete stale comment aboutdotnet/roslyn#30797Fix/remove TODO-NULLABLEs (dotnet#44300)* Fix/remove TODO-NULLABLEs* remove redundant !* apply Jozkee's feedback* address feedbackUpdate glossary (dotnet#44274)Co-authored-by: Juan Hoyos <juan.hoyos@microsoft.com>Co-authored-by: Stephen Toub <stoub@microsoft.com>Co-authored-by: Günther Foidl <gue@korporal.at>Add files need for wasm executable relinking/aot to the wasm runtime pack. (dotnet#43785)Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>Move some more UnmanagedCallersOnly tests to IL now that they're invalid C# (dotnet#43366)Fix C++ build for mono/metadata/threads.c (dotnet#44413)`throw` is a reserved keyword in C++.Disable a failing test. (dotnet#44404)Change async void System.Text.Json test to be async Task (dotnet#44418)Improve crossgen2 comparison jobs (dotnet#44119)- Fix compilation on unix platforms  - Wrap use of wildcard in quotes- Print better display name into log- Fix X86 constant comparison handling- Add ability to compile specific overload via single method switchesRemove some unnecessary GetTypeInfo usage (dotnet#44414)Fix MarshalTypedArrayByte and re-enable it. Re-enable TestFunctionApply
@ghostghost locked asresolvedand limited conversation to collaboratorsDec 18, 2020
@ericstjericstj added this to the6.0.0 milestoneSep 29, 2021
@krwq
Copy link
MemberAuthor

@ericstj are you doing some kind of tracking work or has there been a regression?

@ericstj
Copy link
Member

Driving breaking change documents down. Check your email 😉

@jeffhandley
Copy link
Member

We have documented all changes to nullable annotations through the release. There was a master issue that aggregated the majority of them, and then we had one-off doc issues thereafter.

dotnet/docs#21202

@jeffhandleyjeffhandley removed the needs-breaking-change-doc-createdBreaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet labelOct 16, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@rojirojiroji approved these changes

@jozkeejozkeejozkee left review comments

@stephentoubstephentoubstephentoub approved these changes

Assignees

@krwqkrwq

Labels

area-Metabreaking-changeIssue or PR that represents a breaking API or functional change over a previous release.

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

@krwq@ericstj@jeffhandley@roji@stephentoub@jozkee@Dotnet-GitSync-Bot

[8]ページ先頭

©2009-2025 Movatter.jp