Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add overloads for Enum.Parse/TryParse with ReadOnlySpan<char>#43255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
stephentoub merged 4 commits intodotnet:masterfromhrrrrustic:issue-1916
Feb 26, 2021

Conversation

@hrrrrustic
Copy link
Contributor

close#1916

@Dotnet-GitSync-Bot
Copy link
Collaborator

Note regarding thenew-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@hrrrrustic
Copy link
ContributorAuthor

@jkotas any comments/review?

@danmoseley
Copy link
Member

Tagged@joperezr as area owner.

Copy link
Member

@stephentoubstephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I was going to suggest this PR should include also fixing up calls to the existing overloads that should instead use the new overloads (e.g. places where we may have been trimming the input string prior to the call), but on a quick search, I didn't find any.

So, LGTM. Thanks!

@danmoseley
Copy link
Member

@hrrrrustic we're trying to make a push to finish old PR's like this one. Are you still in a position to address feedback?

@hrrrrustic
Copy link
ContributorAuthor

Writing xml docs right now :)

@stephentoub
Copy link
Member

@hrrrrustic, thanks. I can review again, but there are conflicts. Would you mind rebasing on top of master?

@hrrrrustic
Copy link
ContributorAuthor

@stephentoub Done

@stephentoub
Copy link
Member

The PR is changing the permissions on src/installer/snaps/dotnet-sdk/dotnet-runtime. Please revert that.

@hrrrrustic
Copy link
ContributorAuthor

@stephentoub No idea how did I do that, but I force pushed revert. There are some failing ci, but error log is quite strange

Copy link
Member

@stephentoubstephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. Thanks!

Co-authored-by: Stephen Toub <stoub@microsoft.com>
@stephentoubstephentoub merged commitadc2416 intodotnet:masterFeb 26, 2021
@ghostghost locked asresolvedand limited conversation to collaboratorsMar 29, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@danmoseleydanmoseleydanmoseley left review comments

@joperezrjoperezrjoperezr left review comments

@stephentoubstephentoubstephentoub approved these changes

+1 more reviewer

@terrajobstterrajobstterrajobst left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@joperezrjoperezr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Introduce overloads of Enum.Parse/TryParse that accept ReadOnlySpan<char>

7 participants

@hrrrrustic@Dotnet-GitSync-Bot@danmoseley@stephentoub@terrajobst@joperezr@jkotas
[8]ページ先頭
©2009-2025 Movatter.jp