Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Move Marshal memory allocation methods into CoreLib shared partition#41911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jkotas merged 2 commits intodotnet:masterfromjkotas:malloc
Sep 8, 2020

Conversation

@jkotas
Copy link
Member

@jkotasjkotas commentedSep 5, 2020•
edited
Loading

In addition to benefits from better sharing between runtimes, this change avoids unnecessary layers of wrappers on Unix and makes these methods significantly faster on average for small sizes. For example:

for (int i = 0; i < 100000000; i++) Marshal.FreeHGlobal(Marshal.AllocHGlobal(100));

Before this change: 5430ms
After this change: 2030ms

am11, EgorBo, AaronRobinsonMSFT, strangeman375, and AlgorithmsAreCool reacted with thumbs up emojijkoritzinsky and strangeman375 reacted with rocket emoji
@jkotas
Copy link
MemberAuthor

Depends on#41910

@vargaz
Copy link
Contributor

The mono changes look ok to me.

EgorBo reacted with thumbs up emoji

@CoffeeFlux
Copy link
Contributor

The mono/mono mirror PR appears to be passing all required lanes:mono/mono#20353

I don't have context for this PR and so I don't know why it's labeled no-merge, but whenever it's ready the Mono side looks good and I can merge it.

@jkotasjkotas removed the NO-MERGEThe PR is not ready for merge yet (see discussion for detailed reasons) labelSep 7, 2020
@jkotas
Copy link
MemberAuthor

I don't know why it's labeled no-merge

I was improving tests in other PR that was just merged. Once the CI is green, this can be merged too.

CoffeeFlux reacted with thumbs up emoji

@jkotasjkotas merged commitd81b066 intodotnet:masterSep 8, 2020
@jkotasjkotas deleted the malloc branchSeptember 8, 2020 04:51
@runfoapprunfoappbot mentioned this pull requestSep 29, 2020
@ghostghost locked asresolvedand limited conversation to collaboratorsDec 7, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@danmoseleydanmoseleydanmoseley left review comments

@AaronRobinsonMSFTAaronRobinsonMSFTAaronRobinsonMSFT approved these changes

@akoeplingerakoeplingerAwaiting requested review from akoeplinger

@EgorBoEgorBoAwaiting requested review from EgorBo

@lambdageeklambdageekAwaiting requested review from lambdageek

@marek-safarmarek-safarAwaiting requested review from marek-safar

@steveisoksteveisokAwaiting requested review from steveisok

@thaystgthaystgAwaiting requested review from thaystg

@vargazvargazAwaiting requested review from vargaz

+2 more reviewers

@CoffeeFluxCoffeeFluxCoffeeFlux left review comments

@am11am11am11 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jkotas@vargaz@CoffeeFlux@am11@danmoseley@AaronRobinsonMSFT@Dotnet-GitSync-Bot
[8]ページ先頭
©2009-2025 Movatter.jp