- Notifications
You must be signed in to change notification settings - Fork5.2k
Jit: Remove bounds checks with tests against length.#40180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
20 commits Select commitHold shift + click to select a range
9c4c520 Introduce a concept of minimum array length into range check
nathan-moorebce02ac Some cleanup
nathan-moore45caddb fix potential underflow
nathan-moore5e4640f Merge branch 'master' into morphToUnsigned
nathan-mooreaadeabe bug fix and cleanup
nathan-mooreee54472 Merge branch 'master' into morphToUnsigned
nathan-moore6f77bf8 Revert string changes
nathan-moore49ce937 Merge branch 'master' into morphToUnsigned
nathan-moore0ec7bea Allow elimination of arr[0] with len != 0 test
nathan-moorecd13bfc Revert "Revert string changes"
nathan-moore4e0e9f7 Fix up tests
nathan-moorebbea251 reverting lower bound merging as it may be unsound
nathan-mooree750aa9 Fix CI exposed bug and add a couple of test cases
nathan-mooref7905df code review feedback
nathan-moore2c422f7 Merge branch 'master' into morphToUnsigned
nathan-moore357a107 comment nit
nathan-moore57ad7ef Merge branch 'master' into morphToUnsigned
nathan-moorecac0180 feedback
nathan-moore8afbc53 Merge branch 'master' into morphToUnsigned
nathan-moore1ee8eda Add missing break
nathan-mooreFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
comment nit
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit357a10700be1a249442ee497844e890b283f0ffc
There are no files selected for viewing
2 changes: 1 addition & 1 deletionsrc/coreclr/src/jit/rangecheck.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.