- Notifications
You must be signed in to change notification settings - Fork5.2k
[wasm] Trim down size of dotnet.wasm#39549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Saves 4k on wasm.
Saves 0.5k on wasm
Saves 2.5k on wasm
Saves 0.5k on wasm
Saves 5k on wasm
Saves 1k on wasm
Saves 0.5k on wasm
Saves 1k on wasm
Saves 6k on wasm
This is mainly beneficial do to very common calls of g_error.Saves 35k on wasm
Collaborator
Dotnet-GitSync-Bot commentedJul 17, 2020
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly onearea label. |
ghost commentedJul 17, 2020
Tagging subscribers to this area:@BrzVlad |
vargaz approved these changesJul 17, 2020
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull requestAug 10, 2020
* [interp] Use constant for concurrent collection in progressSaves 4k on wasm.* [sgen] Use constant for concurrent sweepSaves 0.5k on wasm* [sgen] Remove code from threadpool when not using concurrent modeSaves 2.5k on wasm* [sgen] Avoid keeping some callbacks aliveSaves 0.5k on wasm* [sgen] Avoid registering callback if not used* [sgen] Add option to remove binary protocol from buildSaves 5k on wasm* [sgen] Add option to disable togglerefsSaves 1k on wasm* [sgen] We never need to wait for sweep if serialSaves 0.5k on wasm* [sgen] Disable also canaries if debug helpers are disabledSaves 1k on wasm* [sgen] Disable also pinning_stats if debug features are disabledSaves 2k on wasm* [sgen] Disable also gchandle stats if debug is disabledSaves 1k on wasm* [sgen] Disable also sgen logging if debugging is disabledSaves 6k on wasm* [runtime] Disable log messages if assert messages is disabledThis is mainly beneficial do to very common calls of g_error.Saves 35k on wasm
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This disables several debugging features in sgen, helps the compiler remove some unused code related to concurrent collector and disables more assertion messages, but also some other logs. We might have to reenable some of them if this is problematic.
Saves about 60k on wasm