- Notifications
You must be signed in to change notification settings - Fork5.3k
[browser] Library mode without workload#122607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
maraf commentedDec 17, 2025
@copilot This test variant |
This comment was marked as resolved.
This comment was marked as resolved.
)# DescriptionThe `LibraryMode` test variant with `useWasmSdk: False, isPublish: True`is expected to fail, but the test was asserting success for allvariants.Updated test to set `ExpectSuccess: false` when publishing without WASMSDK, verifying the operation exits with code 1 as expected.```csharp// Publishing without WASM SDK is expected to failbool expectSuccess = useWasmSdk || !isPublish;if (isPublish) PublishProject(info, config, new PublishOptions(AssertAppBundle: useWasmSdk, ExpectSuccess: expectSuccess));else BuildProject(info, config, new BuildOptions(AssertAppBundle: useWasmSdk, ExpectSuccess: expectSuccess));```# Customer ImpactNo customer impact - test-only change.# RegressionNo. Test was incomplete, not validating the expected failure scenario.# TestingTest compiles successfully. The updated test will properly validate allfour variants:- Build without SDK: succeeds- Build with SDK: succeeds - Publish with SDK: succeeds- Publish without SDK: **fails** (now correctly validated)# RiskMinimal - test-only change with no production code impact.<!-- START COPILOT CODING AGENT TIPS -->---✨ Let Copilot coding agent [set things up foryou](https://github.com/dotnet/runtime/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot)— coding agent works faster and does higher quality work when set up foryour repo.---------Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>Co-authored-by: maraf <10020471+maraf@users.noreply.github.com>
maraf commentedDec 18, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
The problem is when a library has |
Uh oh!
There was an error while loading.Please reload this page.
Building
OutputType=libraryas WebAssembly application doesn't need a workload to be installed.This PR moves the target that configures ILLink from workload to Wasm SDK.