Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[browser] Library mode without workload#122607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
maraf wants to merge7 commits intomain
base:main
Choose a base branch
Loading
frommaraf/BrowserLibraryModeNoWorkload

Conversation

@maraf
Copy link
Member

@marafmaraf commentedDec 17, 2025
edited
Loading

BuildingOutputType=library as WebAssembly application doesn't need a workload to be installed.
This PR moves the target that configures ILLink from workload to Wasm SDK.

@marafmaraf added this to the11.0.0 milestoneDec 17, 2025
@marafmaraf self-assigned thisDec 17, 2025
@marafmaraf added arch-wasmWebAssembly architecture area-Build-mono os-browserBrowser variant of arch-wasm labelsDec 17, 2025
@maraf
Copy link
MemberAuthor

@copilot This test variantWasm.Build.Tests.WasmTemplateTests.LibraryMode(useWasmSdk: False, isPublish: True) is expected to fail the build. Update the test to check that the publish finishes with exit code1

Copilot reacted with eyes emoji

This comment was marked as resolved.

CopilotAIand others added3 commitsDecember 17, 2025 20:50
)# DescriptionThe `LibraryMode` test variant with `useWasmSdk: False, isPublish: True`is expected to fail, but the test was asserting success for allvariants.Updated test to set `ExpectSuccess: false` when publishing without WASMSDK, verifying the operation exits with code 1 as expected.```csharp// Publishing without WASM SDK is expected to failbool expectSuccess = useWasmSdk || !isPublish;if (isPublish)    PublishProject(info, config, new PublishOptions(AssertAppBundle: useWasmSdk, ExpectSuccess: expectSuccess));else    BuildProject(info, config, new BuildOptions(AssertAppBundle: useWasmSdk, ExpectSuccess: expectSuccess));```# Customer ImpactNo customer impact - test-only change.# RegressionNo. Test was incomplete, not validating the expected failure scenario.# TestingTest compiles successfully. The updated test will properly validate allfour variants:- Build without SDK: succeeds- Build with SDK: succeeds  - Publish with SDK: succeeds- Publish without SDK: **fails** (now correctly validated)# RiskMinimal - test-only change with no production code impact.<!-- START COPILOT CODING AGENT TIPS -->---✨ Let Copilot coding agent [set things up foryou](https://github.com/dotnet/runtime/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot)— coding agent works faster and does higher quality work when set up foryour repo.---------Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>Co-authored-by: maraf <10020471+maraf@users.noreply.github.com>
@maraf
Copy link
MemberAuthor

maraf commentedDec 18, 2025
edited
Loading

The problem is when a library hasRuntimeIdentifier=browser-wasm, but it doesn't import WasmSDK, we trigger the requirement for workload. It doesn't sound correct. Previously it might have make sense, because we triggered WasmAppBundler just by RID.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ilonatommyilonatommyAwaiting requested review from ilonatommyilonatommy will be requested when the pull request is marked ready for reviewilonatommy is a code owner

@lewinglewingAwaiting requested review from lewinglewing will be requested when the pull request is marked ready for reviewlewing is a code owner

@akoeplingerakoeplingerAwaiting requested review from akoeplingerakoeplinger will be requested when the pull request is marked ready for reviewakoeplinger is a code owner

Copilot code reviewCopilotAwaiting requested review from CopilotCopilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

@marafmaraf

Labels

arch-wasmWebAssembly architecturearea-Build-monoos-browserBrowser variant of arch-wasm

Projects

None yet

Milestone

11.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@maraf

[8]ページ先頭

©2009-2025 Movatter.jp