- Notifications
You must be signed in to change notification settings - Fork5.2k
[crossgen2] Update minimum maccatalyst versions to 15.2#122010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
[crossgen2] Update minimum maccatalyst versions to 15.2#122010
Conversation
Tagging subscribers to 'os-ios':@vitek-karas,@kotlarmilos,@steveisok,@akoeplinger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull request overview
This PR updates the minimum maccatalyst version from 15.0 to 15.2 for crossgen2 and corelib builds to align the linking version with the compilation version.
- Updated
AppleMinOSVersionproperty for maccatalyst from 15.0 to 15.2 in crossgen2 targets - Updated
AppleMinOSVersionproperty for maccatalyst from 15.0 to 15.2 in crossgen-corelib project
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/tasks/Crossgen2Tasks/Microsoft.NET.CrossGen.targets | Updates maccatalyst minimum OS version to 15.2 for crossgen2 R2R compilation |
| src/coreclr/crossgen-corelib.proj | Updates maccatalyst minimum OS version to 15.2 for corelib crossgen compilation |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card.Take the survey.
| <PropertyGroup> | ||
| <AppleMinOSVersionCondition="'$(AppleMinOSVersion)' == '' and '$(_AppleTargetOS)' == 'osx'">12.0</AppleMinOSVersion> | ||
| <AppleMinOSVersionCondition="'$(AppleMinOSVersion)' == '' and '$(_AppleTargetOS)' == 'maccatalyst'">15.0</AppleMinOSVersion> | ||
| <AppleMinOSVersionCondition="'$(AppleMinOSVersion)' == '' and '$(_AppleTargetOS)' == 'maccatalyst'">15.2</AppleMinOSVersion> |
CopilotAINov 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The maccatalyst minimum version is being updated to 15.2 in this file, but the same version insrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets at line 81 is still set to 15.0. For consistency, that file should also be updated to 15.2 to ensure NativeAOT builds use the same minimum version.
Uh oh!
There was an error while loading.Please reload this page.
kotlarmilos commentedNov 28, 2025
/azp run runtime-maccatalyst |
| Azure Pipelines successfully started running 1 pipeline(s). |
Uh oh!
There was an error while loading.Please reload this page.
Description
Crossgen2 is currently compiling for maccatalyst 15.2 but linking against 15.0. This change ensures that R2R object file is built and linked against the same version on maccatalyst.
Error log: