NotificationsYou must be signed in to change notification settings
Fork5.3k
Star17.3k

Avoid marking types as reflected on in CreateSpan#118832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

jkotas merged 2 commits intodotnet:mainfromMichalStrehovsky:createspan

Aug 19, 2025

Merged

Avoid marking types as reflected on in CreateSpan#118832

jkotas merged 2 commits intodotnet:mainfromMichalStrehovsky:createspan

Aug 19, 2025

Conversation

Copy link

Member

MichalStrehovsky commentedAug 18, 2025•
edited
Loading

This seems to be the only reason why Hello World on Linux still needs support for boxed enums.CreateSpan is used with an enum type in Unix System.Console, which brings a boxed enum into whole program view and we can't undo the damage this causes to the whole program view during compilation anymore (even though we no longer need thetypeof then because RyuJIT always expandsCreateSpan).

Project	Size before	Size after	Difference
hello-linux	1221600	1151440	-70160
hello-minimal-linux	1069896	999736	-70160

Avoid marking types as reflected on in CreateSpan

d2c68e7

This seems to be at least one of the reasons why Hello World on Linux still needs support for boxed enums. `CreateSpan` is used with an enum type in Unix System.Console, which brings a boxed enum into whole program view and we can't undo the damage this causes to the whole program view during compilation anymore (even though we no longer need the `typeof` then because RyuJIT always expands `CreateSpan`).

CopilotAI review requested due to automatic review settings

August 18, 2025 05:24

github-actionsbot added the area-NativeAOT-coreclr label

Aug 18, 2025

CopilotAI reviewed

Aug 18, 2025

View reviewed changes

Copy link

Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR optimizes NativeAOT compilation by avoiding unnecessary type reflection marking in theCreateSpan<T> method. The change prevents enum types from being marked as reflected-on whenCreateSpan is called, which was causing unnecessary bloat in Hello World applications on Linux that required support for boxed enums.

Key Changes:

Moves thePlatformNotSupportedException throw earlier in the call chain for NativeAOT to avoid executingtypeof(T).TypeHandle
Removes the unusedGetSpanDataFrom helper method from the NativeAOT-specific implementation
Adds conditional compilation to handle the method differently between NativeAOT and other runtimes

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
RuntimeHelpers.cs	Adds NativeAOT-specific conditional compilation to throw exception before type reflection occurs
RuntimeHelpers.NativeAot.cs	Removes unused`GetSpanDataFrom` helper method that was only throwing exceptions

_{You can also share your feedback on Copilot code review for a chance to win a $100 gift card.Take the survey.}