- Notifications
You must be signed in to change notification settings - Fork5.2k
[release/9.0-staging] throw an exception instead of infinite loop insort_mark_list#115529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Maoni0 merged 2 commits intorelease/9.0-stagingfrombackport/pr-115492-to-release/9.0-stagingMay 23, 2025
Merged
[release/9.0-staging] throw an exception instead of infinite loop insort_mark_list#115529
Maoni0 merged 2 commits intorelease/9.0-stagingfrombackport/pr-115492-to-release/9.0-stagingMay 23, 2025
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
jeffschwMSFT approved these changesMay 13, 2025
Member
jeffschwMSFT left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
lgtm. we will take for consideration in 9.0.x
Contributor
Tagging subscribers to this area: @dotnet/gc |
fee2cf8 intorelease/9.0-staging 92 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Backport of#115492 to release/9.0-staging
/cc@Maoni0
Customer Impact
infinite loops are bad for prod diag and they'd prefer a crash.
Regression
Testing
it's a request to help make it easier for prod diag. I've tested that this does throw an exception if that condition is hit..
Risk
low
IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging, notrelease/X.0.Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.