- Notifications
You must be signed in to change notification settings - Fork5.2k
[release/9.0-staging] Use minipal_getcpufeatures to detect for AVX (#113032)#113489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[release/9.0-staging] Use minipal_getcpufeatures to detect for AVX (#113032)#113489
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Tagging subscribers to this area: @dotnet/gc |
mangod9 commentedMar 14, 2025
the build is still failing to find an include file. |
0399a20 toef9bf29Compare
jeffschwMSFT left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
lgtm. we will take for consideration in 9.0.x
9226298 intodotnet:release/9.0-stagingUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Backport of # to release/9.0-staging
/cc@cshung
Customer Impact
@Typhon226 reported on#112897 that, on some machines, buggy behavior in
__builtin_cpu_supportsfor Unix platforms could lie to us that it supports AVX512 when it doesn't. This could lead to runtime crashes.Regression
The regression was introduced in PR#98712, commit68cf2dd when I enabled VxSort for unix platforms, but this is not the root cause.
Testing
Local testing is done on various machines, but none of them hit the
__builtin_cpu_supportsbuggy behavior, so it worked both before and after the changes.#113032 (comment)
Customer testing is done on the machines that hit the issue, and the fixed version works as expected, for both#112897 (comment) (9.0 binaries) and#112897 (comment) (10.0 binaries)
Risk
The risk is low, the same function is used by the JIT to determine if the CPU supports AVX512.