Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[release/9.0-staging] JIT: avoid fp divide by zero in profile synthesis#113418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@github-actions
Copy link
Contributor

@github-actionsgithub-actionsbot commentedMar 12, 2025•
edited by AndyAyersMS
Loading

Backport of#113396 to release/9.0-staging

/cc@AndyAyersMS

Customer Impact

  • Customer reported
  • Found internally

Unexpected floating-point divide by zero exception. While we generally don't support running managed code with FP exceptions enabled, we also should not be generating such exceptions needlessly.

There is precedent for us back porting this kind of change, see eg:#76334

Regression

  • Yes
  • No

.NET 9 added a fair amount of FP processing to the JIT that wasn't there in .NET 8.

Testing

Verified the JIT will no longer cause FP exception from this computation.

Risk

Low, no diffs in SPMI.

This can trip up users that have enabled floating point exceptions.While we don't generally support changing the exception modes we alsocan easily avoid dividing by zero here.Addresses#113369
@ghostghost added the area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labelMar 12, 2025
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area:@JulieLeeMSFT,@jakobbotsch
See info inarea-owners.md if you want to be subscribed.

@AndyAyersMS
Copy link
Member

@jeffschwMSFT@JulieLeeMSFT FYI

cc @dotnet/jit-contrib

Copy link
Member

@jeffschwMSFTjeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

lgtm. we will take for consideration in 9.0.x

@jeffschwMSFTjeffschwMSFT added the Servicing-considerIssue for next servicing release review labelMar 12, 2025
@jeffschwMSFTjeffschwMSFT added this to the9.0.x milestoneMar 12, 2025
@leecowleecow added Servicing-approvedApproved for servicing release and removed Servicing-considerIssue for next servicing release review labelsMar 18, 2025
@leecowleecow modified the milestones:9.0.x,9.0.5Mar 18, 2025
@jeffschwMSFTjeffschwMSFT merged commitc8613e5 intorelease/9.0-stagingMar 26, 2025
97 of 99 checks passed
@jkotasjkotas deleted the backport/pr-113396-to-release/9.0-staging branchApril 12, 2025 13:58
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMay 13, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@jeffschwMSFTjeffschwMSFTjeffschwMSFT approved these changes

@JulieLeeMSFTJulieLeeMSFTJulieLeeMSFT approved these changes

+1 more reviewer

@amanasifkhalidamanasifkhalidamanasifkhalid approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIServicing-approvedApproved for servicing release

Projects

None yet

Milestone

9.0.5

Development

Successfully merging this pull request may close these issues.

6 participants

@AndyAyersMS@jeffschwMSFT@amanasifkhalid@JulieLeeMSFT@leecow
[8]ページ先頭
©2009-2025 Movatter.jp