Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add remark toConditionalSelect#111945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tannergooding merged 3 commits intodotnet:mainfromhamarb123:main21
Jan 30, 2025
Merged

Conversation

@hamarb123
Copy link
Contributor

@hamarb123hamarb123 commentedJan 29, 2025
edited
Loading

When writing a conditional select, I usually start writing the condition, and then get stuck because I don't remember whether the bit acts like a ternary or like an index (like, before I putleft andright in whatever order, so I don't ever see their comments before I figure it out - I usually end up searching stuff on dotnet/runtime for example uses or similar to figure it out) -@tannergooding suggested that I add a remark to the function itself to explain how it selects it; that way I can just hover over it and see it immediately, even before I get to left & right (so I can figure out my condition, e.g., whether I want< or> might depend on the order of the parameters).

Seedotnet/dotnet-api-docs#10885

@dotnet-policy-servicedotnet-policy-servicebot added the community-contributionIndicates that the PR has been added by a community member labelJan 29, 2025
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics
See info inarea-owners.md if you want to be subscribed.

@tannergoodingtannergooding merged commitf3d90b2 intodotnet:mainJan 30, 2025
141 of 143 checks passed
grendello added a commit to grendello/runtime that referenced this pull requestJan 30, 2025
* main: (31 commits)  More native AOT Pri-1 test tree bring up (dotnet#111994)  Fix BigInteger outerloop test (dotnet#111841)  JIT: Run 3-opt once across all regions (dotnet#111989)  JIT: Check for profile consistency throughout JIT backend (dotnet#111684)  [JIT] Add legacy extended EVEX encoding and EVEX.ND/NF feature to x64 emitter backend (dotnet#108796)  [iOS][globalization] Fix IndexOf on empty strings on iOS to return -1 (dotnet#111898)  System.Speech: Use intellisense xml from dotnet-api-docs (dotnet#111983)  [mono][mini] Disable inlining if we encounter class initialization failure (dotnet#111754)  [main] Update dependencies from dotnet/roslyn (dotnet#111946)  Update dependencies fromhttps://github.com/dotnet/arcade build 20250129.2 (dotnet#111996)  Try changing the ICustomQueryInterface implementation to always return NotHandled instead of Failed to defer back to the ComWrappers impl. (dotnet#111978)  Combined dependency update (dotnet#111852)  Replace OPTIMIZE_FOR_SIZE with feature switch (dotnet#111743)  Fix failed assertion 'FPbased == FPbased2' (dotnet#111787)  Add remark to `ConditionalSelect` (dotnet#111945)  JIT: fix try region cloning when try is nested in a handler (dotnet#111975)  Use IRootFunctions in Tensor.StdDev (dotnet#110641)  Remove zlib dependencies from Docker containers (dotnet#111939)  Avoid `Unsafe.As` for `Memory<T>` and `ReadOnlyMemory<T>` conversion (dotnet#111023)  Cleanup membarrier portability (dotnet#111943)  ...
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 1, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@tannergoodingtannergoodingtannergooding approved these changes

Assignees

No one assigned

Labels

area-System.Runtime.Intrinsicscommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hamarb123@tannergooding

[8]ページ先頭

©2009-2025 Movatter.jp