Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix failed assertion 'FPbased == FPbased2'#111787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kunalspathak merged 2 commits intodotnet:mainfromfilipnavara:fix-111451
Jan 30, 2025

Conversation

@filipnavara
Copy link
Member

@filipnavarafilipnavara commentedJan 24, 2025•
edited
Loading

WhenlvaFrameAddress optimizes one of the temporary variables (referenced as FP-m) to be placed next to existing SP+n variable (eg.OutgoingArgSpace at SP+0) we may end up coalescing a pair-wise load/store between them. A previous attempt to handle the case only accounted for thelvaFrameAddress optimization being applied to both of the variables or neither of them, but it didn't correctly handle the mixed variant.

Fixes#111777

…ation merged SP+n and FP-m stores into a single pair-wise store
@ghostghost added the area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labelJan 24, 2025
@dotnet-policy-servicedotnet-policy-servicebot added the community-contributionIndicates that the PR has been added by a community member labelJan 24, 2025
@filipnavara
Copy link
MemberAuthor

filipnavara commentedJan 24, 2025•
edited
Loading

Can someone triggerruntime-coreclr libraries-jitstress pipeline on this PR please?

@filipnavarafilipnavara changed the title[CI test] Fix assertion failed 'FPbased == FPbased2'[CI test] Fix failed assertion 'FPbased == FPbased2'Jan 24, 2025
@jakobbotsch
Copy link
Member

/azp run runtime-coreclr libraries-jitstress

filipnavara reacted with thumbs up emoji

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@filipnavara

This comment was marked as outdated.

@EgorBo
Copy link
Member

/azp run runtime-coreclr libraries-jitstress

filipnavara reacted with thumbs up emoji

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@filipnavarafilipnavara changed the title[CI test] Fix failed assertion 'FPbased == FPbased2'Fix failed assertion 'FPbased == FPbased2'Jan 24, 2025
@filipnavarafilipnavara marked this pull request as ready for reviewJanuary 24, 2025 15:59
@filipnavara
Copy link
MemberAuthor

Can we run/azp run runtime-coreclr gcstress0x3-gcstress0xc, runtime-coreclr gcstress-extra to make sure that I didn't miss anything?

@danmoseley
Copy link
Member

/azp run runtime-coreclr gcstress0x3-gcstress0xc, runtime-coreclr gcstress-extra

filipnavara reacted with thumbs up emoji

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@filipnavara
Copy link
MemberAuthor

TheCrossApartmentQueryInterface_NoDeadlock test failure seems new and unrelated to this PR. The test was added 3 weeks ago and it likely only happens in the GC stress runs. /cc@jkoritzinsky

@jkoritzinsky
Copy link
Member

That's a known issue. It's on my list of things to look at.

filipnavara reacted with thumbs up emoji

@filipnavara
Copy link
MemberAuthor

That's a known issue. It's on my list of things to look at.

I didn't see any other failure in the Azure history which is why I asked. I'm happy to know it's on the radar.

@AndyAyersMS
Copy link
Member

@EgorBo are you the right reviewer for this?

@kunalspathakkunalspathak self-requested a reviewJanuary 30, 2025 01:00
Copy link
Contributor

@kunalspathakkunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

// If there are 2 GC vars in this instrDesc, get the 2nd variable
// that should be tracked.
adr2 = emitComp->lvaFrameAddress(varNum2, &FPbased2,true);
adr2 = emitComp->lvaFrameAddress(varNum2, &FPbased2,FPbased);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I forgot to tell, but can you add a comment aboutsuppressFPtoSPRewrite in the method docs oflvaFrameAddress? OK to do in separate PR.

filipnavara reacted with thumbs up emoji
@kunalspathakkunalspathak merged commit7693b6d intodotnet:mainJan 30, 2025
146 of 150 checks passed
grendello added a commit to grendello/runtime that referenced this pull requestJan 30, 2025
* main: (31 commits)  More native AOT Pri-1 test tree bring up (dotnet#111994)  Fix BigInteger outerloop test (dotnet#111841)  JIT: Run 3-opt once across all regions (dotnet#111989)  JIT: Check for profile consistency throughout JIT backend (dotnet#111684)  [JIT] Add legacy extended EVEX encoding and EVEX.ND/NF feature to x64 emitter backend (dotnet#108796)  [iOS][globalization] Fix IndexOf on empty strings on iOS to return -1 (dotnet#111898)  System.Speech: Use intellisense xml from dotnet-api-docs (dotnet#111983)  [mono][mini] Disable inlining if we encounter class initialization failure (dotnet#111754)  [main] Update dependencies from dotnet/roslyn (dotnet#111946)  Update dependencies fromhttps://github.com/dotnet/arcade build 20250129.2 (dotnet#111996)  Try changing the ICustomQueryInterface implementation to always return NotHandled instead of Failed to defer back to the ComWrappers impl. (dotnet#111978)  Combined dependency update (dotnet#111852)  Replace OPTIMIZE_FOR_SIZE with feature switch (dotnet#111743)  Fix failed assertion 'FPbased == FPbased2' (dotnet#111787)  Add remark to `ConditionalSelect` (dotnet#111945)  JIT: fix try region cloning when try is nested in a handler (dotnet#111975)  Use IRootFunctions in Tensor.StdDev (dotnet#110641)  Remove zlib dependencies from Docker containers (dotnet#111939)  Avoid `Unsafe.As` for `Memory<T>` and `ReadOnlyMemory<T>` conversion (dotnet#111023)  Cleanup membarrier portability (dotnet#111943)  ...
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 1, 2025
@filipnavarafilipnavara deleted the fix-111451 branchApril 2, 2025 20:06
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

1 more reviewer

@kunalspathakkunalspathakkunalspathak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

JIT: Assertion failed 'FPbased == FPbased2' during 'Emit code'

7 participants

@filipnavara@jakobbotsch@EgorBo@danmoseley@jkoritzinsky@AndyAyersMS@kunalspathak
[8]ページ先頭
©2009-2025 Movatter.jp