- Notifications
You must be signed in to change notification settings - Fork5.2k
[release/9.0-staging] Fix calling convention mismatch in GC callouts#111105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
jeffschwMSFT merged 3 commits intorelease/9.0-stagingfrombackport/pr-110685-to-release/9.0-stagingJan 8, 2025
Merged
[release/9.0-staging] Fix calling convention mismatch in GC callouts#111105
jeffschwMSFT merged 3 commits intorelease/9.0-stagingfrombackport/pr-110685-to-release/9.0-stagingJan 8, 2025
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Contributor
Tagging subscribers to this area:@agocke,@MichalStrehovsky,@jkotas |
AaronRobinsonMSFT approved these changesJan 6, 2025
jkotas approved these changesJan 6, 2025
jeffschwMSFT approved these changesJan 6, 2025
Member
jeffschwMSFT left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
lgtm. we will take for consideration in 9.0.x
7a95474 intorelease/9.0-staging 10 of 16 checks passed
Uh oh!
There was an error while loading.Please reload this page.
This was referencedJan 8, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Backport of#110685 to release/9.0-staging
/cc@AaronRobinsonMSFT@MichalStrehovsky
Customer Impact
The GC will crash in .NET 9 when published with native AOT onwin-x86. A GC callback was defined with an incorrect calling convention. This was reported by a customer -#110607.
Related servicing issue:#110815
Regression
Support for x86_32 was introduced in .NET 9.
Testing
Validated this with the help of Windows Store owners.
Risk
Low