- Notifications
You must be signed in to change notification settings - Fork5.2k
[release/9.0-staging] Upgrade our macOS build machines to the latest non-beta x64 image#109455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[release/9.0-staging] Upgrade our macOS build machines to the latest non-beta x64 image#109455
Uh oh!
There was an error while loading.Please reload this page.
Conversation
e9ef4b6 to5f65b3cCompare| # OSX Public Build Pool (we don't have on-prem OSX BuildPool). | ||
| ${{ if and(in(parameters.osGroup, 'osx', 'maccatalyst', 'ios', 'iossimulator', 'tvos', 'tvossimulator'), eq(variables['System.TeamProject'], 'public')) }}: | ||
| vmImage:'macos-12' | ||
| vmImage:'macos-13' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think we'll need to bump the official build image too since I see the same deprecation warning in the official build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'll run a test official build for this branch and the 8.0 one to make sure nothing breaks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Official builds look good. Merging
jeffschwMSFT left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
approved. we can take this as tell mode
jkoritzinsky commentedNov 4, 2024
/ba-g browser timeout unrelated |
81ea5e1 intorelease/9.0-stagingUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Backport of#109454 to release/9.0-staging
/cc@jkoritzinsky
Customer Impact
[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.]
The macOS-12 build pools are going away in December, so we need to switch away from them before they are removed to avoid failures in public CI.
Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
[How was the fix verified? How was the issue missed previously? What tests were added?]
CI validation of building on the new build pools.
Risk
[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]
Low: This PR validates that the build continues to work. Additionally, we selected an x64 macOS pool to limit possible churn.