Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[release/9.0-staging] Add forwarding support for WasmLinkage on LibraryImport#109364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@github-actions
Copy link
Contributor

@github-actionsgithub-actionsbot commentedOct 29, 2024
edited by jkoritzinsky
Loading

Backport of#109234 to release/9.0-staging

/cc@jkoritzinsky

Customer Impact

  • Customer reported
  • Found internally

Consumers trying to use the newWasmImportLinkage attribute introduced in .NET 9 encounter unexpected and inconsistent failures when usingLibraryImportAttribute, the recommended mechanism for doing interop with C-ABI libraries.

This backport introduces the support forWasmImportLinkage toLibraryImportAttribute, so the new attribute can be used as our documentation and the attribute's design intend, as well as how our users expect.

Regression

  • Yes
  • No

[If yes, specify when the regression was introduced. Provide the PR or commit if known.]

Testing

[How was the fix verified? How was the issue missed previously? What tests were added?]

We added tests to verify that the attribute is forwarded to the underlyingDllImport and as such will provide the expected experience.

Risk

[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]

Low:LibraryImport is never used in combination withWasmImportLinkage in any product code, so we won't be making any changes to any generated product code with this backport.

Additionally, the scope of this change is similar to the scope of similar changes we've backported previously and to changes that are introduced in new SDK bands in code fixes and analyzers shipped in the SDK.

@AaronRobinsonMSFTAaronRobinsonMSFT added the Servicing-considerIssue for next servicing release review labelOct 30, 2024
Copy link
Member

@jeffschwMSFTjeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

lgtm. we will take for consideration in 9.0.x

@jeffschwMSFT
Copy link
Member

@jkoritzinsky please take a look at the PR failures and merge when ready

jkoritzinsky reacted with thumbs up emoji

@jkoritzinsky
Copy link
Member

/ba-gdotnet/dnceng#4756

@jkoritzinskyjkoritzinsky merged commit8abd404 intorelease/9.0-stagingJan 9, 2025
89 of 94 checks passed
@jkoritzinskyjkoritzinsky deleted the backport/pr-109234-to-release/9.0-staging branchJanuary 9, 2025 00:19
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsFeb 8, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@jeffschwMSFTjeffschwMSFTjeffschwMSFT approved these changes

@AaronRobinsonMSFTAaronRobinsonMSFTAaronRobinsonMSFT approved these changes

Assignees

No one assigned

Labels

Projects

None yet

Milestone

9.0.2

Development

Successfully merging this pull request may close these issues.

6 participants

@jeffschwMSFT@jkoritzinsky@AaronRobinsonMSFT@carlossanlop@rbhanda

[8]ページ先頭

©2009-2025 Movatter.jp