- Notifications
You must be signed in to change notification settings - Fork5.2k
[release/9.0-staging] Add forwarding support for WasmLinkage on LibraryImport#109364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
jkoritzinsky merged 2 commits intorelease/9.0-stagingfrombackport/pr-109234-to-release/9.0-stagingJan 9, 2025
Merged
[release/9.0-staging] Add forwarding support for WasmLinkage on LibraryImport#109364
jkoritzinsky merged 2 commits intorelease/9.0-stagingfrombackport/pr-109234-to-release/9.0-stagingJan 9, 2025
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
AaronRobinsonMSFT approved these changesOct 30, 2024
jeffschwMSFT approved these changesOct 30, 2024
Member
jeffschwMSFT left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
lgtm. we will take for consideration in 9.0.x
This was referencedOct 30, 2024
Closed
Member
jeffschwMSFT commentedJan 8, 2025
@jkoritzinsky please take a look at the PR failures and merge when ready |
Member
jkoritzinsky commentedJan 9, 2025
/ba-gdotnet/dnceng#4756 |
8abd404 intorelease/9.0-staging 89 of 94 checks passed
Uh oh!
There was an error while loading.Please reload this page.
3 tasks
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Backport of#109234 to release/9.0-staging
/cc@jkoritzinsky
Customer Impact
Consumers trying to use the new
WasmImportLinkageattribute introduced in .NET 9 encounter unexpected and inconsistent failures when usingLibraryImportAttribute, the recommended mechanism for doing interop with C-ABI libraries.This backport introduces the support for
WasmImportLinkagetoLibraryImportAttribute, so the new attribute can be used as our documentation and the attribute's design intend, as well as how our users expect.Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
[How was the fix verified? How was the issue missed previously? What tests were added?]
We added tests to verify that the attribute is forwarded to the underlying
DllImportand as such will provide the expected experience.Risk
[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]
Low:
LibraryImportis never used in combination withWasmImportLinkagein any product code, so we won't be making any changes to any generated product code with this backport.Additionally, the scope of this change is similar to the scope of similar changes we've backported previously and to changes that are introduced in new SDK bands in code fixes and analyzers shipped in the SDK.