- Notifications
You must be signed in to change notification settings - Fork5.2k
[release/9.0] Backport PR #108311 - Fix statics issue with barriers#108347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
jeffschwMSFT merged 2 commits intodotnet:release/9.0fromdavidwrighton:backport_108311_to_release_9_0Oct 3, 2024
Merged
[release/9.0] Backport PR #108311 - Fix statics issue with barriers#108347
jeffschwMSFT merged 2 commits intodotnet:release/9.0fromdavidwrighton:backport_108311_to_release_9_0Oct 3, 2024
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
* Fix statics issue with barriers* Add barriers for RiscV and Loongson
ghost commentedSep 27, 2024
Note regarding the |
1 similar comment
ghost commentedSep 27, 2024
Note regarding the |
EgorBo approved these changesSep 27, 2024
jkotas approved these changesSep 27, 2024
jeffschwMSFT approved these changesSep 27, 2024
Member
jeffschwMSFT left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
lgtm. we will take for consideration in 9 GA
Contributor
Tagging subscribers to this area:@mangod9 |
This was referencedOct 3, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of#108311 to release/9.0
Customer Impact
Applications unexpected crash during startup while attempting to access statics in heavily multithreaded applications. This causes instability for processes which engage in heavily threaded code which has usage of many static variables.
Regression
This was introduced with#99183 , and a previous fix was attempted#105832 . That previous fix was found to be insufficient.
Testing
A new stress test was written by@EgorBo that finally provided a reliable repro case for the failure in#105441 (comment) This reliable repro case was finally found yesterday. Previously we'd only observed the failure in CI, but the manifestation always used a non-live built version of the runtime.
Risk
Medium, additional correctness problems are unexpected, but there may be some performance impact. If this does not fix the issue, further investigation will be needed.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessarypackage authoring and gotten it explicitly reviewed.