Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[release/9.0] [mono] Fix swizzle_mask type#107602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jeffschwMSFT merged 2 commits intorelease/9.0frombackport/pr-107460-to-release/9.0
Sep 16, 2024

Conversation

@github-actions
Copy link
Contributor

@github-actionsgithub-actionsbot commentedSep 10, 2024•
edited by lewing
Loading

Backport of#107460 to release/9.0

/cc@lambdageek@radekdoulik

Customer Impact

  • Customer reported
  • Found internally

When working though llvm issues it was discovered that the wrong llvm type was used when constructing the Wasm SIMD intrinsic swizzle mask. The fixes a correctness issue that would otherwise appear when working with llvm

Regression

  • Yes
  • No

[If yes, specify when the regression was introduced. Provide the PR or commit if known.]

Testing

[How was the fix verified? How was the issue missed previously? What tests were added?]

Risk

Low

That was catched by llvm debug asserts, the mask should be vector of 16 int8
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area:@lambdageek,@steveisok
See info inarea-owners.md if you want to be subscribed.

@lewinglewing added the Servicing-considerIssue for next servicing release review labelSep 10, 2024
@jeffschwMSFT
Copy link
Member

@lewing can we get the template filled in?

@lewinglewing removed the Servicing-considerIssue for next servicing release review labelSep 12, 2024
Copy link
Member

@jeffschwMSFTjeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

approved. we can merge when ready

@jeffschwMSFTjeffschwMSFT added the Servicing-approvedApproved for servicing release labelSep 12, 2024
@jeffschwMSFT
Copy link
Member

@lewing please take a look at the PR failures

@jeffschwMSFT
Copy link
Member

@lewing@radekdoulik today is the snap, please take a look at the PR failures

@jeffschwMSFTjeffschwMSFT removed the Servicing-approvedApproved for servicing release labelSep 16, 2024
@lewinglewing added the Servicing-approvedApproved for servicing release labelSep 16, 2024
@lewing
Copy link
Member

/ba-g BA is red because this is a release branch, failures are known

@lewing
Copy link
Member

@jeffschwMSFT both this and the other look fine now

@jeffschwMSFTjeffschwMSFT merged commit3de60e8 intorelease/9.0Sep 16, 2024
@jkotasjkotas deleted the backport/pr-107460-to-release/9.0 branchSeptember 18, 2024 21:31
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 19, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@lewinglewinglewing approved these changes

@jeffschwMSFTjeffschwMSFTjeffschwMSFT approved these changes

@fanyang-monofanyang-monoAwaiting requested review from fanyang-monofanyang-mono is a code owner

@steveisoksteveisokAwaiting requested review from steveisoksteveisok is a code owner

Assignees

No one assigned

Labels

area-Codegen-LLVM-monoServicing-approvedApproved for servicing release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jeffschwMSFT@lewing@radekdoulik
[8]ページ先頭
©2009-2025 Movatter.jp