- Notifications
You must be signed in to change notification settings - Fork5.2k
[wasm] Bump chrome for testing - linux: 128.0.6613.119, windows: 128.0.6613.120#107504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Tagging subscribers to this area:@directhex,@matouskozak |
ilonatommy commentedSep 10, 2024
Failing with#107466, even afterdotnet/xharness#1261. |
ilonatommy commentedSep 13, 2024
Still failing with timeouts.@pavelsavara had an idea that we could try to add to add more flags to chrome, like |
Uh oh!
There was an error while loading.Please reload this page.
…in driver-browser communication.
ilonatommy commentedSep 18, 2024
It helped, we can see that the last build has no WBT failures on Windows, where the fix was used but Lib tests still fail - we did not add the |
ilonatommy commentedSep 19, 2024
/ba-g failures are#108019. |
…0.6613.120 (dotnet#107504)* Automated bump of chrome version* Addning new `BrowserArguments` is possible without changes on xharness side.* Add `--disable-gpu` to lib tests as well.* Set `PageLoadStrategy=NONE` for browser on Windows to avoid timeouts in driver-browser communication.* Remove whitespace.* Set the fixing flag for lib tests on Windows.* Fix: add args to chrome scenario, not node.* Move appended WBT args to one place.---------Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>Co-authored-by: Ilona Tomkowicz <32700855+ilonatommy@users.noreply.github.com>Co-authored-by: Larry Ewing <lewing@microsoft.com>Co-authored-by: Ilona Tomkowicz <itomkowicz@microsoft.com>
Uh oh!
There was an error while loading.Please reload this page.
options.setPageLoadStrategy(PageLoadStrategy.NONE);- selenium returns immediately when the page content is downloaded, opposed to waiting for a full load by default (PageLoadStrategy.NORMAL) (or at least PageLoadStrategy.EAGER - Selenium waits for DOM content) forWasmBuildTestson Windows andLibraryTeston Windows.--disable-gputhat could contribute to timeouts.