Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[wasm] Bump chrome for testing - linux: 128.0.6613.119, windows: 128.0.6613.120#107504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ilonatommy merged 12 commits intomainfromupdate-chrome-version-10755397283
Sep 19, 2024

Conversation

@github-actions
Copy link
Contributor

@github-actionsgithub-actionsbot commentedSep 8, 2024
edited by ilonatommy
Loading

  • Setoptions.setPageLoadStrategy(PageLoadStrategy.NONE); - selenium returns immediately when the page content is downloaded, opposed to waiting for a full load by default (PageLoadStrategy.NORMAL) (or at least PageLoadStrategy.EAGER - Selenium waits for DOM content) forWasmBuildTests on Windows andLibraryTest on Windows.
  • Adding--disable-gpu that could contribute to timeouts.

@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area:@directhex,@matouskozak
See info inarea-owners.md if you want to be subscribed.

@ilonatommyilonatommy self-assigned thisSep 9, 2024
@ilonatommy
Copy link
Member

Failing with#107466, even afterdotnet/xharness#1261.

This was referencedSep 11, 2024
@ilonatommy
Copy link
Member

Still failing with timeouts.@pavelsavara had an idea that we could try to add to add more flags to chrome, like--disable-gpu,options.setPageLoadStrategy(PageLoadStrategy.NONE); - selenium returns immediately when the page content is downloaded, opposed to waiting for a full load by default (PageLoadStrategy.NORMAL) (or at leastPageLoadStrategy.EAGER - Selenium waits for DOM content). I'll create another PR on xharness to check it out.

@ilonatommy
Copy link
Member

It helped, we can see that the last build has no WBT failures on Windows, where the fix was used but Lib tests still fail - we did not add thePageLoadStrategy.NONE there yet

@ilonatommy
Copy link
Member

/ba-g failures are#108019.

@ilonatommyilonatommy merged commit51bd2b9 intomainSep 19, 2024
@jkotasjkotas deleted the update-chrome-version-10755397283 branchSeptember 21, 2024 05:22
sirntar pushed a commit to sirntar/runtime that referenced this pull requestSep 30, 2024
…0.6613.120 (dotnet#107504)* Automated bump of chrome version* Addning new `BrowserArguments` is possible without changes on xharness side.* Add `--disable-gpu` to lib tests as well.* Set `PageLoadStrategy=NONE` for browser on Windows to avoid timeouts in driver-browser communication.* Remove whitespace.* Set the fixing flag for lib tests on Windows.* Fix: add args to chrome scenario, not node.* Move appended WBT args to one place.---------Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>Co-authored-by: Ilona Tomkowicz <32700855+ilonatommy@users.noreply.github.com>Co-authored-by: Larry Ewing <lewing@microsoft.com>Co-authored-by: Ilona Tomkowicz <itomkowicz@microsoft.com>
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 22, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@ilonatommyilonatommyilonatommy approved these changes

@akoeplingerakoeplingerAwaiting requested review from akoeplinger

@lewinglewingAwaiting requested review from lewing

@marafmarafAwaiting requested review from marafmaraf is a code owner

@pavelsavarapavelsavaraAwaiting requested review from pavelsavara

Assignees

@ilonatommyilonatommy

Labels

arch-wasmWebAssembly architecturearea-Infrastructure-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ilonatommy@lewing

[8]ページ先頭

©2009-2025 Movatter.jp