Movatterモバイル変換

Copy link

ghost commentedJul 2, 2024

Note regarding thenew-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment

Copy link

ghost commentedJul 2, 2024

Note regarding thenew-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

eiriktsarpalis requested review fromSteveSandersonMS andstephentoub

July 2, 2024 20:29

dotnet-policy-servicebot assignedeiriktsarpalis

Copy link

Contributor

dotnet-policy-servicebot commentedJul 2, 2024

Tagging subscribers to this area: @dotnet/area-system-text-json,@gregsdennis
See info inarea-owners.md if you want to be subscribed.

eiriktsarpalis requested a review fromjozkee

July 2, 2024 20:30

eiriktsarpalis added this to the9.0.0 milestone

eiriktsarpalis commented

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonConverterOfT.ReadCore.csShow resolvedHide resolved

eiriktsarpalis commented

System.IO.Net5Compat.Tests and System.IO.Tests suddenly exiting with error 137#100558

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonConverterOfT.ReadCore.csShow resolvedHide resolved

This was referencedJul 3, 2024

Open

Build failure: Static graph-based restore failed with exit code .* but did not log an error.#103526

Open

Build failure: Static graph-based restore failed with exit code .* but did not log an error.dotnet/dnceng#3139

Closed

stephentoub approved these changes

Jul 3, 2024

ExplicitConversion_FromSingle failing due to NaN != NaN#103347

src/libraries/System.Text.Json/src/System/Text/Json/Reader/JsonReaderOptions.cs OutdatedShow resolvedHide resolved

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializer.Read.Stream.cs OutdatedShow resolvedHide resolved

...s/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonTypeInfoOfT.ReadHelper.csShow resolvedHide resolved

eiriktsarpalisand others added3 commits

July 3, 2024 23:31

Update src/libraries/System.Text.Json/src/System/Text/Json/Reader/Jso…

903a919

…nReaderOptions.csCo-authored-by: Stephen Toub <stoub@microsoft.com>

Update src/libraries/System.Text.Json/src/System/Text/Json/Serializat…

1f19017

…ion/JsonSerializer.Read.Stream.csCo-authored-by: Stephen Toub <stoub@microsoft.com>

Address feedback

917597a

This was referencedJul 4, 2024

Open

ProcessThreadTests.TestStartTimeProperty failed in CI#103448

Closed

eiriktsarpalis commented

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializer.Read.Stream.cs OutdatedShow resolvedHide resolved

Update src/libraries/System.Text.Json/src/System/Text/Json/Serializat…

ccb5694

…ion/JsonSerializer.Read.Stream.cs

eiriktsarpalis commented

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializer.Read.Stream.cs OutdatedShow resolvedHide resolved

Update src/libraries/System.Text.Json/src/System/Text/Json/Serializat…

5d6f7fd

…ion/JsonSerializer.Read.Stream.cs

SteveSandersonMS reviewed

src/libraries/System.Text.Json/tests/System.Text.Json.Tests/JsonElementParseTests.csShow resolvedHide resolved

eiriktsarpalis added2 commits

July 4, 2024 11:10

Update DOM tests to demonstrate chained root-value parsing.

416810a

Add another assertion

18c0b62

build-analysisbot mentioned this pull request

The Operation will be canceled. The next steps may not contain expected logs.dotnet/dnceng#3008

Open

3 tasks

build-analysisbot mentioned this pull request

The job running on agent NetCore-Public ran longer than the maximum time#104044

Closed

eiriktsarpalis merged commit3bad19f intodotnet:main