Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Bring back JIT support for core Vector64/128/256/512 APIs#103177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tannergooding merged 1 commit intodotnet:mainfromtannergooding:proto-102275
Jun 12, 2024

Conversation

@tannergooding
Copy link
Member

@tannergoodingtannergooding commentedJun 7, 2024•
edited
Loading

As per the discussion in#103150, the basic building blocks (Vector64/128/256/512<T> andVector<T>) should stay intrinsic in the JIT.

This doesn't bring back "all" APIs, but rather the core ones that are expected to see the heaviest usage. In general, the rule I followed on deciding what to bring back vs not was that if it was a general API that was a 1-to-1 forward to another intrinsic and didn't get any other specialization it was fine to leave in managed

So while it brings back ones likeget_Zero andAs, it doesn't bring backAnd (forwards toop_BitwiseAddition),Add (forwards toop_Addition), orLoad (forwards toLoadUnsafe).

As per the discussion,Vector2,Vector3,Vector4,Quaternion, andPlane remain implemented in managed.

@ghostghost added the area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labelJun 7, 2024
@tannergooding
Copy link
MemberAuthor

CC.@jkotas

@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area:@JulieLeeMSFT,@jakobbotsch
See info inarea-owners.md if you want to be subscribed.

Copy link
Member

@jkotasjkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. (Somebody from the JIT team should signoff as well.)

@tannergooding
Copy link
MemberAuthor

(Pushed to the wrong branch by accident, it's back to how it was at last approval)

@tannergooding
Copy link
MemberAuthor

(Somebody from the JIT team should signoff as well.)

CC.@EgorBo, since you've reviewed the other PRs

@tannergoodingtannergooding merged commit4078743 intodotnet:mainJun 12, 2024
@tannergoodingtannergooding deleted the proto-102275 branchJune 12, 2024 06:40
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJul 12, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@EgorBoEgorBoEgorBo approved these changes

@jkotasjkotasjkotas approved these changes

Assignees

@tannergoodingtannergooding

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tannergooding@EgorBo@jkotas
[8]ページ先頭
©2009-2025 Movatter.jp