Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Don't needlessly track the method handle for hwintrinsics when optimizations are disabled#102973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
TIHan merged 1 commit intodotnet:mainfromtannergooding:rationalize-hwintrinsic
Jun 3, 2024
Merged
Show file tree
Hide file tree
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Don't needlessly track the method handle for hwintrinsics when optimi…
…zations are disabled
  • Loading branch information
@tannergooding
tannergooding committedJun 2, 2024
commitcee764f3f3781c7ca16c9d81603a66cc0cfceded
12 changes: 12 additions & 0 deletionssrc/coreclr/jit/hwintrinsic.cpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -1312,6 +1312,12 @@ GenTree* Compiler::impHWIntrinsic(NamedIntrinsic intrinsic,
{
return impNonConstFallback(intrinsic, retType, simdBaseJitType);
}
else if (!opts.OptimizationEnabled())
{
// Only enable late stage rewriting if optimizations are enabled
// as we won't otherwise encounter a constant at the later point
return nullptr;
}
else
{
setMethodHandle = true;
Expand DownExpand Up@@ -1343,6 +1349,12 @@ GenTree* Compiler::impHWIntrinsic(NamedIntrinsic intrinsic,
{
return impNonConstFallback(intrinsic, retType, simdBaseJitType);
}
else if (!opts.OptimizationEnabled())
{
// Only enable late stage rewriting if optimizations are enabled
// as we won't otherwise encounter a constant at the later point
return nullptr;
}
else
{
setMethodHandle = true;
Expand Down
14 changes: 14 additions & 0 deletionssrc/coreclr/jit/hwintrinsicarm64.cpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -1877,6 +1877,13 @@ GenTree* Compiler::impSpecialIntrinsic(NamedIntrinsic intrinsic,
{
assert(sig->numArgs == 2);

if (!opts.OptimizationEnabled())
{
// Only enable late stage rewriting if optimizations are enabled
// as we won't otherwise encounter a constant at the later point
return nullptr;
}

op2 = impSIMDPopStack();
op1 = impSIMDPopStack();

Expand DownExpand Up@@ -2215,6 +2222,13 @@ GenTree* Compiler::impSpecialIntrinsic(NamedIntrinsic intrinsic,

if (!indexOp->OperIsConst())
{
if (!opts.OptimizationEnabled())
{
// Only enable late stage rewriting if optimizations are enabled
// as we won't otherwise encounter a constant at the later point
return nullptr;
}

op3 = impPopStack().val;
op2 = impPopStack().val;
op1 = impSIMDPopStack();
Expand Down
14 changes: 14 additions & 0 deletionssrc/coreclr/jit/hwintrinsicxarch.cpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2903,6 +2903,13 @@ GenTree* Compiler::impSpecialIntrinsic(NamedIntrinsic intrinsic,
{
assert(sig->numArgs == 2);

if (!opts.OptimizationEnabled())
{
// Only enable late stage rewriting if optimizations are enabled
// as we won't otherwise encounter a constant at the later point
return nullptr;
}

op2 = impSIMDPopStack();
op1 = impSIMDPopStack();

Expand DownExpand Up@@ -3215,6 +3222,13 @@ GenTree* Compiler::impSpecialIntrinsic(NamedIntrinsic intrinsic,

if (!indexOp->OperIsConst())
{
if (!opts.OptimizationEnabled())
{
// Only enable late stage rewriting if optimizations are enabled
// as we won't otherwise encounter a constant at the later point
return nullptr;
}

op3 = impPopStack().val;
op2 = impPopStack().val;
op1 = impSIMDPopStack();
Expand Down
[8]ページ先頭
©2009-2025 Movatter.jp