Since Roslyn just lowers the extension methods to a call to the static method there's no reason we shouldn't support creating extension methods that are alsoLibraryImport methods. This adds theIsExplicitThis property toTypePositionInfo and copiesthis to the generated signature if it istrue.

Propagate the 'this' keyword in LibraryImports if present

d618d8b

jtschuster requested review fromAaronRobinsonMSFT andjkoritzinsky

May 29, 2024 00:40

ghost added the area-System.Runtime.InteropServices label

May 29, 2024

dotnet-policy-servicebot assignedjtschuster

May 29, 2024

Copy link

Contributor

dotnet-policy-servicebot commentedMay 29, 2024

Tagging subscribers to this area: @dotnet/interop-contrib
See info inarea-owners.md if you want to be subscribed.

jkoritzinsky approved these changes

May 29, 2024

View reviewed changes

formatting and remove extra method

1207be4

AaronRobinsonMSFT reviewed

May 29, 2024

View reviewed changes

...time.InteropServices/gen/Microsoft.Interop.SourceGeneration/Marshalling/MarshallerHelpers.csShow resolvedHide resolved

AaronRobinsonMSFT approved these changes

May 29, 2024

View reviewed changes

build-analysisbot mentioned this pull request

May 29, 2024

System.Runtime.Loader.Tests.AssemblyLoadContextTest.Unload_CollectibleWithTwoAssemblies [FAIL]#100295

Closed

Update src/libraries/System.Runtime.InteropServices/gen/Microsoft.Int…

da5c86c

…erop.SourceGeneration/Marshalling/MarshallerHelpers.csCo-authored-by: Aaron Robinson <arobins@microsoft.com>

This was referencedMay 30, 2024

Test failure: Unknown chain building error in System.Net.Security.CertificateValidationRemoteServer.ConnectWithRevocation_WithCallback#101835

Closed

[browser][MT] System.Net.Http.Functional.Tests.WorkItemExecution timeout#102385

Closed

[browser][MT] Tests timed out#102559

Closed

jtschuster merged commit36a85b0 intodotnet:main

May 30, 2024

Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request

May 30, 2024

Propagate the 'this' keyword in LibraryImports (dotnet#102793)

030fad9

Since Roslyn just lowers the extension methods to a call to the static method there's no reason we shouldn't support creating extension methods that are also LibraryImport methods. This adds the IsExplicitThis property to TypePositionInfo and copies this to the generated signature if it is true.