NotificationsYou must be signed in to change notification settings
Fork5.1k
Star16.6k

Use stackalloc char&byte arrays for decoding Url values in HttpUtiliy.ParseQueryString#102745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

MihaZupan merged 3 commits intodotnet:mainfromTrayanZapryanov:optimize_url_decoder

May 29, 2024

Merged

Use stackalloc char&byte arrays for decoding Url values in HttpUtiliy.ParseQueryString#102745

MihaZupan merged 3 commits intodotnet:mainfromTrayanZapryanov:optimize_url_decoder

May 29, 2024

Conversation

Copy link

Contributor

TrayanZapryanov commentedMay 28, 2024

Convert UrlDecoder to ref struct
If Url is less than 256 characters, do no allocate char&byte arrays
Replace substring operation with Span

Use stackalloc char&byte arrays for decoding Url values in HttpUtilit…

702e188

…y.ParseQueryString

ghost added the area-System.Net label

May 28, 2024

dotnet-policy-servicebot added the community-contributionIndicates that the PR has been added by a community member label

May 28, 2024

Copy link

Contributor

dotnet-policy-servicebot commentedMay 28, 2024

Tagging subscribers to this area: @dotnet/ncl
See info inarea-owners.md if you want to be subscribed.

Tornhoof reviewed

May 28, 2024

View reviewed changes

src/libraries/System.Web.HttpUtility/src/System/Web/Util/HttpEncoder.cs OutdatedShow resolvedHide resolved

Copy link

ContributorAuthor

TrayanZapryanov commentedMay 28, 2024•
edited
Loading

Benchmark:

[MemoryDiagnoser]publicclassHttpUtilityBenchmarks{privatestaticstringUnicodeStr=>newstring(new[]{'\u304a','\u75b2','\u308c','\u69d8','\u3067','\u3059'});privatestaticstringEncodedUnicodeStr=>HttpUtility.UrlEncode(UnicodeStr)+"="+HttpUtility.UrlEncode(UnicodeStr);[Benchmark(Baseline=true)]publicNameValueCollectionParseQueryString()=>HttpUtility.ParseQueryString("https://portal.azure.com/#@testgroup.onmicrosoft.com/dashboard/arm/subscriptions/111111-abac-4067-81ba-5ae054d891b5/"+"resourcegroups/dashboards/providers/microsoft.portal/dashboards/3456268-8630-60f7-aaac-eca38aca231");[Benchmark]publicNameValueCollectionParseQueryString_Mix()=>HttpUtility.ParseQueryString("ReturnUrl=http%3a%2f%2flocalhost%2flogin%2fauthenticate%3fReturnUrl%3dhttp%3a%2f%2flocalhost%2fsecured_area%26__provider__%3dgoogle");[Benchmark]publicNameValueCollectionParseQueryString_Unicode()=>HttpUtility.ParseQueryString(EncodedUnicodeStr);}

Results:
Machine:
BenchmarkDotNet v0.13.12, Windows 11 (10.0.22631.3593/23H2/2023Update/SunValley3)
11th Gen Intel Core i9-11900K 3.50GHz, 1 CPU, 16 logical and 8 physical cores
.NET SDK 9.0.100-preview.4.24267.66
[Host] : .NET 8.0.5 (8.0.524.21615), X64 RyuJIT AVX-512F+CD+BW+DQ+VL+VBMI
DefaultJob : .NET 8.0.5 (8.0.524.21615), X64 RyuJIT AVX-512F+CD+BW+DQ+VL+VBMI

Before:

Method	Mean	Error	StdDev	Ratio	RatioSD	Gen0	Gen1	Allocated	Alloc Ratio
ParseQueryString	516.0 ns	7.83 ns	6.94 ns	1.00	0.00	0.1955	-	1.6 KB	1.00
ParseQueryString_Mix	429.1 ns	5.26 ns	4.92 ns	0.83	0.01	0.1931	0.0005	1.58 KB	0.99
ParseQueryString_Unicode	691.2 ns	10.41 ns	9.74 ns	1.34	0.03	0.2689	-	2.2 KB	1.38

PR:

Method	Mean	Error	StdDev	Ratio	RatioSD	Gen0	Allocated	Alloc Ratio
ParseQueryString	489.3 ns	4.92 ns	4.36 ns	1.00	0.00	0.1059	888 B	1.00
ParseQueryString_Mix	338.7 ns	2.76 ns	2.45 ns	0.69	0.01	0.0820	688 B	0.77
ParseQueryString_Unicode	656.1 ns	7.01 ns	6.22 ns	1.34	0.02	0.1717	1440 B	1.62