Theis_inflated appears redundant sinceaccessor_method is already passed to theemit_unsafe_accessor_[field/ctor/method]_wrapper function.

Canaccessor_method->is_inflated be used directly instead of theis_inflated variable? The idea is to make the wrapper inflated if the accessor method is inflated and removegboolean to_be_inflated.

It's not redundant. Note that below on line 5272 we reassignaccessor_method to be the declaring method. So we would have to switch fromaccessor_method->is_inflated toorig_method->is_inflated in this function. And down inemit_unsafe_accessor_wrapper we don't haveorig_method available.

Honestly what I would prefer is to makeemit_unsafe_accessor_wrapper not to take anaccessor_method argument at all. We can figure out the target class from the signature, and if we need to inflate the target method we can figure that out from the generic context. But there's other (mostly error checking) stuff that we can only get fromaccessor_method: like whether it's static.

But there's a good point here: I always just need to knowgboolean inflate_generic_data = accessor_method->is_generic || is_inflated inemit_unsafe_accessor_{ctor/method/field}_wrapper. So I will update marshal.c to just pass that down, instead of computing it in three different places.

Why only the method context is set here? What about the class context?

So conceptually if both the class is generic and thestatic extern accessor method is generic, when we make a wrapper we want its signature to use the same exact class gparams as the accessor method (conceptually both the accessor method and the wrapper are members of the class). But we want it to use its own brand new method gparams. So we take the original signature of hte access method and replace the method gparams:

classG<T>{publicstaticexternTuple<T,U>Accessor<U>(Tt,Uu);// wrapper:// public static extern Tuple<T, U2> wrapper_Accessor<U2>(T t, U2 u);}

so it's as if the wrapper instead of having a gparam namedU has a gparam namedU2. And so if we just take signature of the accessor, we have to replace allUs byU2. But theT is the same