- Notifications
You must be signed in to change notification settings - Fork5.2k
[mono] UnsafeAccessor: Enable tests for extern static methods without type parameters#101265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Tagging subscribers to this area:@steveisok,@lambdageek |
Uh oh!
There was an error while loading.Please reload this page.
fanyang-mono commentedApr 22, 2024
All CI failures are known. |
| for (inti=1;i<ret->param_count;i++) | ||
| ret->params [i-1]=ret->params [i]; | ||
| memset (&ret->params[ret->param_count-1],0,sizeof (MonoType));// just in case | ||
| memset (&ret->params[ret->param_count-1],0,sizeof (MonoType*));// just in case |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Let's keep this in mind if we need to do a net8.0 backport of any unsafe accessor fixes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yeah, make sense.
… type parameters (dotnet#101265)* Enable tests for methods without type parameters* Enable more field tests* Enable all field tests* Fix the type to get size for
Contributes to#99830