NotificationsYou must be signed in to change notification settings
Fork5.2k
Star17.2k

Update SDK to preview 3 release#100945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

ViktorHofer merged 5 commits intomainfromMichalStrehovsky-patch-1

Apr 15, 2024

Merged

Update SDK to preview 3 release#100945

ViktorHofer merged 5 commits intomainfromMichalStrehovsky-patch-1

Apr 15, 2024

Conversation

Copy link

Member

MichalStrehovsky commentedApr 12, 2024

No description provided.

MichalStrehovsky added2 commits

April 12, 2024 07:57

Update global.json

b5e6f9a

Update blazor.csproj

e9a565c

MichalStrehovsky requested review fromlewing andpavelsavara ascode owners

April 12, 2024 06:01

ghost added the needs-area-labelAn area label is needed to ensure this gets routed to the appropriate area owners label

Apr 12, 2024

dotnet-policy-servicebot assignedMichalStrehovsky

Apr 12, 2024

MichalStrehovsky added2 commits

April 12, 2024 09:17

Delete uselessRuntimeIdentifiers

173fb1e

Fix up illinker tests

723e8cd

MichalStrehovsky requested a review frommarek-safar as acode owner

April 12, 2024 07:17

MichalStrehovsky requested review fromViktorHofer andakoeplinger

April 12, 2024 09:17

MichalStrehovsky added area-Infrastructure and removed needs-area-labelAn area label is needed to ensure this gets routed to the appropriate area owners labels

Apr 12, 2024

This was referencedApr 12, 2024

[wasm]Assertion: should not be reached at D:/a/_work/1/s/src/mono/mono/sgen/sgen-scan-object.h:93 inSystem.Reflection.Tests#95805

Closed

[browser][MT] TIMED_OUT but 0 was expected#99888

Closed

[browser]Process terminated assert handling at icall.c:6162#100249

Closed

System.IO.Net5Compat.Tests and System.IO.Tests suddenly exiting with error 137#100558

Closed

System.Text.RegularExpressions.Tests on Mono_Minijit_Debug-Ubuntu#100715

Closed

[browser][MT] fail in System.Reflection.RuntimeMethodInfo.InternalInvoke#100831

Closed

akoeplinger approved these changes

Apr 15, 2024

View reviewed changes

Fix two more preview1 versions

a97c366

MichalStrehovsky requested review fromilonatommy andmaraf ascode owners

April 15, 2024 09:00

akoeplinger approved these changes

Apr 15, 2024

View reviewed changes

ViktorHofer reviewed

Apr 15, 2024

View reviewed changes

src/mono/sample/wasm/blazor-frame/blazor.csproj

Comment on lines +14 to +15

		<PackageReferenceInclude="Microsoft.AspNetCore.Components.WebAssembly"Version="9.0.0-preview.3.24172.13" />
		<PackageReferenceInclude="Microsoft.AspNetCore.Components.WebAssembly.DevServer"Version="9.0.0-preview.3.24172.13"PrivateAssets="all" />

Copy link

Member

ViktorHoferApr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Do we have an issue that tracks removing these hardcodes?

Copy link

MemberAuthor

MichalStrehovskyApr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Do we have an issue that tracks removing these hardcodes?

Might want to ask that@radekdoulik @maraf @pavelsavara who were involved in the PR that introduced it; looks like this has been causing extra work when bumping the SDK since 8.0 RC1.

ViktorHofer approved these changes

Apr 15, 2024

View reviewed changes

MichalStrehovsky mentioned this pull request

Apr 15, 2024

Sigsegv in dotnet/msbuild when building repo#101049

Closed

MichalStrehovsky added the NO-MERGEThe PR is not ready for merge yet (see discussion for detailed reasons) label

Apr 15, 2024

Copy link

MemberAuthor

MichalStrehovsky commentedApr 15, 2024

Looks like the new run is hitting a hard crash in the runtime on osx-x64. I doubt it was caused by the latest commit, so this is one of those fun non-deterministic crashes in MSBuild:

2024-04-15T09:34:59.7728930Z     /Users/runner/work/1/s/dotnet.sh: line 27: 91742 Segmentation fault: 11  ${dotnetPath} "$@"2024-04-15T09:34:59.8872770Z /Users/runner/work/1/s/src/tests/JIT/HardwareIntrinsics/Arm/Directory.Build.targets(15,5): error MSB3073: The command ""/Users/runner/work/1/s/dotnet.sh" build /Users/runner/work/1/s//src/tests/Common/GenerateHWIntrinsicTests/GenerateHWIntrinsicTests_Arm.csproj -c Release --no-restore /p:IntermediateOutputPath=/Users/runner/work/1/s/artifacts/tests/coreclr/obj/osx.x64.Release/Managed/JIT/HardwareIntrinsics/Arm/Sve/Sve_r//GenerateHWIntrinsicTests/ /p:OutputPath=/Users/runner/work/1/s/artifacts/tests/coreclr/osx.x64.Release/JIT/HardwareIntrinsics/Arm/Sve/Sve_r//GenerateHWIntrinsicTests/" exited with code 139. [/Users/runner/work/1/s/src/tests/JIT/HardwareIntrinsics/Arm/Sve/Sve_r.csproj] [/Users/runner/work/1/s/src/tests/build.proj]

I guess this is now NO-MERGE/blocked. Filed#101049.

build-analysisbot mentioned this pull request

Apr 15, 2024

"We stopped hearing from agent Azure Pipelines 32. Verify the agent machine is running and has a healthy network connection"dotnet/dnceng#1886

Open

3 tasks

Copy link

Member

akoeplinger commentedApr 15, 2024•
edited
Loading

Doesn't seem related given we found more hits in older releases in#101049 so I triggered a rerun.

Copy link

Member

am11 commentedApr 15, 2024

All green after the rerun. :shipit:

ViktorHofer merged commitdd7c82e intomain

Apr 15, 2024

ViktorHofer deleted the MichalStrehovsky-patch-1 branch

April 15, 2024 16:08

matouskozak pushed a commit to matouskozak/runtime that referenced this pull request

Apr 30, 2024

Update SDK to preview 3 release (dotnet#100945)

16b13e7

* Update global.json* Update blazor.csproj* Delete useless `RuntimeIdentifiers`* Fix up illinker tests* Fix two more preview1 versions---------Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>