- Notifications
You must be signed in to change notification settings - Fork5.2k
[cdac] cdac-build-tool#100650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
[cdac] cdac-build-tool#100650
Changes from1 commit
Commits
Show all changes
67 commits Select commitHold shift + click to select a range
8518e9f checkpoint
lambdageek12aef6d add old tooling notes
lambdageek1eff4d0 add an emitter
lambdageek22e217b checkpoint read in the directory header
lambdageekdd9279d checkpoint plausible-looking offsets
lambdageek492af29 checkpoint: field stuff is working
lambdageek459d124 checkpoint json
lambdageek28f8256 contract parsing
lambdageek418739d refactor
lambdageek1c1524d indirect pointer value support
lambdageek34e852e move sample to tool dir
lambdageeke48e709 Take baselines from the docs/design/datacontracts/data dir
lambdageek0e8c60e Add README
lambdageekcd4f0f0 fix BE
lambdageekb6b079e hook up cdac-build-tool to the coreclr build; export DotNetRuntimeCon…
lambdageeka9b0d7f try fix win-x86 build warning
lambdageekdbf0557 paths
lambdageek74433f1 vebose
lambdageekea441b6 fix typo; fixes win32
lambdageek787b836 cleanup; add contracts.txt
lambdageeke015e83 add diagram to README
lambdageek0354723 move implementation notes
lambdageekda038f3 better verbose output from ObjectFileScraper
lambdageekf64b548 turn off whole program optimizations for data-descriptor.obj
lambdageek2e29a10 C++-ify and add real Thread offsets
lambdageek58162a3 no C99 designated initializers in C++ until C++20
lambdageek4bb51bf build data descriptor after core runtime
lambdageek9700e29 fix gcc build
lambdageek3f22c7c fix typo
lambdageek4aae511 simplify ObjectFileScraper
lambdageek60738ef more dependencies
lambdageekc0dab90 try fix source build
lambdageek84eaa3b remove fixme; document
lambdageek86e5258 Merge commit 'origin/main^' into cdac-contract-tool
lambdageekcc658c9 invoke 'dotnet cmake-build-tool.dll' instead of 'dotnet run --project'
lambdageek39fe70d clean up macro boilerplate
lambdageek5064deb platform flags
lambdageek74000bc turn off verbose output
lambdageek76c27bc can't use constexpr function in coreclr
lambdageek270fe21 Code review fixups
lambdageek84e0800 Rename "aux data" to "pointer data"
lambdageek51da4e3 rename "data-descriptor" to "datadescriptor"
lambdageekb26f3ac simplify linking
lambdageek8f9d1a7 cdac-build-tool don't build dotnet tool; turn on analyzers
lambdageek87b79b3 update README
lambdageekb33ad07 rationalize naming; update docs; add some inline comments
lambdageekc39e6f4 rm whitespace
lambdageek5ef8428 renamce cdac.h to cdacoffsets.h
lambdageek9f381be comments
lambdageek443f83b fixup README
lambdageek9fc2b26 hex offsets; improved formatting
lambdageek024c566 don't throw in ParseContracts; add line numbers to errors
lambdageekb0f1f40 spelling
lambdageek2852d8d Update README.md
lambdageek2429bd8 change input format for contracts to jsonc
lambdageek18a863e add custom JsonConverter instances for the compact json representation
lambdageeka49e5e6 code review changes
lambdageek1f5ba44 inline comments into the data-descriptor-blob C code
lambdageek2decea4 cleanup
lambdageekce18bee comments and markdown
lambdageeke143998 Apply suggestions from code review
lambdageek08cf75d simplify; bug fix - PointerDataCount include placeholder
lambdageek0d4d40d fixup docs
lambdageek94c56ea Merge remote-tracking branch 'origin/main' into cdac-contract-tool
lambdageek3d49b70 Update src/coreclr/tools/cdac-build-tool/JsonConverter/GlobalModelJso…
lambdageekf845c41 one more set of feedback changes
lambdageek64430cf maybe no live ILLink ?
lambdageekFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
cleanup; add contracts.txt
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit787b8360305f036627e0d40eaccca437101c8d2b
There are no files selected for viewing
27 changes: 14 additions & 13 deletionssrc/coreclr/debug/runtimeinfo/CMakeLists.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletionssrc/coreclr/debug/runtimeinfo/contracts.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| # algorithmic contracts for coreclr | ||
| # The format of this file is: | ||
lambdageek marked this conversation as resolved. OutdatedShow resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| # # comment | ||
| # CONTRACT NAME, VERSION #optional trailing comment | ||
| # | ||
| # CONTRACT NAME is an arbitrary string, VERSION is an integer | ||
| # | ||
| # cdac-build-tool can take multiple "-c contract_file" arguments | ||
| # so to conditionally include contracts, put optional contracts in a separate file | ||
| SOSBreakingChangeVersion, 1 # example contract: runtime exports an SOS breaking change version global | ||
10 changes: 4 additions & 6 deletionssrc/coreclr/dlls/mscoree/coreclr/CMakeLists.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.