- Notifications
You must be signed in to change notification settings - Fork5.2k
Config generator emits lambdas for error path that force allocation on success path#100257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
...n.Binder/tests/SourceGenerationTests/Baselines/net462/ConfigurationBinder/Bind.generated.txtShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Member
tarekgh commentedMay 13, 2024
Member
tarekgh commentedMay 13, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@pedrobsaila thanks for submitting the PR. Could you please address the comment#100257 (comment)? |
tarekgh approved these changesMay 13, 2024
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull requestMay 30, 2024
…n success path (dotnet#100257)* first draft* fix failing tests* delete no more used Identifier.getPath---------Co-authored-by: Eirik Tsarpalis <eirik.tsarpalis@gmail.com>Co-authored-by: Tarek Mahmoud Sayed <tarekms@microsoft.com>
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
area-Extensions-Configurationcommunity-contributionIndicates that the PR has been added by a community member source-generatorIndicates an issue with a source generator feature
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#90971