Movatterモバイル変換

Skip to content

dotnet/runtimePublic

NotificationsYou must be signed in to change notification settings
Fork5.2k
Star17.2k

Seal overridden virtual method`SetDefaultFallbacks`#100030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

stephentoub merged 1 commit intodotnet:mainfromxtqqczze:SetDefaultFallbacks

Jul 1, 2024

Merged

Seal overridden virtual method`SetDefaultFallbacks`#100030

stephentoub merged 1 commit intodotnet:mainfromxtqqczze:SetDefaultFallbacks

Jul 1, 2024

Conversation

@xtqqczze

Copy link

Contributor

xtqqczze commentedMar 20, 2024•
edited
Loading

FixCA2214: Do not call overridable methods in constructors.

@ghost

ghost added the area-System.Text.Encoding label

@dotnet-policy-service

dotnet-policy-servicebot added the community-contributionIndicates that the PR has been added by a community member label

This was referencedMar 21, 2024

Assert failure(PID 13812 [0x000035f4], Thread: 14128 [0x3730]): promoted_bytes (heap_number) == promoted#100035

Closed

System.Net.Http.Functional.Tests.HttpMetricsTest_Http11_Async_HttpMessageInvoker Test failure#96407

Closed

GC\Regressions\v2.0-beta2\452950\452950\452950.cmd failing on Mono minijit Windows x64#99729

Closed

Failure in GC\API\NoGCRegion\Callback_Svr\Callback_Svr.cmd#100149

Closed

at GC_Regressions._v2_0_beta2_452950_452950_452950_._v2_0_beta2_452950_452950_452950_cmd()#100174

Closed

[browser][MT] TIMED_OUT but 0 was expected#99888

Closed

@build-analysis

build-analysisbot mentioned this pull request

System.Runtime.InteropServices.JavaScript.Tests.JSImportTest.MissingImport test fails on CI leg: browser-wasm linux Release LibraryTests_Threading#100421

Closed

This was referencedApr 6, 2024

System.Text.RegularExpressions.Tests on Mono_Minijit_Debug-Ubuntu#100715

Closed

ReadAsStreamAsync_HandlerProducesWellBehavedResponseStream test failure on release coreclr windows x64 Debug CI leg#97259

Closed

[browser]Process terminated assert handling at icall.c:6162#100249

Closed

System.IO.Net5Compat.Tests and System.IO.Tests suddenly exiting with error 137#100558

Closed

[HTTP/3] System.Net.Quic.QuicException: The connection timed out from inactivity#94507

Closed

This was referencedApr 19, 2024

CI error: System.Net.Quic.QuicException: The connection timed out from inactivity#91757

Closed

[wasm] System.Text.Json.Tests running out of memory#98578

Closed

Timeout in System.Text.Json.Tests.Utf8JsonWriterTests.WriteNumbers#101193

Closed

STATUS_UNSUCCESSFUL in RsaCryptRoundtrip_OaepSHA1#29683

Open

[Test Failure] SocketsHttpHandlerTest_Cookies_Http3.GetAsync_SetCookieContainerAndCookieHeader_BothCookiesSent#101377

Closed

This was referencedMay 1, 2024

[WASI][AOT] LLVM ERROR: out of memory#101533

Closed

[wasm][firefox] crit: OpenQA.Selenium.WebDriverException: Failed to decode response from marionette#101617

Open

System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanScalarDestination_SpecialValues fails#101721

Closed

@xtqqczze

Copy link

ContributorAuthor

xtqqczze commentedMay 2, 2024

Build Analysis is green.

@stephentoub

Copy link

Member

stephentoub commentedMay 3, 2024

Thanks, but what does this improve?

@stephentoub

stephentoub added the needs-author-actionAn issue or pull request that requires more info or actions from the author. label

@xtqqczze

Copy link

ContributorAuthor

xtqqczze commentedMay 25, 2024•
edited
Loading

Thanks, but what does this improve?

SetDefaultFallbacks is sealed inASCIIEncoding,UTF7Encoding,UTF8Encoding,UnicodeEncoding. This change provides for consistency with these classes and clarifies that the method is not intended to be overridden.

@dotnet-policy-service

dotnet-policy-servicebot removed the needs-author-actionAn issue or pull request that requires more info or actions from the author. label

@xtqqczze

Copy link

ContributorAuthor

xtqqczze commentedMay 25, 2024

@MihuBot

MihuBot mentioned this pull request

[X64] [xtqqczze] Seal overridden virtual methodSetDefaultFallbacksMihuBot/runtime-utils#386

Open

@xtqqczze

Copy link

ContributorAuthor

xtqqczze commentedMay 25, 2024

This change enables inlining ofSetDefaultFallbacks into the ctor:

MihuBot/runtime-utils#386 (comment)

@xtqqczze

Seal overridden virtual methodSetDefaultFallbacks

c3fbca4

Fix CA2214

@xtqqczze

xtqqczze force-pushed theSetDefaultFallbacks branch from4752b20 toc3fbca4Compare

June 11, 2024 11:16

This was referencedJun 11, 2024

Dead lettering tests#101524

Closed

NativeAOT legs timing out in CI#102239

Closed

The Operation will be canceled. The next steps may not contain expected logs.dotnet/dnceng#3008

Open

stephentoub

stephentoub approved these changes

View reviewed changes

@stephentoub

Copy link

Member

stephentoub commentedJun 23, 2024

Thanks, but what does this improve?
SetDefaultFallbacks is sealed inASCIIEncoding,UTF7Encoding,UTF8Encoding,UnicodeEncoding. This change provides for consistency with these classes and clarifies that the method is not intended to be overridden.

That's fair. Thanks

@stephentoub

stephentoub closed this

@stephentoub

stephentoub reopened this

This was referencedJun 23, 2024

Failed USB connection via port 54050, error 61, in tvOS arm64 Release AllSubsets_Mono#82637

Closed

GC/Regressions/v2.0-beta2/452950 failed in CI#103494

Closed

The "RestoreTask" task returned false but did not log an errordotnet/dnceng#3100

Closed

@stephentoub

stephentoub merged commit9cc0e75 intodotnet:main

@xtqqczze

xtqqczze deleted the SetDefaultFallbacks branch

July 2, 2024 10:47

@github-actions

github-actionsbot locked and limited conversation to collaborators

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Labels

area-System.Text.Encoding community-contribution

Indicates that the PR has been added by a community member

2 participants

@xtqqczze

@stephentoub

[8]ページ先頭

©2009-2025 Movatter.jp