- Notifications
You must be signed in to change notification settings - Fork5.2k
Comparing changes
Open a pull request
base repository:dotnet/runtime
Uh oh!
There was an error while loading.Please reload this page.
base:5ef2a9bf5c
head repository:dotnet/runtime
Uh oh!
There was an error while loading.Please reload this page.
compare:940b332ad0
- 16commits
- 97files changed
- 13contributors
Commits on Aug 18, 2023
* Now checks all assemblies in the output directory rather than just `test.exe`* Once again respects the the ability to skip verifying a single assembly via `[SkipIlVerify("foo.dll")]`* Now loads core libraries from the output directory (if they exist) instead of from the runtime install dir.* ALC logic was removed. I do not understand what value this provided.* The class libraries lead to a lot of errors. Rather than having to filter out a large number of errors, I added diff'ing. ILVerify will check the input assembly and remove any errors that existed in the input assembly. This makes verifying class libraries viable. Without it, you'd have to use `[SkipIlverify]` on every core link test or filter out a lot of `VerifierError` values.* Moved IL verification back to `InitialChecking` where `PeVerifier` was* Add a test to verify that il verification is mostly working. It doesn't give complete coverage over every behavior, but it's better than nothing.* `SkipPeVerify` renamed to `SkipIlVerify`* `SkipPeVerifyForToolchian` was removed. There is only 1 tool now.* Removed `PeVerifier`.* Remove many [SkipIlVerify] attributes. Diffing means they are no longer needed* `ValidateTypeRefsHaveValidAssemblyRefs` now runs regardless of whether or not the IL is verified. It wasn't clear to me why this logic would only be useful when il was verified.* Change `UninitializedLocals` to use `ExpectIlFailure`. This test seems to expect invalid il. Might as well assert that rather than skip ilverify entirely.* Remove the logic that disables ilverify when a test uses the unsafe argument. Diffing makes this obsolete.* IL Verification errors have been greatly improved.** will now output all IL errors in the failure message rather than just the first invalid IL.** Type and Method names are now displayed in the error message. I didn't do an exhaustive implementation, SRM is so tedious to use, but it's better than not having it** Tokens and Offsets are formatted nicely* Extension points opened up for Unity.** We need to supply different search directories.** We need to search for `.winmd` files since we support windows runtime.** In general I opened some things up in case we need to call themmrvoorhe authoredAug 18, 2023 Run ssl&httpstress nightlies against release/8.0 (#90808)
antonfirsov authoredAug 18, 2023 Disable readytorun/GenericCycleDetection/Depth3Test (#90802)
Tracking:#88586
BruceForstall authoredAug 18, 2023 Disable BinderTracingTest.ResolutionFlow test (#90801)
Tracking:#90580
BruceForstall authoredAug 18, 2023 [wasm] Relink for non-unicode tests should be running. (#89419)
* Relink for non-unicode tests should be running.* Revert blocking.* Tests not failing anymore* Clean-up.* Windows has failures, block only them.* Add simple tests for relink and AOT.* Should pass on all platforms.* Typo.* AOT on Windows fails the same as relink.* Optional params do not work on TheoryData.* Revert unintentional.
ilonatommy authoredAug 18, 2023 [wasm] Make chrome version bumps for testing explicit, instead of aut…
…omatic updates to latest (#90772)* [wasm] Remove automatic updates of chrome versions for testingInstead, add a `eng/testing/ChromeVersions.props` that has to be updatedspecifically to bump the chrome version used.* [wasm] Add `eng/testing/bump-chrome-version.proj`.. which can be used to update `ChromeVersions.props` to the lateststable version.* [wasm] Add a github action to open PRs that bump chrome versions* GetChromeVersions: Check for 75 new branch positions to find the snapshot* Update .github/workflows/bump-chrome-version.ymlCo-authored-by: Ilona Tomkowicz <32700855+ilonatommy@users.noreply.github.com>---------Co-authored-by: Ilona Tomkowicz <32700855+ilonatommy@users.noreply.github.com>
Fix SuperPMI assertion call in
MethodContext::recGetHelperFtn()(#9……0778)* Fix SuperPMI assertion call in `MethodContext::recGetHelperFtn()`We can't use string concatenation in an argument to the `AssertCodeMsg`macro, so construct the string we want to print first.* Feedback
BruceForstall authoredAug 18, 2023 Implement IStatefulPinnedMarshalling test marshallers (#90685)
* Implement test interfaces and marshallers and test them
jtschuster authoredAug 18, 2023 [wasm] Fix imports for bump-chrome-version.proj (#90822)
radical authoredAug 18, 2023 Add note about IlcScanReflection to the native aot docs (#90765)
Fixes#90171
jkotas authoredAug 18, 2023 Call SetupNuGetSources for installer jobs (#90756)
Co-authored-by: Matt Mitchell <mmitche@microsoft.com>
Improve linker performance by avoiding IndexOf (#90721)
* Improve linker performance by avoiding IndexOf* Fix typos
Youssef1313 authoredAug 18, 2023 Enable telemetry for WasmStripILAfterAOT (#90820)
fanyang-mono authoredAug 18, 2023 Stop skipping tests in installer pipeline on linux_x64 (#89953)
- Run tests in in installer pipeline on Linux_x64 even though it is cross-build. - Fix uploading of binaries/symbols on failure
elinor-fung authoredAug 18, 2023 Fix win-arm64 native varargs ABI (#90712)
* Fix win-arm64 native varargs ABISIMD vector types should be passed in integer registers.This might require splitting a Vector128 between x7 and stack.* Add more test cases* Update src/tests/JIT/Regression/JitBlue/Runtime_71375/Runtime_71375.csAdd additional varargs arguments after the vectorCo-authored-by: Jan Kotas <jkotas@microsoft.com>---------Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Commits on Aug 19, 2023
[mini] Fix typo in mono_decompose_vtype_opts (#90825)
* Fix typo in mono_decompose_vtype_optsWithout this, if some previous instruction already created a vreg forins->dest (for example if we are doing multiple passes over the basicblock because `restart == TRUE`) we will use an incorrect vreg whendecomposing the current VMOVEFixes#90800* Only emit an OP_LDTOKEN_FIELD if we loaded a field tokenThis is used by a CreateSpan optimization that needs access to theMonoClassField*For other cases of a bare LDTOKEN (such as hand-written IL that callsLDTOKEN on a type but doesn't follow it up with a call to`GetTypeFromHandle` leave the opcode as a VMOVE (from the`EMIT_NEW_TEMPLOAD` above))
lambdageek authoredAug 19, 2023
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:git diff 5ef2a9bf5c...940b332ad0
Uh oh!
There was an error while loading.Please reload this page.