Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit5945ee7

Browse files
Ensure Vector.Create is properly recognized as intrinsic (#108945)
1 parent963e30c commit5945ee7

File tree

4 files changed

+11
-20
lines changed

4 files changed

+11
-20
lines changed

‎src/coreclr/jit/simdashwintrinsic.cpp‎

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -917,6 +917,11 @@ GenTree* Compiler::impSimdAsHWIntrinsicSpecial(NamedIntrinsic intrinsic,
917917
returngtNewSimdCeilNode(retType, op1, simdBaseJitType, simdSize);
918918
}
919919

920+
case NI_VectorT_Create:
921+
{
922+
returngtNewSimdCreateBroadcastNode(simdType, op1, simdBaseJitType, simdSize);
923+
}
924+
920925
case NI_VectorT_Floor:
921926
{
922927
returngtNewSimdFloorNode(retType, op1, simdBaseJitType, simdSize);
@@ -1247,15 +1252,6 @@ GenTree* Compiler::impSimdAsHWIntrinsicSpecial(NamedIntrinsic intrinsic,
12471252
returngtNewSimdBinOpNode(GT_OR, retType, op1, op2, simdBaseJitType, simdSize);
12481253
}
12491254

1250-
case NI_VectorT_Create:
1251-
{
1252-
assert(retType == TYP_VOID);
1253-
1254-
copyBlkDst = op1;
1255-
copyBlkSrc =gtNewSimdCreateBroadcastNode(simdType, op2, simdBaseJitType, simdSize);
1256-
break;
1257-
}
1258-
12591255
case NI_VectorT_CreateSequence:
12601256
{
12611257
returngtNewSimdCreateSequenceNode(simdType, op1, op2, simdBaseJitType, simdSize);

‎src/coreclr/jit/simdashwintrinsiclistarm64.h‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,8 @@ SIMD_AS_HWINTRINSIC_ID(VectorT, ConvertToUInt32,
6464
SIMD_AS_HWINTRINSIC_ID(VectorT,ConvertToUInt32Native,1, {NI_Illegal,NI_Illegal,NI_Illegal,NI_Illegal,NI_Illegal,NI_Illegal,NI_Illegal,NI_Illegal,NI_VectorT_ConvertToUInt32Native,NI_Illegal},SimdAsHWIntrinsicFlag::None)
6565
SIMD_AS_HWINTRINSIC_ID(VectorT,ConvertToUInt64,1, {NI_Illegal,NI_Illegal,NI_Illegal,NI_Illegal,NI_Illegal,NI_Illegal,NI_Illegal,NI_Illegal,NI_Illegal,NI_VectorT_ConvertToUInt64},SimdAsHWIntrinsicFlag::None)
6666
SIMD_AS_HWINTRINSIC_ID(VectorT,ConvertToUInt64Native,1, {NI_Illegal,NI_Illegal,NI_Illegal,NI_Illegal,NI_Illegal,NI_Illegal,NI_Illegal,NI_Illegal,NI_Illegal,NI_VectorT_ConvertToUInt64Native},SimdAsHWIntrinsicFlag::None)
67-
SIMD_AS_HWINTRINSIC_ID(VectorT,Create,1, {NI_VectorT_Create,NI_VectorT_Create,NI_VectorT_Create,NI_VectorT_Create,NI_VectorT_Create,NI_VectorT_Create,NI_VectorT_Create,NI_VectorT_Create,NI_VectorT_Create,NI_VectorT_Create},SimdAsHWIntrinsicFlag::None)
68-
SIMD_AS_HWINTRINSIC_ID(VectorT,CreateSequence,2, {NI_VectorT_CreateSequence,NI_VectorT_CreateSequence,NI_VectorT_CreateSequence,NI_VectorT_CreateSequence,NI_VectorT_CreateSequence,NI_VectorT_CreateSequence,NI_VectorT_CreateSequence,NI_VectorT_CreateSequence,NI_VectorT_CreateSequence,NI_VectorT_CreateSequence},SimdAsHWIntrinsicFlag::SpillSideEffectsOp1)
67+
SIMD_AS_HWINTRINSIC_ID(VectorT,Create,1, {NI_VectorT_Create,NI_VectorT_Create,NI_VectorT_Create,NI_VectorT_Create,NI_VectorT_Create,NI_VectorT_Create,NI_VectorT_Create,NI_VectorT_Create,NI_VectorT_Create,NI_VectorT_Create},SimdAsHWIntrinsicFlag::KeepBaseTypeFromRet)
68+
SIMD_AS_HWINTRINSIC_ID(VectorT,CreateSequence,2, {NI_VectorT_CreateSequence,NI_VectorT_CreateSequence,NI_VectorT_CreateSequence,NI_VectorT_CreateSequence,NI_VectorT_CreateSequence,NI_VectorT_CreateSequence,NI_VectorT_CreateSequence,NI_VectorT_CreateSequence,NI_VectorT_CreateSequence,NI_VectorT_CreateSequence},SimdAsHWIntrinsicFlag::KeepBaseTypeFromRet |SimdAsHWIntrinsicFlag::SpillSideEffectsOp1)
6969
SIMD_AS_HWINTRINSIC_ID(VectorT,Dot,2, {NI_VectorT_Dot,NI_VectorT_Dot,NI_VectorT_Dot,NI_VectorT_Dot,NI_VectorT_Dot,NI_VectorT_Dot,NI_Illegal,NI_Illegal,NI_VectorT_Dot,NI_VectorT_Dot},SimdAsHWIntrinsicFlag::None)
7070
SIMD_AS_HWINTRINSIC_ID(VectorT,Equals,2, {NI_VectorT_Equals,NI_VectorT_Equals,NI_VectorT_Equals,NI_VectorT_Equals,NI_VectorT_Equals,NI_VectorT_Equals,NI_VectorT_Equals,NI_VectorT_Equals,NI_VectorT_Equals,NI_VectorT_Equals},SimdAsHWIntrinsicFlag::None)
7171
SIMD_AS_HWINTRINSIC_ID(VectorT,EqualsAny,2, {NI_VectorT_EqualsAny,NI_VectorT_EqualsAny,NI_VectorT_EqualsAny,NI_VectorT_EqualsAny,NI_VectorT_EqualsAny,NI_VectorT_EqualsAny,NI_VectorT_EqualsAny,NI_VectorT_EqualsAny,NI_VectorT_EqualsAny,NI_VectorT_EqualsAny},SimdAsHWIntrinsicFlag::None)

‎src/coreclr/jit/simdashwintrinsiclistxarch.h‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,8 @@ SIMD_AS_HWINTRINSIC_ID(VectorT, ConvertToUInt32,
6464
SIMD_AS_HWINTRINSIC_ID(VectorT,ConvertToUInt32Native,1, {NI_Illegal,NI_Illegal,NI_Illegal,NI_Illegal,NI_Illegal,NI_Illegal,NI_Illegal,NI_Illegal,NI_VectorT_ConvertToUInt32Native,NI_Illegal},SimdAsHWIntrinsicFlag::None)
6565
SIMD_AS_HWINTRINSIC_ID(VectorT,ConvertToUInt64,1, {NI_Illegal,NI_Illegal,NI_Illegal,NI_Illegal,NI_Illegal,NI_Illegal,NI_Illegal,NI_Illegal,NI_Illegal,NI_VectorT_ConvertToUInt64},SimdAsHWIntrinsicFlag::None)
6666
SIMD_AS_HWINTRINSIC_ID(VectorT,ConvertToUInt64Native,1, {NI_Illegal,NI_Illegal,NI_Illegal,NI_Illegal,NI_Illegal,NI_Illegal,NI_Illegal,NI_Illegal,NI_Illegal,NI_VectorT_ConvertToUInt64Native},SimdAsHWIntrinsicFlag::None)
67-
SIMD_AS_HWINTRINSIC_ID(VectorT,Create,1, {NI_VectorT_Create,NI_VectorT_Create,NI_VectorT_Create,NI_VectorT_Create,NI_VectorT_Create,NI_VectorT_Create,NI_VectorT_Create,NI_VectorT_Create,NI_VectorT_Create,NI_VectorT_Create},SimdAsHWIntrinsicFlag::None)
68-
SIMD_AS_HWINTRINSIC_ID(VectorT,CreateSequence,2, {NI_VectorT_CreateSequence,NI_VectorT_CreateSequence,NI_VectorT_CreateSequence,NI_VectorT_CreateSequence,NI_VectorT_CreateSequence,NI_VectorT_CreateSequence,NI_VectorT_CreateSequence,NI_VectorT_CreateSequence,NI_VectorT_CreateSequence,NI_VectorT_CreateSequence},SimdAsHWIntrinsicFlag::SpillSideEffectsOp1)
67+
SIMD_AS_HWINTRINSIC_ID(VectorT,Create,1, {NI_VectorT_Create,NI_VectorT_Create,NI_VectorT_Create,NI_VectorT_Create,NI_VectorT_Create,NI_VectorT_Create,NI_VectorT_Create,NI_VectorT_Create,NI_VectorT_Create,NI_VectorT_Create},SimdAsHWIntrinsicFlag::KeepBaseTypeFromRet)
68+
SIMD_AS_HWINTRINSIC_ID(VectorT,CreateSequence,2, {NI_VectorT_CreateSequence,NI_VectorT_CreateSequence,NI_VectorT_CreateSequence,NI_VectorT_CreateSequence,NI_VectorT_CreateSequence,NI_VectorT_CreateSequence,NI_VectorT_CreateSequence,NI_VectorT_CreateSequence,NI_VectorT_CreateSequence,NI_VectorT_CreateSequence},SimdAsHWIntrinsicFlag::KeepBaseTypeFromRet |SimdAsHWIntrinsicFlag::SpillSideEffectsOp1)
6969
SIMD_AS_HWINTRINSIC_ID(VectorT,Dot,2, {NI_Illegal,NI_Illegal,NI_VectorT_Dot,NI_VectorT_Dot,NI_VectorT_Dot,NI_VectorT_Dot,NI_Illegal,NI_Illegal,NI_VectorT_Dot,NI_VectorT_Dot},SimdAsHWIntrinsicFlag::None)
7070
SIMD_AS_HWINTRINSIC_ID(VectorT,Equals,2, {NI_VectorT_Equals,NI_VectorT_Equals,NI_VectorT_Equals,NI_VectorT_Equals,NI_VectorT_Equals,NI_VectorT_Equals,NI_VectorT_Equals,NI_VectorT_Equals,NI_VectorT_Equals,NI_VectorT_Equals},SimdAsHWIntrinsicFlag::None)
7171
SIMD_AS_HWINTRINSIC_ID(VectorT,EqualsAny,2, {NI_VectorT_EqualsAny,NI_VectorT_EqualsAny,NI_VectorT_EqualsAny,NI_VectorT_EqualsAny,NI_VectorT_EqualsAny,NI_VectorT_EqualsAny,NI_VectorT_EqualsAny,NI_VectorT_EqualsAny,NI_VectorT_EqualsAny,NI_VectorT_EqualsAny},SimdAsHWIntrinsicFlag::None)

‎src/libraries/System.Private.CoreLib/src/System/Numerics/Vector_1.cs‎

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -37,15 +37,10 @@ namespace System.Numerics
3737
/// <summary>Creates a new <see cref="Vector{T}" /> instance with all elements initialized to the specified value.</summary>
3838
/// <param name="value">The value that all elements will be initialized to.</param>
3939
/// <returns>A new <see cref="Vector{T}" /> with all elements initialized to <paramref name="value" />.</returns>
40-
[Intrinsic]
40+
[MethodImpl(MethodImplOptions.AggressiveInlining)]
4141
publicVector(Tvalue)
4242
{
43-
Unsafe.SkipInit(outthis);
44-
45-
for(intindex=0;index<Count;index++)
46-
{
47-
this.SetElementUnsafe(index,value);
48-
}
43+
this=Vector.Create(value);
4944
}
5045

5146
/// <summary>Creates a new <see cref="Vector{T}" /> from a given array.</summary>

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp