Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork275
Fix analyzer RCS1208#1462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Fix analyzer RCS1208#1462
Uh oh!
There was an error while loading.Please reload this page.
Conversation
BenjaminBrienen commentedMay 1, 2025
Would this fix this issue? publicvoidSetup(MarkdownPipelineBuilderpipeline){if(pipeline.BlockParsers.Find<HeadingBlockParser>()isHeadingBlockParserheadingBlockParser){// Install a hook on the HeadingBlockParser when a HeadingBlock is actually processedheadingBlockParser.Closed-=HeadingBlockParser_Closed;headingBlockParser.Closed+=HeadingBlockParser_Closed;}if(pipeline.BlockParsers.FindExact<ParagraphBlockParser>()isParagraphBlockParserparagraphBlockParser)// Reduce 'if' nesting RCS1208{// Install a hook on the ParagraphBlockParser when a HeadingBlock is actually processed as a Setex headingparagraphBlockParser.Closed-=HeadingBlockParser_Closed;paragraphBlockParser.Closed+=HeadingBlockParser_Closed;}} |
josefpihrt commentedMay 1, 2025
I'm not sure that I'm following you. |
BenjaminBrienen commentedMay 1, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
It suggests to invert that second if-block even though it wouldn't improve readability. This PR seems to add the concept of a "last if-block" and allows them. |
josefpihrt commentedMay 1, 2025
Tbh, I was working on this fix couple of months ago and the only thing I recall is that fix is almost impossible so I gave up 🙂 |
fixes#1454