Add CollectionExpression support to CA1870 (UseSearchValues)#7252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

buyaa-n merged 2 commits intodotnet:mainfromMihaZupan:searchvalues-collectionexpression

Apr 3, 2024

Merged

Add CollectionExpression support to CA1870 (UseSearchValues)#7252

buyaa-n merged 2 commits intodotnet:mainfromMihaZupan:searchvalues-collectionexpression

Apr 3, 2024

Conversation

Copy link

Member

MihaZupan commentedMar 19, 2024

Followup after#6898 to add recognition for collection expression patterns as well.

Currently, if you write something like

privatestaticreadonlychar[]s_chars=new[]{'a','e','i','o','u','A'};publicstaticintTest(ReadOnlySpan<char>s)=>s.IndexOfAny(s_chars);

you will be offered two fixers: one to replaces_chars withSearchValues.Create("aeiouA"), and the other to replace the array creation with['a', 'e', 'i', 'o', 'u', 'A'].
If you accept the latter, you won't be offered theSearchValues fixer anymore since we don't recognize the pattern.

This PR adds recognition for patterns like

staticreadonlychar[]s_chars=['a','e','i','o','u','A'];text.IndexOfAny(['a','e','i','o','u','A']);text.IndexOfAny([(byte)'a',(byte)'e',(byte)'i',(byte)'o',(byte)'u',(byte)'A']);text.IndexOfAny(s_chars);

Add CollectionExpression support to CA1870 (UseSearchValues)

ead61b1

MihaZupan requested a review froma team as acode owner

March 19, 2024 21:39

Copy link

MemberAuthor

MihaZupan commentedMar 19, 2024

cc:@stephentoub

Unused using

3692f88

Copy link

codecovbot commentedMar 19, 2024

Codecov Report

Attention: Patch coverage is86.82171% with17 lines in your changes are missing coverage. Please review.

Project coverage is 96.47%. Comparing base(de3a920) to head(3692f88).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@##             main    #7252     +/-   ##=========================================  Coverage   96.47%   96.47%             =========================================  Files        1436     1440      +4       Lines      342881   344487   +1606       Branches    11292    11340     +48     =========================================+ Hits       330797   332356   +1559- Misses       9230     9262     +32- Partials     2854     2869     +15