dotnet/roslyn-analyzersPublic

NotificationsYou must be signed in to change notification settings
Fork481
Star1.7k

Fix false-flag of CompareExchange and re-usage with loops#6979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

jozkee merged 4 commits intodotnet:mainfromjozkee:ca1869_bug

Oct 13, 2023

Merged

Fix false-flag of CompareExchange and re-usage with loops#6979

jozkee merged 4 commits intodotnet:mainfromjozkee:ca1869_bug

Oct 13, 2023

Conversation

Copy link

Member

jozkee commentedOct 13, 2023

Fixes#6957

jozkee added2 commits

October 12, 2023 13:42

Don't warn if object creation in local assignment is used as argument

7ba6d7d

Do not warn if options are used in a loop

7967da8

jozkee requested a review froma team as acode owner

October 13, 2023 02:55

jozkee requested review frombuyaa-n,eiriktsarpalis andstephentoub

October 13, 2023 02:56

eiriktsarpalis reviewed

Oct 13, 2023

View reviewed changes

...s/Core/Microsoft.NetCore.Analyzers/Performance/AvoidSingleUseOfLocalJsonSerializerOptions.cs OutdatedShow resolvedHide resolved

eiriktsarpalis reviewed

Oct 13, 2023

View reviewed changes

...s/Core/Microsoft.NetCore.Analyzers/Performance/AvoidSingleUseOfLocalJsonSerializerOptions.csShow resolvedHide resolved

jozkee added2 commits

October 13, 2023 10:22

Remove whitespace

a756ad1

Improve comment in IsLocalReferenceInsideChildLoop

dd6ead1

Copy link

codecovbot commentedOct 13, 2023

Codecov Report

Merging#6979 (dd6ead1) intomain (8b1675a) willincrease coverage by0.00%.
Report is 3 commits behind head on main.
The diff coverage is97.98%.

@@           Coverage Diff            @@##             main    #6979    +/-   ##========================================  Coverage   96.42%   96.43%            ========================================  Files        1410     1410              Lines      335956   336154   +198       Branches    11095    11103     +8     ========================================+ Hits       323956   324161   +205+ Misses       9207     9198     -9- Partials     2793     2795     +2

eiriktsarpalis approved these changes

Oct 13, 2023

View reviewed changes

Copy link

Member

eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks@jozkee!

buyaa-n approved these changes

Oct 13, 2023

View reviewed changes

Copy link

buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

jozkee merged commitac6c703 intodotnet:main

Oct 13, 2023

jozkee deleted the ca1869_bug branch

October 13, 2023 19:06

Copy link

Member

eiriktsarpalis commentedOct 13, 2023

@buyaa-n is there any action required to get this fix bundled with .NET 8?

Copy link

I think it's same as runtime porting, let managers know and agreed with porting, create a backport with/backport to release/8.0, fill in the description, I believe then need to send out emails to tactics for approval. CC@carlossanlop