Mar 12, 2024 · Dec 7, 2023 · Dec 11, 2023 · Dec 13, 2023 · Dec 18, 2023 · Dec 20, 2023
diff --git a/src/Compilers/CSharp/Portable/Binder/Binder_Invocation.cs b/src/Compilers/CSharp/Portable/Binder/Binder_Invocation.cs
                }
                else
                {
                    if (Compilation.SourceModule != parameters[paramsIndex].ContainingModule)
                    {
                        MessageID.IDS_ParamsCollections.CheckFeatureAvailability(diagnostics, node);
                    }

                    var unconvertedCollection = new BoundUnconvertedCollectionExpression(node, ImmutableArray<BoundNode>.CastUp(collectionArgs)) { WasCompilerGenerated = true, IsParamsCollection = true };
                    CompoundUseSiteInfo<AssemblySymbol> useSiteInfo = GetNewCompoundUseSiteInfo(diagnostics);
                    Conversion conversion = Conversions.ClassifyImplicitConversionFromExpression(unconvertedCollection, collectionType, ref useSiteInfo);
diff --git a/src/Compilers/CSharp/Portable/CSharpResources.resx b/src/Compilers/CSharp/Portable/CSharpResources.resx
  <data name="IDS_ImplicitIndexerInitializer" xml:space="preserve">
    <value>implicit indexer initializer</value>
  </data>
  <data name="IDS_ParamsCollections" xml:space="preserve">
    <value>params collections</value>
  </data>
 </root>
diff --git a/src/Compilers/CSharp/Portable/Errors/MessageID.cs b/src/Compilers/CSharp/Portable/Errors/MessageID.cs
        IDS_StringEscapeCharacter = MessageBase + 12839,

        IDS_ImplicitIndexerInitializer = MessageBase + 12840,

        IDS_ParamsCollections = MessageBase + 12900, // PROTOTYPE(ParamsCollections): pack numbers
    }

    // Message IDs may refer to strings that need to be localized.
                // C# preview features.
                case MessageID.IDS_StringEscapeCharacter:
                case MessageID.IDS_ImplicitIndexerInitializer:
                case MessageID.IDS_ParamsCollections:
                    return LanguageVersion.Preview;

                // C# 12.0 features.
diff --git a/src/Compilers/CSharp/Portable/Symbols/Source/ParameterHelpers.cs b/src/Compilers/CSharp/Portable/Symbols/Source/ParameterHelpers.cs
        {
            int parameterIndex = ordinal;
            bool isDefault = syntax is ParameterSyntax { Default: { } };
            bool? isValidParamsCollection = null;

            if (thisKeyword.Kind() == SyntaxKind.ThisKeyword && parameterIndex != 0)
            {
                // error CS1670: params is not valid in this context
                diagnostics.Add(ErrorCode.ERR_IllegalParams, paramsKeyword.GetLocation());
            }
            else if (isParams && !validParamsCollection(typeWithAnnotations))
            else if (isParams && !validParamsCollection(typeWithAnnotations, ref isValidParamsCollection))
            {
                diagnostics.Add(ErrorCode.ERR_ParamsMustBeCollection, paramsKeyword.GetLocation());
            }
                diagnostics.Add(ErrorCode.ERR_MethodArgCantBeRefAny, syntax.Location, typeWithAnnotations.Type);
            }

            if (isParams && ordinal != lastParameterIndex)
            if (isParams)
            {
                // error CS0231: A params parameter must be the last parameter in a parameter list
                diagnostics.Add(ErrorCode.ERR_ParamsLast, syntax.GetLocation());
                if (ordinal != lastParameterIndex)
                {
                    // error CS0231: A params parameter must be the last parameter in a parameter list
                    diagnostics.Add(ErrorCode.ERR_ParamsLast, syntax.GetLocation());
                }

                if (!typeWithAnnotations.IsSZArray() && validParamsCollection(typeWithAnnotations, ref isValidParamsCollection))
                {
                    MessageID.IDS_ParamsCollections.CheckFeatureAvailability(diagnostics, syntax);
                }
            }

            if (declaredScope == ScopedKind.ScopedValue && !typeWithAnnotations.IsRefLikeType())
            {
                diagnostics.Add(ErrorCode.ERR_ScopedRefAndRefStructOnly, syntax.Location);
            }

            bool validParamsCollection(TypeWithAnnotations typeWithAnnotations)
            bool validParamsCollection(TypeWithAnnotations typeWithAnnotations, ref bool? isValidParamsCollection)
            {
                if (isValidParamsCollection.HasValue)
                {
                    return isValidParamsCollection.GetValueOrDefault();
                }

                if (typeWithAnnotations.IsSZArray())
                {
                    isValidParamsCollection = true;
                    return true;
                }

                    if (elementType is not null)
                    {
                        // PROTOTYPE(ParamsCollections): Check accessibility of the Create method
                        isValidParamsCollection = true;
                        return true;
                    }
                }

                isValidParamsCollection = false;
                return false;
            }
        }
diff --git a/src/Compilers/CSharp/Portable/xlf/CSharpResources.cs.xlf b/src/Compilers/CSharp/Portable/xlf/CSharpResources.cs.xlf
diff --git a/src/Compilers/CSharp/Portable/xlf/CSharpResources.de.xlf b/src/Compilers/CSharp/Portable/xlf/CSharpResources.de.xlf
diff --git a/src/Compilers/CSharp/Portable/xlf/CSharpResources.es.xlf b/src/Compilers/CSharp/Portable/xlf/CSharpResources.es.xlf
diff --git a/src/Compilers/CSharp/Portable/xlf/CSharpResources.fr.xlf b/src/Compilers/CSharp/Portable/xlf/CSharpResources.fr.xlf
diff --git a/src/Compilers/CSharp/Portable/xlf/CSharpResources.it.xlf b/src/Compilers/CSharp/Portable/xlf/CSharpResources.it.xlf
diff --git a/src/Compilers/CSharp/Portable/xlf/CSharpResources.ja.xlf b/src/Compilers/CSharp/Portable/xlf/CSharpResources.ja.xlf
diff --git a/src/Compilers/CSharp/Portable/xlf/CSharpResources.ko.xlf b/src/Compilers/CSharp/Portable/xlf/CSharpResources.ko.xlf
diff --git a/src/Compilers/CSharp/Portable/xlf/CSharpResources.pl.xlf b/src/Compilers/CSharp/Portable/xlf/CSharpResources.pl.xlf
diff --git a/src/Compilers/CSharp/Portable/xlf/CSharpResources.pt-BR.xlf b/src/Compilers/CSharp/Portable/xlf/CSharpResources.pt-BR.xlf
diff --git a/src/Compilers/CSharp/Portable/xlf/CSharpResources.ru.xlf b/src/Compilers/CSharp/Portable/xlf/CSharpResources.ru.xlf
diff --git a/src/Compilers/CSharp/Portable/xlf/CSharpResources.tr.xlf b/src/Compilers/CSharp/Portable/xlf/CSharpResources.tr.xlf
diff --git a/src/Compilers/CSharp/Portable/xlf/CSharpResources.zh-Hans.xlf b/src/Compilers/CSharp/Portable/xlf/CSharpResources.zh-Hans.xlf
diff --git a/src/Compilers/CSharp/Portable/xlf/CSharpResources.zh-Hant.xlf b/src/Compilers/CSharp/Portable/xlf/CSharpResources.zh-Hant.xlf
Original file line number	Diff line number	Diff line change
Expand Up		@@ -1439,6 +1439,11 @@ internal void BindDefaultArgumentsAndParamsCollection(
		}
		else
		{
		if (Compilation.SourceModule != parameters[paramsIndex].ContainingModule)
		{
		MessageID.IDS_ParamsCollections.CheckFeatureAvailability(diagnostics, node);
		}

		var unconvertedCollection = new BoundUnconvertedCollectionExpression(node, ImmutableArray<BoundNode>.CastUp(collectionArgs)) { WasCompilerGenerated = true, IsParamsCollection = true };
		CompoundUseSiteInfo<AssemblySymbol> useSiteInfo = GetNewCompoundUseSiteInfo(diagnostics);
		Conversion conversion = Conversions.ClassifyImplicitConversionFromExpression(unconvertedCollection, collectionType, ref useSiteInfo);
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -7836,4 +7836,7 @@ To remove the warning, you can use /reference instead (set the Embed Interop Typ
		<data name="IDS_ImplicitIndexerInitializer" xml:space="preserve">
		<value>implicit indexer initializer</value>
		</data>
		<data name="IDS_ParamsCollections" xml:space="preserve">
		<value>params collections</value>
		</data>
		</root>
Original file line number	Diff line number	Diff line change
Expand Up		@@ -279,6 +279,8 @@ internal enum MessageID
		IDS_StringEscapeCharacter = MessageBase + 12839,

		IDS_ImplicitIndexerInitializer = MessageBase + 12840,

		IDS_ParamsCollections = MessageBase + 12900, // PROTOTYPE(ParamsCollections): pack numbers
		}

		// Message IDs may refer to strings that need to be localized.
Expand DownExpand Up		@@ -461,6 +463,7 @@ internal static LanguageVersion RequiredVersion(this MessageID feature)
		// C# preview features.
		case MessageID.IDS_StringEscapeCharacter:
		case MessageID.IDS_ImplicitIndexerInitializer:
		case MessageID.IDS_ParamsCollections:
		return LanguageVersion.Preview;

		// C# 12.0 features.
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -651,6 +651,7 @@ public static void ReportParameterErrors(
		{
		int parameterIndex = ordinal;
		bool isDefault = syntax is ParameterSyntax { Default: { } };
		bool? isValidParamsCollection = null;

		if (thisKeyword.Kind() == SyntaxKind.ThisKeyword && parameterIndex != 0)
		{
Expand All		@@ -665,7 +666,7 @@ public static void ReportParameterErrors(
		// error CS1670: params is not valid in this context
		diagnostics.Add(ErrorCode.ERR_IllegalParams, paramsKeyword.GetLocation());
		}
		else if (isParams && !validParamsCollection(typeWithAnnotations))
		else if (isParams && !validParamsCollection(typeWithAnnotations, ref isValidParamsCollection))
		{
		diagnostics.Add(ErrorCode.ERR_ParamsMustBeCollection, paramsKeyword.GetLocation());
		}
Expand All		@@ -691,21 +692,35 @@ public static void ReportParameterErrors(
		diagnostics.Add(ErrorCode.ERR_MethodArgCantBeRefAny, syntax.Location, typeWithAnnotations.Type);
		}

		if (isParams && ordinal != lastParameterIndex)
		if (isParams)
		{
		// error CS0231: A params parameter must be the last parameter in a parameter list
		diagnostics.Add(ErrorCode.ERR_ParamsLast, syntax.GetLocation());
		if (ordinal != lastParameterIndex)
		{
		// error CS0231: A params parameter must be the last parameter in a parameter list
		diagnostics.Add(ErrorCode.ERR_ParamsLast, syntax.GetLocation());
		}

		if (!typeWithAnnotations.IsSZArray() && validParamsCollection(typeWithAnnotations, ref isValidParamsCollection))
		{
		MessageID.IDS_ParamsCollections.CheckFeatureAvailability(diagnostics, syntax);
		}
		}

		if (declaredScope == ScopedKind.ScopedValue && !typeWithAnnotations.IsRefLikeType())
		{
		diagnostics.Add(ErrorCode.ERR_ScopedRefAndRefStructOnly, syntax.Location);
		}

		bool validParamsCollection(TypeWithAnnotations typeWithAnnotations)
		bool validParamsCollection(TypeWithAnnotations typeWithAnnotations, ref bool? isValidParamsCollection)
		{
		if (isValidParamsCollection.HasValue)
		{
		return isValidParamsCollection.GetValueOrDefault();
		}

		if (typeWithAnnotations.IsSZArray())
		{
		isValidParamsCollection = true;
		return true;
		}

Expand All		@@ -723,10 +738,12 @@ bool validParamsCollection(TypeWithAnnotations typeWithAnnotations)
		if (elementType is not null)
		{
		// PROTOTYPE(ParamsCollections): Check accessibility of the Create method
		isValidParamsCollection = true;
		return true;
		}
		}

		isValidParamsCollection = false;
		return false;
		}
		}
Expand Down