- Notifications
You must be signed in to change notification settings - Fork4.2k
Merge 'dotnet/main' into ParamsCollections#72042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
AlekseyTs merged 435 commits intodotnet:features/ParamsCollectionsfromAlekseyTs:ParamsCollections_20Feb 12, 2024
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from5 commits
Commits
Show all changes
435 commits Select commitHold shift + click to select a range
b1142c5 Fix test now that devkit dependency loading happens in entry point
dibarbet9891173 Merge pull request #71853 from CyrusNajmabadi/backportRevert
arunchndr42a4cde Merge pull request #71906 from dotnet/merges/release/dev17.9-to-relea…
dotnet-botfa72fa6 Merge pull request #71907 from dotnet/merges/release/dev17.9-to-relea…
dotnet-bot4f2c5a2 Merge pull request #71908 from dotnet/merges/release/dev17.10-to-main
dotnet-bot2df7dde Merge pull request #71910 from dotnet/merges/release/dev17.10-to-main
dotnet-bot0deb93a Merge pull request #71894 from sharwell/unnecessary-box
sharwell8950faf Workaround failure to bind reference in 17.9 Preview 2
sharwell4c0d1a0 Fixed the Go To Definition for ValueTuple
victor-pogorbb6ae28 Merge pull request #71897 from sharwell/disable-surround-p2
sharwellb014111 Merge remote-tracking branch 'upstream/main' into sourceTextAllocate
CyrusNajmabadi9c4b523 Merge remote-tracking branch 'upstream/main' into uniformity
CyrusNajmabadi98c2920 Merge branch 'main' into keepProjectCone
CyrusNajmabadi303f106 Simplify
CyrusNajmabadie02b3dd Merge branch 'main' into dev/shech/specifyNewtonsoftJsonVersion
Cosifne6d56ca4 Update src/Workspaces/Remote/ServiceHub/Host/RemoteWorkspace.Solution…
CyrusNajmabadifd51297 Merge pull request #71886 from CyrusNajmabadi/sourceTextAllocate
CyrusNajmabadic0ba83c Inline methods
CyrusNajmabadi1123a8f Cleanup
CyrusNajmabadia27303a Update src/Workspaces/Remote/ServiceHub/Host/RemoteWorkspace.Solution…
CyrusNajmabadid05c50a Merge branch 'inlineMethods' into keepProjectCone
CyrusNajmabadi2d640ec Consistency
CyrusNajmabadi48a9211 Merge branch 'keepProjectCone' of https://github.com/CyrusNajmabadi/r…
CyrusNajmabadic75a980 rename
CyrusNajmabadi1c7686e Merge branch 'inlineMethods' into keepProjectCone
CyrusNajmabadib8d1912 Merge pull request #71877 from CyrusNajmabadi/uniformity
CyrusNajmabadi70fc76f Docs
CyrusNajmabadic925e3d Docs
CyrusNajmabadi80f4e50 Merge branch 'inlineMethods' into keepProjectCone
CyrusNajmabadie7cae31 Merge pull request #71876 from Cosifne/dev/shech/specifyNewtonsoftJso…
Cosifne3d66710 Fix
CyrusNajmabadi5db5647 Rewrite test to not use MSBuildProjectLoader
jasonmalinowski19751d7 Report workspace messages for warnings/errors from the build hosts
jasonmalinowski2fd5578 Fix code that errantly assumed a paramarray parameter must be an array
CyrusNajmabadi46dbf62 Disallow UseConditionalExpression with unsafe or checked/unchecked bl…
9f45967 Merge pull request #71915 from CyrusNajmabadi/inlineMethods
CyrusNajmabadi5010358 Merge branch 'main' into keepProjectCone
CyrusNajmabadide6f68a Add a direct test to test MSBuildProjectLoader
jasonmalinowski196dd75 [71680] Added more tests, docs
victor-pogora9f264d [71680] Changed the implementation
victor-pogor105d6e7 Update `Lock` object feature status (#71889)
jjonescz14a7c76 Reduce allocations during NamespaceSymbol.LookupNestedNamespace (#71921)
ToddGruna7bf684 PR feedback
CyrusNajmabadi019c459 PR feedback
CyrusNajmabadi22b333e Merge pull request #71920 from CyrusNajmabadi/vbCrash
CyrusNajmabadic304e1f Disable complete statement in non-user code
sharwelle2e96c5 Do not remove necessary cast to System.Delegate when present
CyrusNajmabadic492d7c Prepare 17.10 snap
Cosifnedc40ba3 Merge remote-tracking branch 'upstream/main' into analyzer_assembly_l…
dibarbetbaefbc9 Add a metadata reference instead of DLL reference to WindowsBase
sharwelle5ce64c Merge pull request #71938 from CyrusNajmabadi/delegateCast
CyrusNajmabadif0e3386 Remove unnecessary usage of generics
CyrusNajmabadi761b509 Simplify
CyrusNajmabadi64db736 Merge pull request #71826 from CyrusNajmabadi/keepProjectCone
CyrusNajmabadid95a8dc Merge pull request #71912 from victor-pogor/71684-gotodefinition-valu…
CyrusNajmabadi64e0eaa Merge pull request #71936 from sharwell/disabled-code
sharwell9e4576d Simplify serialization code
CyrusNajmabadice41e5d in progress
CyrusNajmabadi8bd42a7 in progress
CyrusNajmabadi5b9096c tests
CyrusNajmabadi5b05d6b implement ReadEncoding
CyrusNajmabadi9b5e3e8 implement reading
CyrusNajmabadiff2bada in progress
CyrusNajmabadief74e90 Simplify
CyrusNajmabadi77c627c In progress
CyrusNajmabadi84737e1 Delete more tests
CyrusNajmabadi0124c1a Fix encoding
CyrusNajmabadi7ab59b3 Merge pull request #71942 from CyrusNajmabadi/removeGenerics
CyrusNajmabadi98fd2f9 Merge pull request #71830 from jasonmalinowski/change-apply-change-si…
jasonmalinowski0e6c4de Merge pull request #71939 from Cosifne/dev/shech/17.10snap
Cosifneb14dc4d Merge pull request #71881 from jasonmalinowski/switch-back-to-net6.0-…
jasonmalinowski7d82a84 Merge remote-tracking branch 'upstream/main' into simplifySerialization
CyrusNajmabadi8f5b85f rename
CyrusNajmabadica1e57d feedback
CyrusNajmabadieea4b0f Don't place array type kind in stream
CyrusNajmabadidf82650 nrt
CyrusNajmabadie6b532d nrt
CyrusNajmabadiac87e04 NRT
CyrusNajmabadi85dccbb simplify
CyrusNajmabadib9c03b7 Simplify and inline
CyrusNajmabadicbf8b72 increment
CyrusNajmabadi266b5c9 nrt
CyrusNajmabadic1a6d46 Update src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Seri…
CyrusNajmabadif74f7d6 make stringb ased
CyrusNajmabadia683851 Update src/Analyzers/CSharp/Analyzers/UseCollectionExpression/CSharpU…
CyrusNajmabadifa4572d Revert
CyrusNajmabadid8ee406 Merge branch 'simplifySerialization' of https://github.com/CyrusNajma…
CyrusNajmabadiae071f2 fix
CyrusNajmabadi5de6755 Implement code folding for collection expression
victor-pogorf4d4743 Merge pull request #71944 from CyrusNajmabadi/simplifySerialization
CyrusNajmabadid9272a3 Merge pull request #71951 from victor-pogor/71932-collection-expressi…
CyrusNajmabadic9e6a8a Merge branch 'main' into feedback
CyrusNajmabadi65ef2c8 Delete
CyrusNajmabadie222ce2 Simplify
CyrusNajmabadi91d29dd Simplify
CyrusNajmabadi98b123e fix
CyrusNajmabadi4b818cf fix
CyrusNajmabadiaf15625 simplify
CyrusNajmabadi36116b1 Fix invariant-breaking parsing of errant case clauses in switch expre…
CyrusNajmabadi7051d92 Add tests
CyrusNajmabadif35c96a more tests
CyrusNajmabadi768a319 Add publishing configuration for vscode net8 branch
dibarbet2fb0ddb Merge pull request #71962 from dotnet/dibarbet-patch-2
dibarbet49420e2 Merge pull request #71935 from CyrusNajmabadi/feedback
CyrusNajmabadi47431aa Simplify compilation tracking
CyrusNajmabadief7f7cd remove compilationinfo type
CyrusNajmabadi085ed1e Renames
CyrusNajmabadicdcf895 Review feedback
dibarbetf1b4c8e Simplify
CyrusNajmabadi969b59c inline method
CyrusNajmabadie4d5adf inline methods
CyrusNajmabadif536ae1 Merge pull request #71909 from jasonmalinowski/log-buildhost-process-…
jasonmalinowski661d9e7 Renames and stronger typing
CyrusNajmabadi53e20b7 Wrapping
CyrusNajmabadidc15aaf Add intermediary compilation-tracker type
CyrusNajmabadi5c10f4f Reverts
CyrusNajmabadi9b37250 REvert
CyrusNajmabadi51f4921 Merge branch 'trackerRefactoring' into compilationTrackerType
CyrusNajmabadib48f138 make non-optional
CyrusNajmabadi3af4c67 make non-optional
CyrusNajmabadib33b273 Merge branch 'trackerRefactoring' into compilationTrackerType
CyrusNajmabadie4577ce Make constructor with additional argument private
CyrusNajmabadib52cef0 use a switch
CyrusNajmabadifcecd83 remove unused parameters
CyrusNajmabadi7f51274 inline method
CyrusNajmabadibeaa8d1 Merge pull request #71965 from CyrusNajmabadi/optionalArg
CyrusNajmabadia9aded3 Respond to VS LSP diagnostic breaking changes
dibarbet580129a Merge pull request #71963 from CyrusNajmabadi/trackerRefactoring
CyrusNajmabadi652776c Merge branch 'main' into compilationTrackerType
CyrusNajmabadic08dabd Prevent error propagations by misplaced semicolon in list parsing
aldelaro51e61317 Merge remote-tracking branch 'upstream/main' into trackerRefactoringLock
CyrusNajmabadi8796e76 Simplify code
CyrusNajmabadi552991f Simplify
CyrusNajmabadia47f41c Simplify
CyrusNajmabadi86a0c9d Simplify
CyrusNajmabadidbd06d1 in progress
CyrusNajmabadi8dc1e19 in progress
CyrusNajmabadi0341f89 Docs
CyrusNajmabadi15514b9 Make transitions much more strongly typed
CyrusNajmabadi94c1a35 Strong type
CyrusNajmabadi7ec3dea Add unit test to catch error propagation
aldelaro5c72c5e0 Merge pull request #71966 from CyrusNajmabadi/trackerRefactoringLock
CyrusNajmabadi7748cd1 Merge remote-tracking branch 'upstream/main' into frozenState2
CyrusNajmabadi8b97b7f Merge remote-tracking branch 'upstream/main' into compilationTrackerType
CyrusNajmabadi22cfa60 Add more rigorous unit tests
aldelaro5613c0ee Merge branch 'compilationTrackerType' into frozenState2
CyrusNajmabadief43b0f Address additional VS LSP breaking changes
dibarbetf24265e Add more tests with if and return statements
aldelaro59d629cb Add comment back
CyrusNajmabadi743d190 Merge pull request #71964 from CyrusNajmabadi/compilationTrackerType
CyrusNajmabadi8dabfbc Merge remote-tracking branch 'upstream/main' into frozenState2
CyrusNajmabadi5d390a6 Add file
CyrusNajmabadibfe3adb REmove
CyrusNajmabadif9935c6 Enable implicit primary constructor parameter capture analyzer (#71905)
333fred8cdc0cc Move SB metadata to intermediates (#71934)
ellahathawaya3e0355 Merge pull request #71974 from CyrusNajmabadi/moveFiles
CyrusNajmabadi43aca37 Bootstrap Framework should be CI only (#71979)
jaredpardac8b19 Fix some comments in the Workspaces.MSBuild project file
jasonmalinowski591530f Merge pull request #71972 from CyrusNajmabadi/frozenState2
CyrusNajmabadi6eb96ea Beef up type inferrer
CyrusNajmabadic74b31b Fix central package versioning picking up Version.Details.xml
jasonmalinowskic3d3595 Merge pull request #71862 from dibarbet/analyzer_assembly_loading_vscode
dibarbet4e1e388 Merge pull request #71967 from dibarbet/vs_diagnostic_changes
dibarbet71092fe Break out the IsFrozen flag to be an aspect of CompilationTrackerState.
CyrusNajmabadi0d4a461 Introduce new intermediary abstract type to represent the non-final s…
CyrusNajmabadi5196078 Extract helper methods for clarity
CyrusNajmabadi39cc204 Update src/Workspaces/Core/Portable/Workspace/Solution/SolutionCompil…
CyrusNajmabadicd44a48 Break out the IsFrozen flag to be an aspect of CompilationTrackerState.
CyrusNajmabadif39edc4 Fix nesting
CyrusNajmabadi8a0e014 Use captures to cleanup code
CyrusNajmabadi0170155 Move to a local function, and remove unnecessary helpers
CyrusNajmabadi6fe0e5e Extract helper for clarity
CyrusNajmabadi1b7c316 add test
CyrusNajmabadic77b6ca Merge pull request #71982 from CyrusNajmabadi/typeInferrer
CyrusNajmabadi95f1624 [main] Update dependencies from dotnet/source-build-reference-package…
dotnet-maestro[bot]4d79f4d CompilationOutputInfo.AssemblyPath should be a normalized path (#71975)
phil-allen-msftd2abc85 Seeing what breaks
CyrusNajmabadi031d78e Make NoCompilationState into a singleton
CyrusNajmabadif8cf395 Merge branch 'main' into frozen3
CyrusNajmabadi4cd098b Merge pull request #71984 from jasonmalinowski/fix-source-build
jasonmalinowskidf5e7bf Use 'null' to represent initial tracker state
CyrusNajmabadi14bf1f9 Disallow ref kind mismatch for dynamic arguments in non-ComImport sce…
AlekseyTsf08bff2 Merge pull request #71992 from CyrusNajmabadi/nullCheck
CyrusNajmabadicb4f2a0 Merge remote-tracking branch 'upstream/main' into parseSwitch
CyrusNajmabadiaaaf5a7 Add tests with trivia
CyrusNajmabadi735c29e Add tests with trivia
CyrusNajmabadi66539a6 Merge remote-tracking branch 'upstream/main' into frozen3
CyrusNajmabadif7b9765 Simplify input/output
CyrusNajmabadic2c2912 use record
CyrusNajmabadi9fef311 Update src/Workspaces/Core/Portable/Workspace/Solution/SolutionCompil…
CyrusNajmabadic969992 Update src/Workspaces/Core/Portable/Workspace/Solution/SolutionCompil…
CyrusNajmabadi2eeabfc strong assert
CyrusNajmabadi1136962 Fix
CyrusNajmabadiac2cce7 PR feedback
CyrusNajmabadie4b57d3 Merge pull request #71993 from CyrusNajmabadi/removeInfo
CyrusNajmabadic85b5ba Merge remote-tracking branch 'upstream/main' into frozen3
CyrusNajmabadie07dda9 cleanu
CyrusNajmabadi87e3c8f Simplify
CyrusNajmabadi8b43624 Simplify
CyrusNajmabadic0343cf Merge branch 'main' into parseSwitch
CyrusNajmabadi49df118 Merge branch 'main' into makeInfoNull
CyrusNajmabadia635415 Simplify instantiation of lsp options
CyrusNajmabadi63d2b77 Merge pull request #71712 from sdelarosbil/list-parsing-prevent-propa…
CyrusNajmabadi285aa56 Merge pull request #71960 from CyrusNajmabadi/parseSwitch
CyrusNajmabadi4e2ec88 Merge pull request #72009 from CyrusNajmabadi/lspRecords
CyrusNajmabadie197320 Merge branch 'main' into makeInfoNull
CyrusNajmabadi8919a83 Merge remote-tracking branch 'upstream/main' into frozen3
CyrusNajmabadi7d5b6e6 Reduce allocations in ImmutableArrayExtensions.GetTypesFromMemberMap …
ToddGrun6897da2 Reduce dictionary resizes under NodeMapBuilder.AddToMap (#71995)
ToddGrun86e8e79 Modify CpsDiagnosticItemSourceProvider.CreateCollectionSource to be r…
ToddGrunca315af Merge remote-tracking branch 'upstream/main' into frozenBit
CyrusNajmabadi2296cb5 Merge pull request #71996 from CyrusNajmabadi/makeInfoNull
CyrusNajmabadi30026f7 Merge remote-tracking branch 'upstream/main' into frozenBit
CyrusNajmabadiec0f507 Merge remote-tracking branch 'upstream/main' into frozen3
CyrusNajmabadic3c51d8 Merge branch 'frozenBit' into frozen3
CyrusNajmabadi6118b7d Update
CyrusNajmabadia4e624c Update
CyrusNajmabadi1e30d6f Fixup
CyrusNajmabadiec487b6 Fixup
CyrusNajmabadi78644fe Disable flakey test
CyrusNajmabadiba00e92 Merge pull request #71986 from CyrusNajmabadi/frozenBit
CyrusNajmabadi5faf3c1 Merge branch 'main' into frozen3
CyrusNajmabadi36dc773 Skip flakey test
CyrusNajmabadie924f4f Merge branch 'disableFlakeyTest' into frozen3
CyrusNajmabadi5d153ac Avoid visiting reachable local functions with default state (#71679)
jjonescz43a9d7f [main] Update dependencies from dotnet/source-build-externals (#71547)
dotnet-maestro[bot]7cbbb49 Merge pull request #72019 from CyrusNajmabadi/disableFlakeyTest
CyrusNajmabadiaa9a88c Add missing dependencies (#72013)
mmitche98cdb15 Inline hints - do not produce tags if using lsp editor (#71985)
akhera99daeef2d Only request the necessary document and project in GraphBuilder.Popul…
ToddGrun9874926 Merge pull request #71981 from jasonmalinowski/fix-comments
jasonmalinowski77ac712 Merge remote-tracking branch 'upstream/main' into frozen3
CyrusNajmabadi40d34c8 Fix crash in 'remove unreachable code'
CyrusNajmabadi024f7ef Fix null ref in convert-local-function
CyrusNajmabadi4357e19 Update
CyrusNajmabadib2eaa8d Reduce allocations in AbstractFormatEngine.Format (#72002)
ToddGrunec9522b Update
CyrusNajmabadibe5043b Update
CyrusNajmabadieef6927 Fix test
CyrusNajmabadi0b5b744 Merge pull request #72028 from CyrusNajmabadi/unreachableCrash
CyrusNajmabadi740cb44 Build bootstrap compiler in separate phase (#72001)
jaredpar43c78c7 Merge pull request #71976 from CyrusNajmabadi/frozen3
CyrusNajmabadi03a5476 Merge pull request #72029 from CyrusNajmabadi/convertLocalFunctionCrash
CyrusNajmabadi786333b Fix crash with convert to record
CyrusNajmabadi119a140 Add argument check to help track down a crash
CyrusNajmabadi48ece0b fix
CyrusNajmabadie285c37 Merge pull request #72038 from CyrusNajmabadi/argCheck
CyrusNajmabadi2fa19b0 Merge pull request #72037 from CyrusNajmabadi/convertRecordCrash
CyrusNajmabadi18852b8 Merge remote-tracking branch 'dotnet/main' into ParamsCollections_20
AlekseyTs25414ee Update test according to changes in ParamsCollections branch
AlekseyTsFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.