Jul 9, 2021 · Feb 28, 2021 · Mar 8, 2021 · Mar 14, 2021 · Mar 22, 2021 · Mar 25, 2021
diff --git a/src/Compilers/CSharp/Portable/Binder/Binder_InterpolatedString.cs b/src/Compilers/CSharp/Portable/Binder/Binder_InterpolatedString.cs
                    var parameter = GetCorrespondingParameter(ref memberAnalysisResult, parameters, originalParameterIndex);
                    if (parameter.IsOptional)
                    {
                        // Parameter '{0}' isoptional, but is used as an argument to the interpolated string handler conversion on parameter '{1}'. Specify the value of '{0}' before '{1}'.
                        // Parameter '{0}' isnot explicitly provided, but is used as an argument to the interpolated string handler conversion on parameter '{1}'. Specify the value of '{0}' before '{1}'.
                        diagnostics.Add(
                            ErrorCode.ERR_InterpolatedStringHandlerArgumentOptionalNotSpecified,
                            unconvertedString.Syntax.Location,
                    var parameter = GetCorrespondingParameter(ref memberAnalysisResult, parameters, argumentIndex);
                    if (argumentIndex > interpolatedStringArgNum)
                    {
                        // Parameter '{0}' is an argument to the interpolated string handler conversion on parameter '{1}', but is specified after the interpolated stringconstant. Reorder the arguments to move '{0}' before '{1}'.
                        // Parameter '{0}' is an argument to the interpolated string handler conversion on parameter '{1}', butthe corresponding argumentis specified after the interpolated stringexpression. Reorder the arguments to move '{0}' before '{1}'.
                        diagnostics.Add(
                            ErrorCode.ERR_InterpolatedStringHandlerArgumentLocatedAfterInterpolatedString,
                            arguments[argumentIndex].Syntax.Location,
diff --git a/src/Compilers/CSharp/Portable/Binder/Binder_Invocation.cs b/src/Compilers/CSharp/Portable/Binder/Binder_Invocation.cs
                methodResult,
                analyzedArguments.Arguments,
                diagnostics,
 boundExpression.Type,
 boundExpression.GetRefKind());
 receiverType: null,
 receiverRefKind: default);

            var args = analyzedArguments.Arguments.ToImmutable();
            var refKinds = analyzedArguments.RefKinds.ToImmutableOrNull();
diff --git a/src/Compilers/CSharp/Portable/CSharpResources.resx b/src/Compilers/CSharp/Portable/CSharpResources.resx
    <comment>InterpolatedStringHandlerArgumentAttribute is a type name and should not be translated.</comment>
  </data>
  <data name="ERR_InterpolatedStringHandlerArgumentLocatedAfterInterpolatedString" xml:space="preserve">
    <value>Parameter '{0}' is an argument to the interpolated string handler conversion on parameter '{1}', but is specified after the interpolated stringconstant. Reorder the arguments to move '{0}' before '{1}'.</value>
    <value>Parameter '{0}' is an argument to the interpolated string handler conversion on parameter '{1}', butthe corresponding argumentis specified after the interpolated stringexpression. Reorder the arguments to move '{0}' before '{1}'.</value>
  </data>
  <data name="ERR_InterpolatedStringHandlerArgumentOptionalNotSpecified" xml:space="preserve">
    <value>Parameter '{0}' isoptional, but is used as an argument to the interpolated string handler conversion on parameter '{1}'. Specify the value of '{0}' before '{1}'.</value>
    <value>Parameter '{0}' isnot explicitly provided, but is used as an argument to the interpolated string handler conversion on parameter '{1}'. Specify the value of '{0}' before '{1}'.</value>
  </data>
  <data name="ERR_ExpressionTreeContainsInterpolatedStringHandlerConversion" xml:space="preserve">
    <value>An expression tree may not contain an interpolated string handler conversion.</value>
diff --git a/src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter.cs b/src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter.cs
            Debug.Assert(removed);
        }

        private void RemovePlaceholderReplacementIfPresent(BoundValuePlaceholderBase placeholder)
        {
            Debug.Assert(placeholder is { });
            Debug.Assert(_placeholderReplacementMapDoNotUseDirectly is { });
            _ = _placeholderReplacementMapDoNotUseDirectly.Remove(placeholder);
        }

        private bool HasPlaceholderReplacement(BoundValuePlaceholderBase placeholder)
        {
            Debug.Assert(placeholder is not null);
            return _placeholderReplacementMapDoNotUseDirectly?.ContainsKey(placeholder) ?? false;
        }

        public sealed override BoundNode VisitOutDeconstructVarPendingInference(OutDeconstructVarPendingInference node)
        {
            // OutDeconstructVarPendingInference nodes are only used within initial binding, but don't survive past that stage
diff --git a/src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter_AssignmentOperator.cs b/src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter_AssignmentOperator.cs
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.

 using System;
 using System.Collections.Immutable;
 using System.Diagnostics;
 using System.Diagnostics.CodeAnalysis;
 using Microsoft.CodeAnalysis.CSharp.Symbols;
 using Microsoft.CodeAnalysis.PooledObjects;
 using Roslyn.Utilities;

 namespace Microsoft.CodeAnalysis.CSharp
                    rewrittenRight);
            }

            ImmutableArray<LocalSymbol> argTemps;
            arguments = VisitArguments(
                syntax,
                arguments,
                property,
                expanded,
                argsToParamsOpt,
                ref argumentRefKindsOpt,
                out argTemps,
                ref rewrittenReceiver,
                out ArrayBuilder<LocalSymbol>? argTempsBuilder,
                out BitVector positionsAssignedToTemp,
                receiverIsArgumentSideEffectSequence: out _);

            arguments = MakeArguments(
                syntax,
                arguments,
                property,
                expanded,
                argsToParamsOpt,
                ref argumentRefKindsOpt,
                ref argTempsBuilder,
                positionsAssignedToTemp,
                invokedAsExtensionMethod: false,
                enableCallerInfo: ThreeState.True);

            var argTemps = argTempsBuilder?.ToImmutableAndFree() ?? default;

            if (used)
            {
                // Save expression value to a temporary before calling the
Original file line number	Diff line number	Diff line change
Expand Up		@@ -634,7 +634,7 @@ private BoundExpression BindInterpolatedStringHandlerInMemberCall(
		var parameter = GetCorrespondingParameter(ref memberAnalysisResult, parameters, originalParameterIndex);
		if (parameter.IsOptional)
		{
		// Parameter '{0}' isoptional, but is used as an argument to the interpolated string handler conversion on parameter '{1}'. Specify the value of '{0}' before '{1}'.
		// Parameter '{0}' isnot explicitly provided, but is used as an argument to the interpolated string handler conversion on parameter '{1}'. Specify the value of '{0}' before '{1}'.
		diagnostics.Add(
		ErrorCode.ERR_InterpolatedStringHandlerArgumentOptionalNotSpecified,
		unconvertedString.Syntax.Location,
Expand All		@@ -651,7 +651,7 @@ private BoundExpression BindInterpolatedStringHandlerInMemberCall(
		var parameter = GetCorrespondingParameter(ref memberAnalysisResult, parameters, argumentIndex);
		if (argumentIndex > interpolatedStringArgNum)
		{
		// Parameter '{0}' is an argument to the interpolated string handler conversion on parameter '{1}', but is specified after the interpolated stringconstant. Reorder the arguments to move '{0}' before '{1}'.
		// Parameter '{0}' is an argument to the interpolated string handler conversion on parameter '{1}', butthe corresponding argumentis specified after the interpolated stringexpression. Reorder the arguments to move '{0}' before '{1}'.
		diagnostics.Add(
		ErrorCode.ERR_InterpolatedStringHandlerArgumentLocatedAfterInterpolatedString,
		arguments[argumentIndex].Syntax.Location,
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -2013,8 +2013,8 @@ private BoundFunctionPointerInvocation BindFunctionPointerInvocation(SyntaxNode
		methodResult,
		analyzedArguments.Arguments,
		diagnostics,
		boundExpression.Type,
		boundExpression.GetRefKind());
		receiverType: null,
		receiverRefKind: default);

		var args = analyzedArguments.Arguments.ToImmutable();
		var refKinds = analyzedArguments.RefKinds.ToImmutableOrNull();
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -6686,10 +6686,10 @@ To remove the warning, you can use /reference instead (set the Embed Interop Typ
		<comment>InterpolatedStringHandlerArgumentAttribute is a type name and should not be translated.</comment>
		</data>
		<data name="ERR_InterpolatedStringHandlerArgumentLocatedAfterInterpolatedString" xml:space="preserve">
		<value>Parameter '{0}' is an argument to the interpolated string handler conversion on parameter '{1}', but is specified after the interpolated stringconstant. Reorder the arguments to move '{0}' before '{1}'.</value>
		<value>Parameter '{0}' is an argument to the interpolated string handler conversion on parameter '{1}', butthe corresponding argumentis specified after the interpolated stringexpression. Reorder the arguments to move '{0}' before '{1}'.</value>
		</data>
		<data name="ERR_InterpolatedStringHandlerArgumentOptionalNotSpecified" xml:space="preserve">
		<value>Parameter '{0}' isoptional, but is used as an argument to the interpolated string handler conversion on parameter '{1}'. Specify the value of '{0}' before '{1}'.</value>
		<value>Parameter '{0}' isnot explicitly provided, but is used as an argument to the interpolated string handler conversion on parameter '{1}'. Specify the value of '{0}' before '{1}'.</value>
		</data>
		<data name="ERR_ExpressionTreeContainsInterpolatedStringHandlerConversion" xml:space="preserve">
		<value>An expression tree may not contain an interpolated string handler conversion.</value>
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -442,19 +442,6 @@ private void RemovePlaceholderReplacement(BoundValuePlaceholderBase placeholder)
		Debug.Assert(removed);
		}

		private void RemovePlaceholderReplacementIfPresent(BoundValuePlaceholderBase placeholder)
		{
		Debug.Assert(placeholder is { });
		Debug.Assert(_placeholderReplacementMapDoNotUseDirectly is { });
		_ = _placeholderReplacementMapDoNotUseDirectly.Remove(placeholder);
		}

		private bool HasPlaceholderReplacement(BoundValuePlaceholderBase placeholder)
		{
		Debug.Assert(placeholder is not null);
		return _placeholderReplacementMapDoNotUseDirectly?.ContainsKey(placeholder) ?? false;
		}

		public sealed override BoundNode VisitOutDeconstructVarPendingInference(OutDeconstructVarPendingInference node)
		{
		// OutDeconstructVarPendingInference nodes are only used within initial binding, but don't survive past that stage
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -2,11 +2,10 @@
		// The .NET Foundation licenses this file to you under the MIT license.
		// See the LICENSE file in the project root for more information.

		using System;
		using System.Collections.Immutable;
		using System.Diagnostics;
		using System.Diagnostics.CodeAnalysis;
		using Microsoft.CodeAnalysis.CSharp.Symbols;
		using Microsoft.CodeAnalysis.PooledObjects;
		using Roslyn.Utilities;

		namespace Microsoft.CodeAnalysis.CSharp
Expand DownExpand Up		@@ -312,19 +311,31 @@ private BoundExpression MakePropertyAssignment(
		rewrittenRight);
		}

		ImmutableArray<LocalSymbol> argTemps;
		arguments = VisitArguments(
		syntax,
		arguments,
		property,
		expanded,
		argsToParamsOpt,
		ref argumentRefKindsOpt,
		out argTemps,
		ref rewrittenReceiver,
		out ArrayBuilder<LocalSymbol>? argTempsBuilder,
		out BitVector positionsAssignedToTemp,
		receiverIsArgumentSideEffectSequence: out _);

		arguments = MakeArguments(
		syntax,
		arguments,
		property,
		expanded,
		argsToParamsOpt,
		ref argumentRefKindsOpt,
		ref argTempsBuilder,
		positionsAssignedToTemp,
		invokedAsExtensionMethod: false,
		enableCallerInfo: ThreeState.True);

		var argTemps = argTempsBuilder?.ToImmutableAndFree() ?? default;

		if (used)
		{
		// Save expression value to a temporary before calling the
Expand Down