NotificationsYou must be signed in to change notification settings
Fork4.2k
Star20k

Rebuild API shape#52079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

jaredpar merged 5 commits intodotnet:mainfromjaredpar:factory

Mar 24, 2021

Merged

Rebuild API shape#52079

jaredpar merged 5 commits intodotnet:mainfromjaredpar:factory

Mar 24, 2021

Conversation

Copy link

Member

jaredpar commentedMar 23, 2021

This breaks upBuildConstructor into a simple hierarchy with both
CSharp and Visual Basic implementations. The nameCompilationFactory
was chosen after a bit of offline conversation and mostly due to this
representing a factory of sorts. As with all other API names it will be
reviewed before making this API officially public / shipping.

Note: there is no intended functional change with this PR, it is purely
just refactoring the API shape around.

Rebuild API shape

513010d

This breaks up `BuildConstructor` into a simple hierarchy with bothCSharp and Visual Basic implementations. The name `CompilationFactory`was chosen after a bit of offline conversation and mostly due to thisrepresenting a factory of sorts. As with all other API names it will bereviewed before making this API officially public / shipping.Note: there is no intended functional change with this PR, it is purelyjust refactoring the API shape around.

jaredpar added Area-Compilers Feature - RebuildCompiler ability to verify provenance of code via rebuild operations labels

Mar 23, 2021

jaredpar requested review froma team ascode owners

March 23, 2021 15:17

Copy link

MemberAuthor

jaredpar commentedMar 23, 2021

@dotnet/roslyn-compiler,@RikkiGibson PTAL

RikkiGibson self-assigned this

Mar 23, 2021

RikkiGibson approved these changes

Mar 23, 2021

View reviewed changes

src/Compilers/Core/Rebuild/CSharpCompilationFactory.csShow resolvedHide resolved

src/Compilers/Core/Rebuild/CSharpCompilationFactory.cs OutdatedShow resolvedHide resolved

src/Compilers/Core/Rebuild/CompilationFactory.cs OutdatedShow resolvedHide resolved

src/Compilers/Core/Rebuild/VisualBasicCompilationFactory.cs OutdatedShow resolvedHide resolved

src/Compilers/Core/Rebuild/CSharpCompilationFactory.cs OutdatedShow resolvedHide resolved

src/Tools/BuildValidator/Program.cs OutdatedShow resolvedHide resolved

src/Compilers/Core/Rebuild/VisualBasicCompilationFactory.csShow resolvedHide resolved

jaredparand others added2 commits

March 23, 2021 16:58

Apply suggestions from code review

375e953

Co-authored-by: Rikki Gibson <rikkigibson@gmail.com>

PR Feedback

cda208d

Copy link

MemberAuthor

jaredpar commentedMar 24, 2021

Responded to PR feedback

RikkiGibson reviewed

Mar 24, 2021

View reviewed changes

src/Compilers/Core/Rebuild/CSharpCompilationFactory.cs Outdated

		publicoverrideParseOptionsParseOptions=>CSharpParseOptions;
		publicoverrideCompilationOptionsCompilationOptions=>CSharpCompilationOptions;
		publicCSharpParseOptionsCSharpParseOptions{get;}
		publicCSharpCompilationOptionsCSharpCompilationOptions{get;}

Copy link

Member

RikkiGibsonMar 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

looks good!

RikkiGibson approved these changes

Mar 24, 2021

View reviewed changes

Copy link

MemberAuthor

jaredpar commentedMar 24, 2021

@roslyn-compiler can I get a second review on this?

cston reviewed

Mar 24, 2021

View reviewed changes

src/Compilers/Core/Rebuild/CompilationFactory.cs OutdatedShow resolvedHide resolved

cston reviewed

Mar 24, 2021

View reviewed changes

src/Compilers/Core/Rebuild/CSharpCompilationFactory.cs OutdatedShow resolvedHide resolved

cston reviewed

Mar 24, 2021

View reviewed changes

src/Compilers/Core/Rebuild/CSharpCompilationFactory.csShow resolvedHide resolved

cston reviewed

Mar 24, 2021

View reviewed changes

src/Compilers/Core/Rebuild/VisualBasicCompilationFactory.csShow resolvedHide resolved

cston reviewed

Mar 24, 2021

View reviewed changes

src/Compilers/Core/Rebuild/VisualBasicCompilationFactory.cs OutdatedShow resolvedHide resolved

cston reviewed

Mar 24, 2021

View reviewed changes

src/Compilers/Core/Rebuild/CSharpCompilationFactory.cs OutdatedShow resolvedHide resolved

cston reviewed

Mar 24, 2021

View reviewed changes

src/Compilers/Core/Rebuild/VisualBasicCompilationFactory.cs OutdatedShow resolvedHide resolved

jaredpar added2 commits

March 23, 2021 21:29

PR feedback

79f5096

PR feedback

16703c3

cston approved these changes

Mar 24, 2021

View reviewed changes

jaredpar merged commit7fea27a intodotnet:main

Mar 24, 2021

ghost added this to theNext milestone

Mar 24, 2021

jaredpar deleted the factory branch

March 24, 2021 14:26

333fred mentioned this pull request

Mar 25, 2021

merge main#52156

Merged

333fred added a commit to 333fred/roslyn that referenced this pull request

Mar 25, 2021

Merge remote-tracking branch 'upstream/main' into merge-main

fd2072d

* upstream/main: (75 commits)  Split BoundInterpolatedString into BoundInterpolatedString and BoundUnconvertedInterpolatedString (dotnet#52061)  Combine VB comparers into one, and combine VB and C# comparers together (dotnet#51834)  Use OptimizedVSCompletionList in LSP scenarios.  F5 Hot Reload (dotnet#52101)  Fix typescript shim  Add tests for lazy syntax trees coming from the GeneratorDriver  React to code review feedback.  Simplify the lazy-initalization pattern used in GetRoot  Remove an unnecessary override. (dotnet#52140)  Update issue number (dotnet#52130)  Enable CodeActions support for XAML using its own provider and CodeActionCache. The handlers are actually shared with Roslyn as is. (dotnet#52129)  Add RestrictedIVT to dotnet watch to Features (dotnet#52087)  Don't try to highlight operators (dotnet#52041)  Use `null` instead of empty signature helps in LSP  Use member type for relational pattern even in error cases (dotnet#51950)  Update src/VisualStudio/Xaml/Impl/Implementation/LanguageServer/Extensions/SymbolExtensions.cs  Use new QuickInfoUtilities helper  Rebuild API shape (dotnet#52079)  Added position parameter name  Updated XAML QuickInfo to show more info like C# by using ISymbolDisplayService and adding more documentation parts.  ...