Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Enable LSP pull model diagnostic for XAML.#49145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mgoertz-msft merged 3 commits intodotnet:masterfromLinglingTong:dev/ltong/pulldiagnostic
Nov 9, 2020
Merged

Enable LSP pull model diagnostic for XAML.#49145

mgoertz-msft merged 3 commits intodotnet:masterfromLinglingTong:dev/ltong/pulldiagnostic
Nov 9, 2020

Conversation

@LinglingTong
Copy link
Contributor

This pull request enables LSP pull model diagnostic for XAML.

We are keeping SupportsDiagnosticRequests in our current XamlInProcLanguageClient and we will expect pull model diagnostic to run with DisableUserExperiece equals true after the following bug gets fixed.
Bug 1237034: [Nexus] Pull Model Diagnostic doesn't work with LanguageClient with DisableUserExperience set to true.

@dnfadmin
Copy link

dnfadmin commentedNov 2, 2020•
edited
Loading

CLA assistant check
All CLA requirements met.

@jinujosephjinujoseph added the CommunityThe pull request was submitted by a contributor who is not a Microsoft employee. labelNov 2, 2020
@LinglingTong
Copy link
ContributorAuthor

@CyrusNajmabadi I have made the change based on all your comments, could you take a look? :)

@mgoertz-msftmgoertz-msft merged commit2a08a60 intodotnet:masterNov 9, 2020
@ghostghost added this to theNext milestoneNov 9, 2020
333fred added a commit to 333fred/roslyn that referenced this pull requestNov 9, 2020
* upstream/master: (519 commits)  Remove workaround in PEMethodSymbol.ExplicitInterfaceImplementations (dotnet#49246)  Enable LSP pull model diagnostic for XAML. (dotnet#49145)  Update dependencies fromhttps://github.com/dotnet/roslyn build 20201109.8 (dotnet#49240)  Add test for with expression in F1 help service (dotnet#49236)  Cache RegexPatternDetector per compilation  Fix RazorRemoteHostClient to maintain binary back-compat  Further tweak inline hints  Fix MemberNames API for records (dotnet#49138)  Minor cleanups (dotnet#49204)  Report warning for assignment or explicit cast of possibly null value of unconstrained type parameter type (dotnet#48803)  Clean up of EditorFeatures.Cocoa.Snippets (dotnet#49188)  Fix OK button state handling. Make relation between viewmodels more tightly coupled  Extend make type abstract to include records (dotnet#48227)  Remove duplicated implementations of C# event hookup  Add select all/deselect all buttons  Consolidate conditional compilation (dotnet#49150)  Implement IEquatable on Microsoft.Cci.DefinitionWithLocation structure (dotnet#49162)  Add new document extensions file  Unify implementations  Only disable structure tagger provider in LSP scenario  ...
@allisonchouallisonchou modified the milestones:Next,16.9.P2Nov 24, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@CyrusNajmabadiCyrusNajmabadiCyrusNajmabadi approved these changes

+1 more reviewer

@mgoertz-msftmgoertz-msftmgoertz-msft left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@CyrusNajmabadiCyrusNajmabadi

Labels

Area-IDECommunityThe pull request was submitted by a contributor who is not a Microsoft employee.

Projects

None yet

Milestone

16.9.P2

Development

Successfully merging this pull request may close these issues.

7 participants

@LinglingTong@dnfadmin@CyrusNajmabadi@mgoertz-msft@jinujoseph@allisonchou@Dotnet-GitSync-Bot
[8]ページ先頭
©2009-2025 Movatter.jp