- Notifications
You must be signed in to change notification settings - Fork4.2k
Raise the default warning level in tests#47077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
43 commits Select commitHold shift + click to select a range
af25f47 Raise the default warning level in tests
Youssef13137faffae Update CompilationWithAnalyzersTests.cs
Youssef1313d77232d Update MetadataMemberTests.cs
Youssef1313dd454c4 Update CSharpDeterministicBuildCompilationTests.cs
Youssef1313a80d03e Update AssemblyAndNamespaceTests.cs
Youssef1313ceed1f8 Update MetadataMemberTests.cs
Youssef1313afc64be Update CompilationWithAnalyzersTests.cs
Youssef1313f0950fc More updates
Youssef1313f2114f2 Update MetadataMemberTests.cs
Youssef131354b0c34 Update AssemblyAndNamespaceTests.cs
Youssef1313368a08f Update AssemblyAndNamespaceTests.cs
Youssef131349709b9 Update MetadataMemberTests.cs
Youssef1313d773bed More work
Youssef1313bc9d1c0 More
Youssef131339c9106 More
Youssef1313f5a4770 Update InterpolationTests.cs
Youssef13132ce9c1e More fixes
Youssef1313ef5af4b More fixes
Youssef13134a422d8 Remove field
Youssef1313248daa8 Fix WarningVersionTests by explicitly using DefaultWarningLevel when …
Youssef131399783b0 Fix Microsoft.CodeAnalysis.CSharp.Semantic.UnitTests + One TODO
Youssef1313a94ec22 TODO in NameCollisionTests.TestCollisionInsideFor2
Youssef1313d469c4f Fix a few more tests
Youssef13135ea9ff7 Address feedback
Youssef131355141e6 Fix an unintentional mistake
Youssef13138704b06 Apply suggestions from code review
Youssef1313df16740 Fix TestCollisionInsideFor2
Youssef1313a56b3e2 Add WRN_SyncAndAsyncEntryPoints to expected diagnostics
Youssef13130b5bac7 Add WRN_SyncAndAsyncEntryPoints to expected diagnostics
Youssef131342af28b Update src/Compilers/CSharp/Test/Emit/PDB/CSharpDeterministicBuildCom…
Youssef1313073cabe Merge branch 'master' into patch-19
Youssef131390a91ea Update CodeGenAsyncMainTests.cs
Youssef13132a0d753 Update SymbolErrorTests.cs
Youssef1313157b655 Update CodeGenFunctionPointersTests.cs
Youssef1313dc816b2 Update TopLevelStatementsTests.cs
Youssef1313ff7d2ec Fix more tests
Youssef131380ada6c Merge branch 'master' into patch-19
Youssef1313133d393 Remove ReleaseDllWithWarningLevel5 field
Youssef13137815651 Update SymbolErrorTests.cs
Youssef1313d9f2349 Merge branch 'master' into patch-19
Youssef1313b487ff8 Update InterpolationTests.cs
Youssef131379a7027 Update SymbolErrorTests.cs
Youssef1313fbbf3c7 Merge branch 'master' of github.com:dotnet/roslyn into patch-19
RikkiGibsonFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Fix WarningVersionTests by explicitly using DefaultWarningLevel when …
…needed
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit248daa8f6a0d66dc818abc1aadf1cba4cb3de4a4
There are no files selected for viewing
22 changes: 11 additions & 11 deletionssrc/Compilers/CSharp/Test/Semantic/Semantics/WarningVersionTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -43,7 +43,7 @@ struct S | ||
| // if (s != null) { } | ||
| Diagnostic(ErrorCode.WRN_NubExprIsConstBool2, "s != null").WithArguments("true", "S", "S?").WithLocation(7, 13) | ||
| }; | ||
| CreateCompilation(source, options: TestOptions.ReleaseDll.WithWarningLevel(CodeAnalysis.Diagnostic.DefaultWarningLevel)).VerifyDiagnostics(); | ||
| CreateCompilation(source, options: TestOptions.ReleaseDll.WithWarningLevel(3)).VerifyDiagnostics(); | ||
| CreateCompilation(source, options: TestOptions.ReleaseDll.WithWarningLevel(4)).VerifyDiagnostics(); | ||
| CreateCompilation(source, options: TestOptions.ReleaseDll.WithWarningLevel(5)).VerifyDiagnostics(whenWave5); | ||
MemberAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Do you want to remove the explicit WithWarningLevel here? Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Let's leave it as-is, especially since we don't use 5 as our default warning level in tests, we use MaxWarningLevel. | ||
| @@ -73,7 +73,7 @@ static class SC { } | ||
| // _ = o as SC; | ||
| Diagnostic(ErrorCode.WRN_StaticInAsOrIs, "o as SC").WithArguments("SC").WithLocation(7, 17) | ||
| }; | ||
| CreateCompilation(source, options: TestOptions.ReleaseDll.WithWarningLevel(CodeAnalysis.Diagnostic.DefaultWarningLevel)).VerifyDiagnostics(); | ||
| CreateCompilation(source, options: TestOptions.ReleaseDll.WithWarningLevel(4)).VerifyDiagnostics(); | ||
| CreateCompilation(source, options: TestOptions.ReleaseDll.WithWarningLevel(5)).VerifyDiagnostics(whenWave5); | ||
| } | ||
| @@ -112,7 +112,7 @@ static void M2() | ||
| // var i = ()=>{} + x; | ||
| Diagnostic(ErrorCode.WRN_PrecedenceInversion, "+").WithArguments("+").WithLocation(20, 24) | ||
| }; | ||
| CreateCompilation(source, options: TestOptions.ReleaseDll.WithWarningLevel(CodeAnalysis.Diagnostic.DefaultWarningLevel)).VerifyDiagnostics(); | ||
| CreateCompilation(source, options: TestOptions.ReleaseDll.WithWarningLevel(4)).VerifyDiagnostics(); | ||
| CreateCompilation(source, options: TestOptions.ReleaseDll.WithWarningLevel(5)).VerifyDiagnostics(whenWave5); | ||
| } | ||
| @@ -137,7 +137,7 @@ public Program(int dummy) | ||
| { | ||
| } | ||
| }"; | ||
| CreateCompilation(source2, references: new MetadataReference[] { moduleReference }, options: TestOptions.ReleaseDll.WithWarningLevel(CodeAnalysis.Diagnostic.DefaultWarningLevel)).VerifyDiagnostics( | ||
| ); | ||
| CreateCompilation(source2, references: new MetadataReference[] { moduleReference }, options: TestOptions.ReleaseDll.WithWarningLevel(5)).VerifyDiagnostics( | ||
| // (4,12): warning CS8822: Auto-implemented property 'Program.Property' must be fully assigned before control is returned to the caller. | ||
| @@ -166,7 +166,7 @@ public Program(int dummy) | ||
| { | ||
| } | ||
| }"; | ||
| CreateCompilation(source2, references: new MetadataReference[] { moduleReference }, options: TestOptions.ReleaseDll.WithWarningLevel(CodeAnalysis.Diagnostic.DefaultWarningLevel)).VerifyDiagnostics( | ||
| ); | ||
| CreateCompilation(source2, references: new MetadataReference[] { moduleReference }, options: TestOptions.ReleaseDll.WithWarningLevel(5)).VerifyDiagnostics( | ||
| // (4,12): warning CS8823: Field 'Program.Field' must be fully assigned before control is returned to the caller | ||
| @@ -194,7 +194,7 @@ void M(out Struct param) | ||
| { | ||
| } | ||
| }"; | ||
| CreateCompilation(source2, references: new MetadataReference[] { moduleReference }, options: TestOptions.ReleaseDll.WithWarningLevel(CodeAnalysis.Diagnostic.DefaultWarningLevel)).VerifyDiagnostics( | ||
| ); | ||
| CreateCompilation(source2, references: new MetadataReference[] { moduleReference }, options: TestOptions.ReleaseDll.WithWarningLevel(5)).VerifyDiagnostics( | ||
| // (3,10): warning CS8824: The out parameter 'param' must be assigned to before control leaves the current method | ||
| @@ -225,7 +225,7 @@ public struct Struct | ||
| Property = default; | ||
| } | ||
| }"; | ||
| CreateCompilation(source2, references: new MetadataReference[] { moduleReference }, options: TestOptions.ReleaseDll.WithWarningLevel(CodeAnalysis.Diagnostic.DefaultWarningLevel)).VerifyDiagnostics( | ||
| ); | ||
| CreateCompilation(source2, references: new MetadataReference[] { moduleReference }, options: TestOptions.ReleaseDll.WithWarningLevel(5)).VerifyDiagnostics( | ||
| // (6,21): warning CS8825: Use of possibly unassigned auto-implemented property 'Property' | ||
| @@ -256,7 +256,7 @@ public struct Struct | ||
| Field = default; | ||
| } | ||
| }"; | ||
| CreateCompilation(source2, references: new MetadataReference[] { moduleReference }, options: TestOptions.ReleaseDll.WithWarningLevel(CodeAnalysis.Diagnostic.DefaultWarningLevel)).VerifyDiagnostics( | ||
| ); | ||
| CreateCompilation(source2, references: new MetadataReference[] { moduleReference }, options: TestOptions.ReleaseDll.WithWarningLevel(5)).VerifyDiagnostics( | ||
| // (6,21): warning CS8826: Use of possibly unassigned field 'Field' | ||
| @@ -287,7 +287,7 @@ public struct Struct | ||
| this.Field = default; | ||
| } | ||
| }"; | ||
| CreateCompilation(source2, references: new MetadataReference[] { moduleReference }, options: TestOptions.ReleaseDll.WithWarningLevel(CodeAnalysis.Diagnostic.DefaultWarningLevel)).VerifyDiagnostics( | ||
| ); | ||
| CreateCompilation(source2, references: new MetadataReference[] { moduleReference }, options: TestOptions.ReleaseDll.WithWarningLevel(5)).VerifyDiagnostics( | ||
| // (6,22): warning CS8827: The 'this' object cannot be used before all of its fields have been assigned | ||
| @@ -317,7 +317,7 @@ public static void M(out Struct r1) | ||
| r1 = default; | ||
| } | ||
| }"; | ||
| CreateCompilation(source2, references: new MetadataReference[] { moduleReference }, options: TestOptions.ReleaseDll.WithWarningLevel(CodeAnalysis.Diagnostic.DefaultWarningLevel)).VerifyDiagnostics( | ||
| ); | ||
| CreateCompilation(source2, references: new MetadataReference[] { moduleReference }, options: TestOptions.ReleaseDll.WithWarningLevel(5)).VerifyDiagnostics( | ||
| // (5,18): warning CS8828: Use of unassigned out parameter 'r1' | ||
| @@ -347,7 +347,7 @@ public static void Main() | ||
| var r2 = r1; | ||
| } | ||
| }"; | ||
| CreateCompilation(source2, references: new MetadataReference[] { moduleReference }, options: TestOptions.ReleaseDll.WithWarningLevel(CodeAnalysis.Diagnostic.DefaultWarningLevel)).VerifyDiagnostics( | ||
| ); | ||
| CreateCompilation(source2, references: new MetadataReference[] { moduleReference }, options: TestOptions.ReleaseDll.WithWarningLevel(5)).VerifyDiagnostics( | ||
| // (6,18): warning CS8829: Use of unassigned local variable 'r1' | ||
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.